From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93D7C433DB for ; Mon, 22 Feb 2021 06:29:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 268F1614A7 for ; Mon, 22 Feb 2021 06:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 268F1614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lE4j9-0005H1-AM for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 01:29:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lE4iU-0004qd-SE for qemu-devel@nongnu.org; Mon, 22 Feb 2021 01:29:10 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:34763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lE4iT-0002L0-7l for qemu-devel@nongnu.org; Mon, 22 Feb 2021 01:29:10 -0500 Received: by mail-pj1-x1030.google.com with SMTP id my11so6260885pjb.1 for ; Sun, 21 Feb 2021 22:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pSzypxyXmjakyx97eKf31F3sCLfmf6SnzsofLcuMSPE=; b=ngacGl1sDUq6QeSb+TxofrFKpYWeLd3+kgQdsCOfvLgVeNnTIgAyDNDxv0aWQZjCWR v1YUO+ZnHk+62IM264f6p46Uwz2zFNQ1ZsKcl5E55WqK+LXfGzpvkkmxx8k2bYJARkVZ nkZQN3E9I0NYpTahvspkOvA5bInP7yrDRees3rx2IvEwKcsj8Y3dqZ4nh9SJfXAZSpba qgizWpN0gJnQ4fYXigPOdFm2cukRYJpBA5Ds0Lr+AQX6WK6yWzBPTwD48aIKuAIIJSyv WniICeHSLt5BQPQBP0R1O8rORN4Z49wHF4lI4pXUQrflrAO8/6DYyWMWSdwwUqQLOIgo SJMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pSzypxyXmjakyx97eKf31F3sCLfmf6SnzsofLcuMSPE=; b=Jt4I4bIDuoZHN+mWUXSmkp2fdtLxXFNmmypoJ1+FJgK+XC44Ce1bmkaVPJmXaQWkS5 OLUI3RQQTLN5D4NNFg2s9tBtWUpNGXDbYSeTt1RShK7PIBO/kI28gTCRGG2Y/n4vhfgW ofsor7zrIvNpmHaPWCmPSl7sHziDV4dPzr+fMCx3EXzs7JKfBa72tzNR3FOhby7ZcuGU rQzZf5vScs7nKjDJll4Ydc/6/3Tm+YE/LKt1VJ6522nshRFbeQebZFVYw4ZiTjtCcIwB XiTJ2zfHhp3Y/pwddGDojwEUTrkJF2VkA6yhNVffPjL/eUWi0FbsavWRKN1BneLzFUQP ZNdw== X-Gm-Message-State: AOAM5324JAE0Gj5rCMUGavxxM3I4F1uCKmDk0XqsSQKMaBloANZZu4jC N8GzLbrIcHVKvI390GbPMUiIuQ3JsnyzsQ== X-Google-Smtp-Source: ABdhPJx+NWGCkNly80ZpnTKaql3xXfkaww9C/OMJ5jeO4TnVL11Q8vGpby2YCWqyzypseIBitaLMRA== X-Received: by 2002:a17:902:ea09:b029:e3:a720:b83 with SMTP id s9-20020a170902ea09b02900e3a7200b83mr20568381plg.51.1613975347693; Sun, 21 Feb 2021 22:29:07 -0800 (PST) Received: from [192.168.1.11] (174-21-84-25.tukw.qwest.net. [174.21.84.25]) by smtp.gmail.com with ESMTPSA id u15sm8140946pfk.128.2021.02.21.22.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Feb 2021 22:29:07 -0800 (PST) Subject: Re: [RFC v1 08/38] target/arm/tcg: split softmmu parts of v8_cp_reginfo and el2_cp_reginfo To: Claudio Fontana References: <20210221092449.7545-1-cfontana@suse.de> <20210221092449.7545-9-cfontana@suse.de> From: Richard Henderson Message-ID: Date: Sun, 21 Feb 2021 22:29:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210221092449.7545-9-cfontana@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/21/21 1:24 AM, Claudio Fontana wrote: > From: Claudio Fontana > > since ats_write64 is only used there, make it softmmu-only. > > gt_cntvoff_write, gt_hyp_*_write and gt_hyp_timer_reset are only used > in el2_cp_reginfo, so they can be softmmu-only too. > > Signed-off-by: Claudio Fontana > --- > target/arm/tcg/helper-tcg.h | 16 ++-- > target/arm/tcg/helper.c | 129 +++------------------------- > target/arm/tcg/softmmu/helper.c | 145 +++++++++++++++++++++++++++++--- > 3 files changed, 149 insertions(+), 141 deletions(-) Hum. As long as we're moving code around, let's put all the cp_regs stuff in its own file, rather than creating another massive file with random stuff in it. r~