[PATCH] hw/ufs: Fix incorrect comment for segment_size and allocation_unit_size

[PATCH] hw/ufs: Fix incorrect comment for segment_size and allocation_unit_size

[Keoseong Park]

The comments for segment_size and allocation_unit_size incorrectly
described them as 4KB. According to the UFS specification,
segment_size is expressed in units of 512 bytes.
Given segment_size = 0x2000 (8192), the actual size is 4MB.
Similarly, allocation_unit_size = 1 means 1 segment = 4MB.

This patch updates the comments to reflect the correct size.

Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
 hw/ufs/ufs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index ee13edacd8..542f13b10e 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -1753,8 +1753,8 @@ static void ufs_init_hc(UfsHc *u)
     u->geometry_desc.length = sizeof(GeometryDescriptor);
     u->geometry_desc.descriptor_idn = UFS_QUERY_DESC_IDN_GEOMETRY;
     u->geometry_desc.max_number_lu = (UFS_MAX_LUS == 32) ? 0x1 : 0x0;
-    u->geometry_desc.segment_size = cpu_to_be32(0x2000); /* 4KB */
-    u->geometry_desc.allocation_unit_size = 0x1; /* 4KB */
+    u->geometry_desc.segment_size = cpu_to_be32(0x2000); /* 4MB: 8192 * 512B */
+    u->geometry_desc.allocation_unit_size = 0x1; /* 4MB: 1 segment */
     u->geometry_desc.min_addr_block_size = 0x8; /* 4KB */
     u->geometry_desc.max_in_buffer_size = 0x8;
     u->geometry_desc.max_out_buffer_size = 0x8;
-- 
2.25.1

Re: [PATCH] hw/ufs: Fix incorrect comment for segment_size and allocation_unit_size

[Jeuk Kim]

2025-04-03 오후 6:21에 Keoseong Park 이(가) 쓴 글:
> The comments for segment_size and allocation_unit_size incorrectly
> described them as 4KB. According to the UFS specification,
> segment_size is expressed in units of 512 bytes.
> Given segment_size = 0x2000 (8192), the actual size is 4MB.
> Similarly, allocation_unit_size = 1 means 1 segment = 4MB.
>
> This patch updates the comments to reflect the correct size.
>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
> ---
>   hw/ufs/ufs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
> index ee13edacd8..542f13b10e 100644
> --- a/hw/ufs/ufs.c
> +++ b/hw/ufs/ufs.c
> @@ -1753,8 +1753,8 @@ static void ufs_init_hc(UfsHc *u)
>       u->geometry_desc.length = sizeof(GeometryDescriptor);
>       u->geometry_desc.descriptor_idn = UFS_QUERY_DESC_IDN_GEOMETRY;
>       u->geometry_desc.max_number_lu = (UFS_MAX_LUS == 32) ? 0x1 : 0x0;
> -    u->geometry_desc.segment_size = cpu_to_be32(0x2000); /* 4KB */
> -    u->geometry_desc.allocation_unit_size = 0x1; /* 4KB */
> +    u->geometry_desc.segment_size = cpu_to_be32(0x2000); /* 4MB: 8192 * 512B */
> +    u->geometry_desc.allocation_unit_size = 0x1; /* 4MB: 1 segment */
>       u->geometry_desc.min_addr_block_size = 0x8; /* 4KB */
>       u->geometry_desc.max_in_buffer_size = 0x8;
>       u->geometry_desc.max_out_buffer_size = 0x8;


Thank you for the commit!

Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>