From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1c8qAT-0001NJ-IV
	for qemu-devel@nongnu.org; Mon, 21 Nov 2016 10:06:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1c8qAO-000472-Lo
	for qemu-devel@nongnu.org; Mon, 21 Nov 2016 10:06:01 -0500
References: <1479740113-26834-1-git-send-email-joserz@linux.vnet.ibm.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <b03ccb7d-7cff-48db-d373-23e0563f94c1@redhat.com>
Date: Mon, 21 Nov 2016 16:05:51 +0100
MIME-Version: 1.0
In-Reply-To: <1479740113-26834-1-git-send-email-joserz@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix index array of national
 digits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>, qemu-ppc@nongnu.org
Cc: david@gibson.dropbear.id.au, qemu-devel@nongnu.org

On 21.11.2016 15:55, Jose Ricardo Ziviani wrote:
> Fixes the big endian array access of national digits, from commits
> b815587 and e2106d7.
> 
> Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
> ---
>  target-ppc/int_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
> index 9ac204a..2d57c9a 100644
> --- a/target-ppc/int_helper.c
> +++ b/target-ppc/int_helper.c
> @@ -2572,7 +2572,7 @@ static int bcd_cmp_zero(ppc_avr_t *bcd)
>  static uint16_t get_national_digit(ppc_avr_t *reg, int n)
>  {
>  #if defined(HOST_WORDS_BIGENDIAN)
> -    return reg->u16[8 - n];
> +    return reg->u16[7 - n];
>  #else
>      return reg->u16[n];
>  #endif
> @@ -2581,7 +2581,7 @@ static uint16_t get_national_digit(ppc_avr_t *reg, int n)
>  static void set_national_digit(ppc_avr_t *reg, uint8_t val, int n)
>  {
>  #if defined(HOST_WORDS_BIGENDIAN)
> -    reg->u16[8 - n] = val;
> +    reg->u16[7 - n] = val;
>  #else
>      reg->u16[n] = val;
>  #endif
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>