From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJhTW-00011s-9f for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJhTU-0004oR-UY for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:54 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJhTT-0004mM-KB for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:52 -0400 Received: by mail-wm1-f66.google.com with SMTP id 26so139021wmj.3 for ; Thu, 25 Apr 2019 09:43:51 -0700 (PDT) References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-23-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 25 Apr 2019 18:43:47 +0200 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-23-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 22/29] hw/arm: Express dependencies of sabrelite with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com Cc: "Michael S. Tsirkin" , Gerd Hoffmann , "Edgar E . Iglesias" , Jean-Christophe Dubois , Rob Herring , qemu-block@nongnu.org, Andrey Smirnov , Joel Stanley , Antony Pavlov , Alistair Francis , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , Cedric Le Goater , John Snow , Andrew Jeffery , Philippe Mathieu-Daude , Subbaraya Sundeep , Igor Mitsyanko , Jan Kiszka Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the Sabrelite / iMX6 machine. > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 4 +--- > hw/arm/Kconfig | 7 +++++++ > hw/arm/Makefile.objs | 3 ++- > 3 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 76508e3910..ef7dd7156a 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -33,6 +33,7 @@ CONFIG_NETDUINO2=y > CONFIG_MPS2=y > CONFIG_RASPI=y > CONFIG_DIGIC=y > +CONFIG_SABRELITE=y > > CONFIG_VGA=y > CONFIG_SSI_M25P80=y > @@ -40,13 +41,10 @@ CONFIG_IMX_FEC=y > > CONFIG_NRF51_SOC=y > > -CONFIG_FSL_IMX6=y > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > > -CONFIG_IMX_I2C=y > - > CONFIG_PCIE_PORT=y > CONFIG_XIO3130=y > CONFIG_IOH3420=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 059fb8282c..065c7acf1b 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -177,6 +177,10 @@ config REALVIEW > select DS1338 # I2C RTC+NVRAM > select USB_OHCI > > +config SABRELITE > + bool > + select FSL_IMX6 This one crashes: $ qemu-system-aarch64 -display none -M sabrelite ERROR:/source/qemu/qom/object.c:454:object_initialize_with_type: assertion failed: (type != NULL) Aborted (core dumped) (gdb) bt #3 0x00007f71139fb4de in g_assertion_message_expr () at /lib64/libglib-2.0.so.0 [...] #8 0x000055a148c5eec9 in sysbus_init_child_obj (parent=parent@entry=0x55a14a2fbe10, childname=childname@entry=0x55a148ed3713 "eth", child=child@entry=0x55a14a33e0a0, childsize=childsize@entry=27296, childtype=childtype@entry=0x55a148ed370a "imx.enet") at /source/qemu/hw/core/sysbus.c:373 #9 0x000055a148b37b82 in fsl_imx6_init (obj=0x55a14a2fbe10) at /source/qemu/hw/arm/fsl-imx6.c:91 #10 0x000055a148d0fb17 in object_initialize_with_type (data=data@entry=0x55a14a2fbe10, size=size@entry=299248, type=0x55a14a27dbd0) at /source/qemu/qom/object.c:466 #11 0x000055a148d0fe5d in object_initialize (data=data@entry=0x55a14a2fbe10, size=size@entry=299248, typename=typename@entry=0x55a148ed3328 "fsl,imx6") at /source/qemu/qom/object.c:474 #12 0x000055a148b35ced in sabrelite_init (machine=0x55a14a2c1300) at /source/qemu/hw/arm/sabrelite.c:58 #13 0x000055a148c608bb in machine_run_board_init (machine=0x55a14a2c1300) at /source/qemu/hw/core/machine.c:1030 [...] Then: $ qemu-system-aarch64 -display none -nodefaults -M sabrelite qemu-system-aarch64: Unknown device 'sst25vf016b' for bus 'SSI' Aborted (core dumped) I got it working using the following snippet: -- >8 -- @@ -186,6 +186,7 @@ config REALVIEW config SABRELITE bool select FSL_IMX6 + select SSI_M25P80 config STELLARIS bool @@ -321,6 +322,7 @@ config FSL_IMX6 select A9MPCORE select IMX select IMX_I2C + select IMX_FEC select SDHCI config ASPEED_SOC --- With this snippet amended: Reviewed-by: Philippe Mathieu-Daudé > + > config STELLARIS > bool > select ARM_V7M > @@ -289,6 +293,9 @@ config FSL_IMX31 > > config FSL_IMX6 > bool > + select A9MPCORE > + select IMX > + select IMX_I2C > > config ASPEED_SOC > bool > diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs > index 4f591ca487..fadd69882c 100644 > --- a/hw/arm/Makefile.objs > +++ b/hw/arm/Makefile.objs > @@ -22,6 +22,7 @@ obj-$(CONFIG_COLLIE) += collie.o > obj-$(CONFIG_VERSATILE) += versatilepb.o > obj-$(CONFIG_VEXPRESS) += vexpress.o > obj-$(CONFIG_ZYNQ) += xilinx_zynq.o > +obj-$(CONFIG_SABRELITE) += sabrelite.o > > obj-$(CONFIG_ARM_V7M) += armv7m.o > obj-$(CONFIG_EXYNOS4) += exynos4210.o > @@ -36,7 +37,7 @@ obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o > obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o xlnx-versal-virt.o > obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o > obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o > -obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o > +obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o > obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o > obj-$(CONFIG_MPS2) += mps2.o > obj-$(CONFIG_MPS2) += mps2-tz.o > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B783C43218 for ; Thu, 25 Apr 2019 16:45:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0198D206BF for ; Thu, 25 Apr 2019 16:45:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0198D206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:60689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJhUo-0001id-2K for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 12:45:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJhTW-00011s-9f for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJhTU-0004oR-UY for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:54 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJhTT-0004mM-KB for qemu-devel@nongnu.org; Thu, 25 Apr 2019 12:43:52 -0400 Received: by mail-wm1-f66.google.com with SMTP id 26so139021wmj.3 for ; Thu, 25 Apr 2019 09:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dx32jx1mFqAoq4UidFoSljGlessTpYZy6WMKWboPJgg=; b=Vz5gtMA1ftnD3Bb5wEHl8aAyuAXluQjVVfyV70+vBHkFAmN8n3B0aGpGhZd7O/aNq7 FCPjGR1wJvE3+15wbT58+B8rLJYQulQyfIIk3dnVhuqpNt0mrPL+KDCj9YTi0ShK7jQx w/euioyICGlvtfTF4tfKPBaQihA5nfEYdBjzwtm3wNUtiq26BqLDiVl52kc6kLzLKi6N dwg8bvJZwnVLMhUbxW/QhB93FRp0hVlmHKnMYjiXasXsLfD8xGq6YKo0F793jige4c12 +R3zXZZ2YulqtDFggspXWFjNHjjz3qfS695fZP3CjXZpC9NkHlCB3lXseU4RcuE1XPSj Goxg== X-Gm-Message-State: APjAAAUamK/bokupIAkvnxlpBCxWdREG3/YANLVaX5RVgNHfx9Ijvwxt XaPKiX8f2RgcMBnzLGuq/8261g== X-Google-Smtp-Source: APXvYqydfTJl7bqICM5pq5PdToeBe1N/MNg6iGO2Aq3+bOgXZiMu0XNYLh7gicxnAw+7In/6o6RuOQ== X-Received: by 2002:a1c:e912:: with SMTP id q18mr4192227wmc.137.1556210630362; Thu, 25 Apr 2019 09:43:50 -0700 (PDT) Received: from [192.168.1.25] (abayonne-654-1-209-122.w109-222.abo.wanadoo.fr. [109.222.216.122]) by smtp.gmail.com with ESMTPSA id v184sm34820967wma.6.2019.04.25.09.43.48 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 09:43:49 -0700 (PDT) To: Thomas Huth , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-23-thuth@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 25 Apr 2019 18:43:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418180057.3593-23-thuth@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.66 Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 22/29] hw/arm: Express dependencies of sabrelite with Kconfig X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jan Kiszka , Igor Mitsyanko , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrey Smirnov , Alistair Francis , Philippe Mathieu-Daude , Jean-Christophe Dubois , Beniamino Galvani , Andrew Jeffery , Cedric Le Goater , qemu-arm@nongnu.org, Peter Chubb , Gerd Hoffmann , Antony Pavlov , "Edgar E . Iglesias" , Subbaraya Sundeep , John Snow , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425164347.d6JzYVcvD5bGSm6JOsvdN4fTVPYrtRnBIYBJQwX_CbA@z> Hi Thomas, On 4/18/19 8:00 PM, Thomas Huth wrote: > Add Kconfig dependencies for the Sabrelite / iMX6 machine. > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 4 +--- > hw/arm/Kconfig | 7 +++++++ > hw/arm/Makefile.objs | 3 ++- > 3 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 76508e3910..ef7dd7156a 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -33,6 +33,7 @@ CONFIG_NETDUINO2=y > CONFIG_MPS2=y > CONFIG_RASPI=y > CONFIG_DIGIC=y > +CONFIG_SABRELITE=y > > CONFIG_VGA=y > CONFIG_SSI_M25P80=y > @@ -40,13 +41,10 @@ CONFIG_IMX_FEC=y > > CONFIG_NRF51_SOC=y > > -CONFIG_FSL_IMX6=y > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > > -CONFIG_IMX_I2C=y > - > CONFIG_PCIE_PORT=y > CONFIG_XIO3130=y > CONFIG_IOH3420=y > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 059fb8282c..065c7acf1b 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -177,6 +177,10 @@ config REALVIEW > select DS1338 # I2C RTC+NVRAM > select USB_OHCI > > +config SABRELITE > + bool > + select FSL_IMX6 This one crashes: $ qemu-system-aarch64 -display none -M sabrelite ERROR:/source/qemu/qom/object.c:454:object_initialize_with_type: assertion failed: (type != NULL) Aborted (core dumped) (gdb) bt #3 0x00007f71139fb4de in g_assertion_message_expr () at /lib64/libglib-2.0.so.0 [...] #8 0x000055a148c5eec9 in sysbus_init_child_obj (parent=parent@entry=0x55a14a2fbe10, childname=childname@entry=0x55a148ed3713 "eth", child=child@entry=0x55a14a33e0a0, childsize=childsize@entry=27296, childtype=childtype@entry=0x55a148ed370a "imx.enet") at /source/qemu/hw/core/sysbus.c:373 #9 0x000055a148b37b82 in fsl_imx6_init (obj=0x55a14a2fbe10) at /source/qemu/hw/arm/fsl-imx6.c:91 #10 0x000055a148d0fb17 in object_initialize_with_type (data=data@entry=0x55a14a2fbe10, size=size@entry=299248, type=0x55a14a27dbd0) at /source/qemu/qom/object.c:466 #11 0x000055a148d0fe5d in object_initialize (data=data@entry=0x55a14a2fbe10, size=size@entry=299248, typename=typename@entry=0x55a148ed3328 "fsl,imx6") at /source/qemu/qom/object.c:474 #12 0x000055a148b35ced in sabrelite_init (machine=0x55a14a2c1300) at /source/qemu/hw/arm/sabrelite.c:58 #13 0x000055a148c608bb in machine_run_board_init (machine=0x55a14a2c1300) at /source/qemu/hw/core/machine.c:1030 [...] Then: $ qemu-system-aarch64 -display none -nodefaults -M sabrelite qemu-system-aarch64: Unknown device 'sst25vf016b' for bus 'SSI' Aborted (core dumped) I got it working using the following snippet: -- >8 -- @@ -186,6 +186,7 @@ config REALVIEW config SABRELITE bool select FSL_IMX6 + select SSI_M25P80 config STELLARIS bool @@ -321,6 +322,7 @@ config FSL_IMX6 select A9MPCORE select IMX select IMX_I2C + select IMX_FEC select SDHCI config ASPEED_SOC --- With this snippet amended: Reviewed-by: Philippe Mathieu-Daudé > + > config STELLARIS > bool > select ARM_V7M > @@ -289,6 +293,9 @@ config FSL_IMX31 > > config FSL_IMX6 > bool > + select A9MPCORE > + select IMX > + select IMX_I2C > > config ASPEED_SOC > bool > diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs > index 4f591ca487..fadd69882c 100644 > --- a/hw/arm/Makefile.objs > +++ b/hw/arm/Makefile.objs > @@ -22,6 +22,7 @@ obj-$(CONFIG_COLLIE) += collie.o > obj-$(CONFIG_VERSATILE) += versatilepb.o > obj-$(CONFIG_VEXPRESS) += vexpress.o > obj-$(CONFIG_ZYNQ) += xilinx_zynq.o > +obj-$(CONFIG_SABRELITE) += sabrelite.o > > obj-$(CONFIG_ARM_V7M) += armv7m.o > obj-$(CONFIG_EXYNOS4) += exynos4210.o > @@ -36,7 +37,7 @@ obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o > obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o xlnx-versal-virt.o > obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o > obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o > -obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o > +obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o > obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o > obj-$(CONFIG_MPS2) += mps2.o > obj-$(CONFIG_MPS2) += mps2-tz.o >