* [PATCH] hw/nvram: use at24 macro
@ 2022-01-19 21:43 Patrick Venture
2022-01-19 22:48 ` Philippe Mathieu-Daudé via
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Patrick Venture @ 2022-01-19 21:43 UTC (permalink / raw)
To: philmd; +Cc: qemu-devel, Patrick Venture
Use the macro for going from I2CSlave to EEPROMState.
Signed-off-by: Patrick Venture <venture@google.com>
---
hw/nvram/eeprom_at24c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
index af6f5dbb99..da435500ba 100644
--- a/hw/nvram/eeprom_at24c.c
+++ b/hw/nvram/eeprom_at24c.c
@@ -54,7 +54,7 @@ struct EEPROMState {
static
int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
{
- EEPROMState *ee = container_of(s, EEPROMState, parent_obj);
+ EEPROMState *ee = AT24C_EE(s);
switch (event) {
case I2C_START_SEND:
--
2.34.1.703.g22d0c6ccf7-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/nvram: use at24 macro
2022-01-19 21:43 [PATCH] hw/nvram: use at24 macro Patrick Venture
@ 2022-01-19 22:48 ` Philippe Mathieu-Daudé via
2022-01-24 19:46 ` Patrick Venture
2022-01-25 9:20 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-19 22:48 UTC (permalink / raw)
To: Patrick Venture, philmd; +Cc: qemu-devel
On 19/1/22 22:43, Patrick Venture wrote:
> Use the macro for going from I2CSlave to EEPROMState.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> hw/nvram/eeprom_at24c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/nvram: use at24 macro
2022-01-19 21:43 [PATCH] hw/nvram: use at24 macro Patrick Venture
2022-01-19 22:48 ` Philippe Mathieu-Daudé via
@ 2022-01-24 19:46 ` Patrick Venture
2022-01-25 9:20 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Patrick Venture @ 2022-01-24 19:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Corey Minyard; +Cc: QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Wed, Jan 19, 2022 at 1:43 PM Patrick Venture <venture@google.com> wrote:
> Use the macro for going from I2CSlave to EEPROMState.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> hw/nvram/eeprom_at24c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
> index af6f5dbb99..da435500ba 100644
> --- a/hw/nvram/eeprom_at24c.c
> +++ b/hw/nvram/eeprom_at24c.c
> @@ -54,7 +54,7 @@ struct EEPROMState {
> static
> int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
> {
> - EEPROMState *ee = container_of(s, EEPROMState, parent_obj);
> + EEPROMState *ee = AT24C_EE(s);
>
> switch (event) {
> case I2C_START_SEND:
> --
> 2.34.1.703.g22d0c6ccf7-goog
>
+Corey - thanks!
[-- Attachment #2: Type: text/html, Size: 1304 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/nvram: use at24 macro
2022-01-19 21:43 [PATCH] hw/nvram: use at24 macro Patrick Venture
2022-01-19 22:48 ` Philippe Mathieu-Daudé via
2022-01-24 19:46 ` Patrick Venture
@ 2022-01-25 9:20 ` Paolo Bonzini
2022-02-21 17:23 ` Laurent Vivier
2 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2022-01-25 9:20 UTC (permalink / raw)
To: Patrick Venture, philmd; +Cc: qemu-trivial@nongnu.org, qemu-devel
On 1/19/22 22:43, Patrick Venture wrote:
> Use the macro for going from I2CSlave to EEPROMState.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> hw/nvram/eeprom_at24c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
> index af6f5dbb99..da435500ba 100644
> --- a/hw/nvram/eeprom_at24c.c
> +++ b/hw/nvram/eeprom_at24c.c
> @@ -54,7 +54,7 @@ struct EEPROMState {
> static
> int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
> {
> - EEPROMState *ee = container_of(s, EEPROMState, parent_obj);
> + EEPROMState *ee = AT24C_EE(s);
>
> switch (event) {
> case I2C_START_SEND:
Cc: qemu-trivial@nongnu.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/nvram: use at24 macro
2022-01-25 9:20 ` Paolo Bonzini
@ 2022-02-21 17:23 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2022-02-21 17:23 UTC (permalink / raw)
To: Paolo Bonzini, Patrick Venture, philmd
Cc: qemu-trivial@nongnu.org, qemu-devel
Le 25/01/2022 à 10:20, Paolo Bonzini a écrit :
> On 1/19/22 22:43, Patrick Venture wrote:
>> Use the macro for going from I2CSlave to EEPROMState.
>>
>> Signed-off-by: Patrick Venture <venture@google.com>
>> ---
>> hw/nvram/eeprom_at24c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
>> index af6f5dbb99..da435500ba 100644
>> --- a/hw/nvram/eeprom_at24c.c
>> +++ b/hw/nvram/eeprom_at24c.c
>> @@ -54,7 +54,7 @@ struct EEPROMState {
>> static
>> int at24c_eeprom_event(I2CSlave *s, enum i2c_event event)
>> {
>> - EEPROMState *ee = container_of(s, EEPROMState, parent_obj);
>> + EEPROMState *ee = AT24C_EE(s);
>> switch (event) {
>> case I2C_START_SEND:
>
> Cc: qemu-trivial@nongnu.org
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-21 17:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-19 21:43 [PATCH] hw/nvram: use at24 macro Patrick Venture
2022-01-19 22:48 ` Philippe Mathieu-Daudé via
2022-01-24 19:46 ` Patrick Venture
2022-01-25 9:20 ` Paolo Bonzini
2022-02-21 17:23 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).