From: Jason Wang <jasowang@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: "Yan Vugenfirer" <yan@daynix.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP
Date: Fri, 2 Apr 2021 13:05:10 +0800 [thread overview]
Message-ID: <b05de350-dd4c-bd4b-ea95-dade90b0a44c@redhat.com> (raw)
In-Reply-To: <a7088e13-559b-560e-67e1-a2b8a3fed19e@redhat.com>
在 2021/3/26 下午5:18, Jason Wang 写道:
>>> ?
>> I assume that both src and dest started with vhost=on.
>>
>> As driver B supports both packed and split, you can switch from driver
>> A to driver B after migration
>> and driver B will work with split. Exactly as it does today.
>>
>> The key question is what is more important - vhost or features that
>> vhost does not support?
>> current code says: vhost is more important always
>> v1 patch says: features are more important always.
>> v2 patch says: vhost is more important at init time, features are more
>> important at migration time.
>> Because we are able to drop vhost but we can't drop features when we
>> have a running driver.
>> Do you agree?
>
>
> I think what came from cli is the most important. So if I understand
> correclty:
>
> - vhost=on means "turn on vhost when possible" it implies that
> fallback is allowed (we had already had fallback codes)
> - vhostforce=on means "turn on vhost unconditonally" it implies that
> we can't do fallback
>
> So my understanding is that:
>
> - "vhost=on, packed=on", we can fallback to userspace but must keep
> packed virtqueue works
> - "vhost=on,vhostforce=on,packed=on", we can't fallback and must keep
> both vhost and packed virtqueue work, if we can't we need to fail
>
> Thanks
Daniel and Michael, am I right here?
We need some inputs to move forward to fix the migration compatibility
issue.
Thanks
prev parent reply other threads:[~2021-04-02 5:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 12:24 [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP Yuri Benditovich
2021-03-22 12:24 ` [RFC PATCH v2 1/3] net: add ability to hide (disable) vhost_net Yuri Benditovich
2021-03-22 12:24 ` [RFC PATCH v2 2/3] virtio: introduce 'missing_features_migrated' device callback Yuri Benditovich
2021-03-22 12:24 ` [RFC PATCH v2 3/3] virtio-net: implement missing_features_migrated callback Yuri Benditovich
2021-03-25 6:59 ` [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP Jason Wang
2021-03-25 9:00 ` Yuri Benditovich
2021-03-26 7:51 ` Jason Wang
2021-03-26 9:09 ` Yuri Benditovich
2021-03-26 9:18 ` Jason Wang
2021-04-02 5:05 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b05de350-dd4c-bd4b-ea95-dade90b0a44c@redhat.com \
--to=jasowang@redhat.com \
--cc=berrange@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).