Re: [PATCH v10 4/9] hw/fsi: Introduce IBM's FSI master

[Ninad Palsule <ninad@linux.ibm.com>]

Hello Cedric,


>>
>> [ clg: - move FSICFAMState object under FSIMasterState
>>         - introduced fsi_master_init()
>>         - reworked fsi_master_realize()
>>         - dropped FSIBus definition ]
>
> Move the list down before my S-o-b.
Done.
>
>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> I think you can drop Joel's reviews, the code has changed a lot.
Removed Joel's review tag.
>
>> +static void fsi_master_reset(DeviceState *dev)
>> +{
>> +    FSIMasterState *s = FSI_MASTER(dev);
>> +    int i;
>> +
>> +    /* Initialize registers */
>> +    for (i = 0; i < FSI_MASTER_NR_REGS; i++) {
>> +        s->regs[i] = 0;
>> +    }
>
> memset(s->regs, 0, sizeof(s->regs));

Replaced for loop with memset.

Thanks for the review.

Regards,

Ninad