qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 3/3] nbd: disable signals and forking on Windows builds
Date: Wed, 2 Sep 2020 16:27:45 -0500	[thread overview]
Message-ID: <b0814964-51dc-2893-73fc-b6711d40692a@redhat.com> (raw)
In-Reply-To: <20200825103850.119911-4-berrange@redhat.com>

On 8/25/20 5:38 AM, Daniel P. Berrangé wrote:
> Disabling these parts are sufficient to get the qemu-nbd program
> compiling in a Windows build.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   meson.build | 7 ++-----
>   qemu-nbd.c  | 5 +++++
>   2 files changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Queuing through my NBD tree.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-09-02 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 10:38 [PATCH v2 0/3] nbd: build qemu-nbd on Windows Daniel P. Berrangé
2020-08-25 10:38 ` [PATCH v2 1/3] block: add missing socket_init() calls to tools Daniel P. Berrangé
2020-08-25 10:38 ` [PATCH v2 2/3] nbd: skip SIGTERM handler if NBD device support is not built Daniel P. Berrangé
2020-09-02 21:27   ` Eric Blake
2020-08-25 10:38 ` [PATCH v2 3/3] nbd: disable signals and forking on Windows builds Daniel P. Berrangé
2020-09-02 21:27   ` Eric Blake [this message]
2020-09-02 22:07   ` 罗勇刚(Yonggang Luo)
2020-09-02 23:29     ` Eric Blake
2020-09-03  7:06       ` 罗勇刚(Yonggang Luo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0814964-51dc-2893-73fc-b6711d40692a@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).