From: Hanna Reitz <hreitz@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, t.lamprecht@proxmox.com, d.csapak@proxmox.com
Subject: Re: [PATCH] vl: change PID file path resolve error to warning
Date: Thu, 27 Oct 2022 14:06:44 +0200 [thread overview]
Message-ID: <b081a2f4-5dbe-ec8e-b4de-b9ba0d427453@redhat.com> (raw)
In-Reply-To: <20221027101443.118049-1-f.ebner@proxmox.com>
On 27.10.22 12:14, Fiona Ebner wrote:
> Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") made it a
> critical error when the PID file path cannot be resolved. Before this
> commit, it was possible to invoke QEMU when the PID file was a file
> created with mkstemp that was already unlinked at the time of the
> invocation. There might be other similar scenarios.
>
> It should not be a critical error when the PID file unlink notifier
> can't be registered, because the path can't be resolved. Turn it into
> a warning instead.
>
> Fixes: 85c4bf8aa6 ("vl: Unlink absolute PID file path")
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
next prev parent reply other threads:[~2022-10-27 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:14 [PATCH] vl: change PID file path resolve error to warning Fiona Ebner
2022-10-27 12:06 ` Hanna Reitz [this message]
2022-10-27 12:17 ` Daniel P. Berrangé
2022-10-28 7:11 ` Fiona Ebner
2022-10-28 7:26 ` Thomas Lamprecht
2022-10-28 7:54 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b081a2f4-5dbe-ec8e-b4de-b9ba0d427453@redhat.com \
--to=hreitz@redhat.com \
--cc=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).