From: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
To: Alberto Garcia <berto@igalia.com>,
Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
eric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>
Cc: Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
jani kokkonen <jani.kokkonen@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling
Date: Fri, 1 Sep 2017 14:44:27 +0200 [thread overview]
Message-ID: <b0d876a3-da9b-83c9-3257-df88feb0f4a2@huawei.com> (raw)
In-Reply-To: <w51pobb509z.fsf@maestria.local.igalia.com>
On 8/31/2017 3:34 PM, Alberto Garcia wrote:
> On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote:
>> On 8/30/2017 5:10 PM, Alberto Garcia wrote:
>>> On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote:
>>>
>>>> Thanks for the steps, I did reproduce the issue easily. Looking into
>>>> the code, may be we also need to try the same with the block devices.
>>>
>>> I did some tests and it was working fine, so I'd suspect of the fsdev
>>> code first.
>>>
>> OK, thanks for the clarification. I will look into fsdev code.
>
> I just took a quick look at the code, the problem is almost certainly in
> fsdev_set_io_throttle(): that doesn't simply update the config, it also
> reinitializes the FsThrottle structure completely, creates new timers
> and new throttled_reqs queues. If there were pending requests there
> they're probably lost forever.
>
> Take a look at blk_set_io_limits() and see how it is done for block
> devices.
I fixed it. I am testing it. I was initializing the queues again.
But it just needs updation of throttle configuration.
-Pradeep
>
> Berto
>
next prev parent reply other threads:[~2017-09-01 12:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 14:23 [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling Pradeep Jagadeesh
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 1/6] throttle: factor out duplicate code Pradeep Jagadeesh
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 2/6] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 3/6] throttle: move out function to reuse the code Pradeep Jagadeesh
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 4/6] hmp: create a throttle initialization function for code reusability Pradeep Jagadeesh
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling Pradeep Jagadeesh
2017-08-30 9:38 ` Alberto Garcia
2017-09-04 12:22 ` Pradeep Jagadeesh
2017-09-04 13:05 ` Alberto Garcia
2017-08-29 14:23 ` [Qemu-devel] [PATCH v8 6/6] fsdev: QMP " Pradeep Jagadeesh
2017-08-29 14:36 ` [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling Alberto Garcia
2017-08-29 14:39 ` Pradeep Jagadeesh
2017-08-30 12:07 ` Alberto Garcia
2017-08-30 12:10 ` Pradeep Jagadeesh
2017-08-30 14:54 ` Alberto Garcia
2017-08-30 15:07 ` Pradeep Jagadeesh
2017-08-30 15:10 ` Alberto Garcia
2017-08-30 15:12 ` Pradeep Jagadeesh
2017-08-31 13:34 ` Alberto Garcia
2017-08-31 13:39 ` Pradeep Jagadeesh
2017-09-01 12:44 ` Pradeep Jagadeesh [this message]
2017-08-30 14:28 ` Greg Kurz
-- strict thread matches above, loose matches on Subject: below --
2017-08-07 12:37 Pradeep Jagadeesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0d876a3-da9b-83c9-3257-df88feb0f4a2@huawei.com \
--to=pradeep.jagadeesh@huawei.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=jani.kokkonen@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).