From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE104C38A2A for ; Fri, 8 May 2020 06:35:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0930207DD for ; Fri, 8 May 2020 06:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aFRbYIaV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0930207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWwbS-0001OO-Up for qemu-devel@archiver.kernel.org; Fri, 08 May 2020 02:35:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWwaV-00008A-SC for qemu-devel@nongnu.org; Fri, 08 May 2020 02:34:25 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:30046 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWwaU-000833-BC for qemu-devel@nongnu.org; Fri, 08 May 2020 02:34:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588919661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=znyt2gmWunAyhQ/YOcaWlSQ+KmrrcSiMzOx8z/LLGB0=; b=aFRbYIaVKG7ZNF9ghS2qwUkIiI+BE8xCTEETSIF9ZMAHVr5A3uyZfU06HOOs/8hPM2bT9Z jnvdzflO1SqvBwmyc5F8W0x9AwwSeg5rralVjfBvrF6ERUxpSgIZsuVpo/L/he5aKOuFPU EgmYiVxp9kOlteb0uUGO0V8WcfuurtE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-xFhURgpCMlepBpVp4bJ-OQ-1; Fri, 08 May 2020 02:34:20 -0400 X-MC-Unique: xFhURgpCMlepBpVp4bJ-OQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE84A1005510; Fri, 8 May 2020 06:34:18 +0000 (UTC) Received: from [10.36.114.214] (ovpn-114-214.ams2.redhat.com [10.36.114.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D652605CE; Fri, 8 May 2020 06:34:11 +0000 (UTC) Subject: Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process To: Peter Xu References: <20200507143201.31080-1-eric.auger@redhat.com> <20200507143201.31080-4-eric.auger@redhat.com> <20200507194736.GM228260@xz-x1> From: Auger Eric Message-ID: Date: Fri, 8 May 2020 08:34:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200507194736.GM228260@xz-x1> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eric.auger@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/08 02:23:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, qemu-arm@nongnu.org, jean-philippe@linaro.org, bbhushan2@marvell.com, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 5/7/20 9:47 PM, Peter Xu wrote: > Hi, Eric, > > On Thu, May 07, 2020 at 04:31:59PM +0200, Eric Auger wrote: >> @@ -640,6 +641,24 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, >> goto unlock; >> } >> >> + for (i = 0; i < s->nb_reserved_regions; i++) { >> + if (interval.low >= s->reserved_regions[i].low && >> + interval.low <= s->reserved_regions[i].high) { > > Should this be s/low/high/? I meant addr >= s->reserved_regions[i].low && addr <= s->reserved_regions[i].high We only compare a single iova against reserved range boundaries and boundaries are inclusive > > For this case (high==low+1) I guess maybe it's also easier to use "addr >= low > && addr < high". Yes using addr directly is definitively more readable ;-) Thanks Eric > > Thanks, > >> + switch (s->reserved_regions[i].type) { >> + case VIRTIO_IOMMU_RESV_MEM_T_MSI: >> + entry.perm = flag; >> + break; >> + case VIRTIO_IOMMU_RESV_MEM_T_RESERVED: >> + default: >> + virtio_iommu_report_fault(s, VIRTIO_IOMMU_FAULT_R_MAPPING, >> + VIRTIO_IOMMU_FAULT_F_ADDRESS, >> + sid, addr); >> + break; >> + } >> + goto unlock; >> + } >> + } >> + >> if (!ep->domain) { >> if (!bypass_allowed) { >> error_report_once("%s %02x:%02x.%01x not attached to any domain", >> -- >> 2.20.1 >> >