From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D1BC3DA6E for ; Fri, 5 Jan 2024 15:05:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLlkp-0001oA-UW; Fri, 05 Jan 2024 10:05:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLlkl-0001ns-Ro for qemu-devel@nongnu.org; Fri, 05 Jan 2024 10:04:57 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLlkh-0000jr-Sw for qemu-devel@nongnu.org; Fri, 05 Jan 2024 10:04:54 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40e3b3fb6f6so1409825e9.2 for ; Fri, 05 Jan 2024 07:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704467088; x=1705071888; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G+b+UhhWUTTADKOHH3dFD6R5H8/Kn+xlE1Fw01Bx6hI=; b=opWrk3RH0wKJjf7hH+d8k0vIGi5OWXbJglJUpQIE898DICijgXvu2on/wfwx8IlMms BmFLBjvCcrAli5X6T3WidhRbsoBG/gZZXL5p0v6ivfwDmeaPN0DnRkv9gWnfyTB7h5Db ohW3OpyEK4gkDPqjyG0X8+Oz2qsB9Vp0X2Q2hlviqAJBcJxLJXVu4bJK4nYgobMePGhK rPNEG9zFwr4aHV84IY8Ek2ROHb7q8bsxt++YtdeVagR2jy/ChG5N/rrqWIw/5TkOXmE3 KYHN0bkW3k7iVzRHa73a3PHR/o11hkL6d9F1ciHz4ZtrQUs7nuliVt1TapYESqr3WTxb yWew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704467088; x=1705071888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G+b+UhhWUTTADKOHH3dFD6R5H8/Kn+xlE1Fw01Bx6hI=; b=w2vcaTyuce60Gj8jGBtsxbzKiSLRhVeh8qnS0ZM7mCCHop0ZOmyRUzrYvCRmrmxMRY iBZyrny0rK2tdlvnxChdc1Sq/QlT0xS9ITUFcVLUCRY7/JTfXdlf4Z8KMV2P9Q3+xgzi jSB99LPLaERn3h9UpKJ+wv+2LVbo2AMU6cK5wqb7yA2P4AeHv+B1pleHrjaqjG7CQqpA YXc7mj05W80aGWWoXobd+Stn4Or8Squ7luB/KvEZBu/5zSEO1+0GUaeUI2COUVZlSnrM laKiJWq8gdcGxnMlH4nW/TQJZQNmOrapbBQtdKm5iYDIMn9ZzOWc1NXaeWGZrPMCSk6w tCKw== X-Gm-Message-State: AOJu0YwnqPlU7AsnMXfGvRePN/awj7Kdq4km1mBwJG/u2hqZtoUo4jFU /nzsCOgfWXtgTzJ844Mcb+pr1vrmF1JhQg== X-Google-Smtp-Source: AGHT+IFuf8gNdzgdNKirXf+yYITyi6YI+NIG7GbRz2i8XBg7VLyhtIhXDEslgyko881TI9AmxXa39A== X-Received: by 2002:a7b:cb97:0:b0:40d:8128:bc9e with SMTP id m23-20020a7bcb97000000b0040d8128bc9emr1441109wmi.163.1704467088670; Fri, 05 Jan 2024 07:04:48 -0800 (PST) Received: from [192.168.69.100] (juv34-h02-176-184-26-1.dsl.sta.abo.bbox.fr. [176.184.26.1]) by smtp.gmail.com with ESMTPSA id iv14-20020a05600c548e00b0040e3733a32bsm1822953wmb.41.2024.01.05.07.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 07:04:48 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 16:04:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls Content-Language: en-US To: Manos Pitsidianakis , qemu-devel@nongnu.org Cc: David Hildenbrand , Peter Maydell , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Mark Cave-Ayland , Markus Armbruster , Paolo Bonzini , Igor Mammedov , qemu-ppc@nongnu.org, =?UTF-8?Q?C_=C3=A9_dric_Le_Goater?= , Peter Xu References: <20231120213301.24349-1-philmd@linaro.org> <20231120213301.24349-20-philmd@linaro.org> <4ild1.0v3gsvmc0lqe@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <4ild1.0v3gsvmc0lqe@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 22/11/23 08:38, Manos Pitsidianakis wrote: > On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé > wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- > > Commit message missing but indeed there's not much to say I amended: Since qemu_prealloc_mem() returns whether or not an error occured, we don't need to check the @errp pointer. Remove local_err uses when we can return directly. > Reviewed-by: Manos Pitsidianakis Thanks!