qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark Kanda <mark.kanda@oracle.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH v3 1/3] qmp: Support for querying stats
Date: Thu, 3 Feb 2022 12:12:57 -0600	[thread overview]
Message-ID: <b111f7a7-ab0c-8944-ec3a-9461eb0e4fb3@oracle.com> (raw)
In-Reply-To: <YfkiyiK+jfrdbVcY@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Thanks Daniel,

On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
>> +#
>> +# Since: 7.0
>> +##
>> +{ 'enum' : 'StatType',
>> +  'data' : [ 'cumulative', 'instant', 'peak',
>> +             'linear-hist', 'log-hist', 'unknown' ] }
> IMHO 'unknown' shouldn't exist at all.
>

I added the 'unknown' member here (and in other enums) to handle situations 
where QEMU is behind KVM in terms of enumerating the various stat types, units, 
etc. I feel this will be a semi-common scenario (old QEMU on a new kernel) and 
with 'unknown', QEMU can at least display the raw data.

That said, I happy skip 'unknown' entries if you think that's better.

Thanks/regards,
-Mark

[-- Attachment #2: Type: text/html, Size: 1169 bytes --]

  reply	other threads:[~2022-02-03 18:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 19:43 [PATCH v3 0/3] Support fd-based KVM stats Mark Kanda
2022-01-31 19:43 ` [PATCH v3 1/3] qmp: Support for querying stats Mark Kanda
2022-02-01 10:51   ` Paolo Bonzini
2022-02-01 11:01     ` Daniel P. Berrangé
2022-02-11 13:51       ` Markus Armbruster
2022-02-01 12:08   ` Daniel P. Berrangé
2022-02-03 18:12     ` Mark Kanda [this message]
2022-02-03 18:30       ` Daniel P. Berrangé
2022-02-03 18:37         ` Mark Kanda
2022-02-03 18:39       ` Paolo Bonzini
2022-02-03 18:38     ` Paolo Bonzini
2022-02-03 18:53       ` Daniel P. Berrangé
2022-02-03 18:52     ` Mark Kanda
2022-01-31 19:43 ` [PATCH v3 2/3] hmp: " Mark Kanda
2022-01-31 19:43 ` [PATCH v3 3/3] kvm: Support for querying fd-based stats Mark Kanda
2022-02-01 10:08   ` Daniel P. Berrangé
2022-02-01 10:51   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b111f7a7-ab0c-8944-ec3a-9461eb0e4fb3@oracle.com \
    --to=mark.kanda@oracle.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).