From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F55C433B4 for ; Sat, 1 May 2021 22:25:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D89C6147E for ; Sat, 1 May 2021 22:25:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D89C6147E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcy2v-00087O-PM for qemu-devel@archiver.kernel.org; Sat, 01 May 2021 18:25:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcy24-0007ZU-Nb for qemu-devel@nongnu.org; Sat, 01 May 2021 18:24:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcy22-0000Oe-7H for qemu-devel@nongnu.org; Sat, 01 May 2021 18:24:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619907853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9MuaLmZ9c8TYz83S97fJohihh8jWN2HtbczG9ZHrqjk=; b=Oa0WVuwi72Ads+CYs4zWXTu6NgA8uztMl6pn0+qjhUFfPM07wWSYKsmlh80VIZvphtmYp1 QYrokWkKgol3PIyw8tlvndnhBv3tu07cKDUrTf1n/3NVLs3aabkWizIFssUSEc16pqCdXR 5u2cy8nhnBkP0O2T7IpYX/HDFG6uQXE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-dUGyeQ7kNGq_G4saajlUsw-1; Sat, 01 May 2021 18:24:11 -0400 X-MC-Unique: dUGyeQ7kNGq_G4saajlUsw-1 Received: by mail-wr1-f69.google.com with SMTP id r12-20020adfc10c0000b029010d83323601so1251598wre.22 for ; Sat, 01 May 2021 15:24:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9MuaLmZ9c8TYz83S97fJohihh8jWN2HtbczG9ZHrqjk=; b=oQdOHnJFewJ5HSnC1VivcT2QgjZhsZXIlpp3QQ4+oaI65WtE6JRRA+tfTcVQjsJvVx TQGaK++w/nhArtaqStc+LYr3FQSIfUBpgGsqalqSAJXVp5iJcXbQfA8rwyqnpBBCPeHI UiTgo1E17MFonfuULJG1PZg1BTZNWX6sQ+Y7dRlSoU9vZg7eq5FP8daiVaW/ogleyBlg SpwwUcuvNA4twwP6kmhk0vjuQTl+I1NAkk6M2Zq6o85oZVFESoqTiiJ3qGyaTYJf/tZM yMpLA723dyGQWHG6EF1jDBV0seL1pe8BvNsi3tIsrt2TvNiPdTXeKgWNK6wLKvmWMSCc kuUA== X-Gm-Message-State: AOAM533M2862ksS9KuUJP7kDrJy4S2/5eBhNRWfBjOTFVQdz6/QpM6fp NcR1s5Xi2O3wsH3YPZGDYCiN+7QreWhzSFRMA0QF3Q+7NGde4MuzGpX0Vv4TVEdPW03fsTOQqjz HjLxHiGQ5tviZq4I= X-Received: by 2002:adf:ed4b:: with SMTP id u11mr16012595wro.293.1619907850526; Sat, 01 May 2021 15:24:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBgzwQH6BGEtBRcAGRbRMWzMX34TEakgD8Ib2ErTFvdp2WP5Fv9mSgKagxGkaLDoWjFESjJQ== X-Received: by 2002:adf:ed4b:: with SMTP id u11mr16012567wro.293.1619907850340; Sat, 01 May 2021 15:24:10 -0700 (PDT) Received: from [192.168.1.19] (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id l25sm6728390wmi.17.2021.05.01.15.24.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 May 2021 15:24:09 -0700 (PDT) Subject: Re: [PATCH v4 02/12] accel: Introduce 'query-accels' QMP command To: Eric Blake , qemu-devel@nongnu.org References: <20210415163304.4120052-1-philmd@redhat.com> <20210415163304.4120052-3-philmd@redhat.com> <2f6ef548-cff4-273f-5680-f79bda85e197@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Sun, 2 May 2021 00:24:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2f6ef548-cff4-273f-5680-f79bda85e197@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Andrew Jones , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , Markus Armbruster , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, Claudio Fontana , Paolo Bonzini , Thomas Huth , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/30/21 9:03 PM, Eric Blake wrote: > On 4/15/21 11:32 AM, Philippe Mathieu-Daudé wrote: >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - AcceleratorInfo is a QAPI structure providing accelerator >> specific information. Currently the common structure base >> provides the name of the accelerator, while the specific >> part is empty, but each accelerator can expand it. >> >> - 'query-accels' QMP command returns a list of @AcceleratorInfo >> >> For example on a KVM-only build we get: >> >> { "execute": "query-accels" } >> { >> "return": [ >> { >> "name": "qtest" >> }, >> { >> "name": "kvm" >> } >> ] >> } >> >> Note that we can't make the enum values or union branches conditional >> because of target-specific poisoning of accelerator definitions. >> >> Reviewed-by: Eric Blake >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Since v3: Simplify over-engineered AcceleratorInfo (Markus, kept Eric R-b) >> Since v2: @since 6.0 -> 6.1, added note (Eric) >> Since v1: 'type' -> 'name' in comments > >> +++ b/qapi/machine.json >> @@ -1274,3 +1274,50 @@ >> ## >> { 'event': 'MEM_UNPLUG_ERROR', >> 'data': { 'device': 'str', 'msg': 'str' } } >> + >> +## >> +# @Accelerator: >> +# >> +# An enumeration of accelerator names. >> +# >> +# Since: 6.1 >> +## >> +{ 'enum': 'Accelerator', >> + 'data': [ 'qtest', 'tcg', 'kvm', 'hax', 'hvf', 'whpx', 'xen' ] } > > There's no requirement for enums to be in any order, although if the > list is likely to get larger over time, lexicographic order makes it > easier to know where to insert new entries. Up to you whether it is > worth sorting, and your decision does not invalidate my R-b. OK will do, thanks!