Re: Patch: Sparc prevent segfault when dumping uninitialzed cpu state

[Richard Henderson <richard.henderson@linaro.org>]

On 2/2/25 20:03, Henk van der Laak (LaakSoft) wrote:
> On 03/02/2025 04:45, Richard Henderson wrote:
>> On 2/2/25 19:14, Henk van der Laak (LaakSoft) via wrote:
>>> Hi all, my first contribution. I checked code style, patch submission rules and did a 
>>> manual test (details on request)
>>>
>>> Synopsis:
>>> It's a corner case, where a segfault occurs when logging Sparc CPU state in a partially 
>>> initialized state.
>>>
>>> No related bug report.
>>>
>>> Open to harsh criticism ;-)
>>
>> How do we arrive here with a partially initialized state?
>>
>>
>> r~
>>
> |> qemu-sparc64 -d cpu_reset -D ./cpu_reset.log demo.sparc64.asm.elf ||The logging category 'cpu_reset' causes logging of all resets including the very first 
> one, where initialization by Qemu has not been completed. Like I said, it's a corner case. 
> Henk van der Laak |
> 

Gotcha.  I'd forgotten that -d cpu_reset exists.

Of course the logging happens before the superclass reset even starts, much less finishes.
I guess the logging should happen in the exit phase, not the hold phase.


r~