qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Kyle Evans <kevans@FreeBSD.org>, qemu-devel@nongnu.org
Cc: Warner Losh <imp@bsdimp.com>,
	richard.henderson@linaro.org, alex.bennee@linaro.org
Subject: Re: [PATCH] bsd-user: add option to enable plugins
Date: Mon, 28 Apr 2025 16:03:11 -0700	[thread overview]
Message-ID: <b13089fa-75bf-4eab-a0a4-1061c24943cd@linaro.org> (raw)
In-Reply-To: <a7cc7e54-b84d-44e1-8c75-df39b44dd28f@FreeBSD.org>

On 4/28/25 3:57 PM, Kyle Evans wrote:
>> Gentle ping on this series.
>> As we didn't have any feedback from BSD side, could we consider to
>> enable this upstream?
>>
> 
> Sorry- I have no strong opinion on plugins, but the diff looks
> incredibly reasonable and non-invasive.  I'm not really seeing any
> reason we'd object, but I don't personally feel qualified to review this
> (except as a basic human C linter- I can't imagine the added calls
> breaking anything we rely on).
> 

Thanks for your answer Kyle.
The current issue is that check-tcg is not tested on BSD hosts for now, 
so enabling plugins support is not tested.

That said, it works on the few cases I tried, and there is nothing 
specific to BSD in tcg or plugins code, so it would be reasonable to 
enable this I think.

> Thanks,
> 
> Kyle Evans



  reply	other threads:[~2025-04-28 23:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 23:42 [PATCH] bsd-user: add option to enable plugins Pierrick Bouvier
2025-03-31 23:50 ` Pierrick Bouvier
2025-04-01  6:15 ` Philippe Mathieu-Daudé
2025-04-01 14:33   ` Pierrick Bouvier
2025-04-01 14:44     ` Philippe Mathieu-Daudé
2025-04-01 14:59       ` Pierrick Bouvier
2025-04-01 18:50         ` Philippe Mathieu-Daudé
2025-04-28 19:36 ` Pierrick Bouvier
2025-04-28 22:57   ` Kyle Evans
2025-04-28 23:03     ` Pierrick Bouvier [this message]
2025-05-05 18:38     ` Pierrick Bouvier
2025-05-06  0:25       ` Warner Losh
2025-05-06  8:24         ` Philippe Mathieu-Daudé
2025-05-08 12:18 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b13089fa-75bf-4eab-a0a4-1061c24943cd@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=imp@bsdimp.com \
    --cc=kevans@FreeBSD.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).