From: Max Reitz <mreitz@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v8 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests
Date: Thu, 15 Jul 2021 15:32:00 +0200 [thread overview]
Message-ID: <b13ffa83-1f47-496f-be82-b671ed1668c2@redhat.com> (raw)
In-Reply-To: <20210705065711.127119-17-eesposit@redhat.com>
On 05.07.21 08:57, Emanuele Giuseppe Esposito wrote:
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> docs/devel/testing.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 719accdb1e..e5311cb167 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -249,6 +249,10 @@ a failing test:
> * ``-d`` (debug) just increases the logging verbosity, showing
> for example the QMP commands and answers.
>
> +* ``-p`` (print) redirect QEMU’s stdout and stderr to the test output,
Sorry, my bad: s/redirect/redirects/
With that fixed:
Reviewed-by: Max Reitz <mreitz@redhat.com>
Max
> + instead of saving it into a log file in
> + ``$TEST_DIR/qemu-machine-<random_string>``.
> +
> Test case groups
> ----------------
>
next prev parent reply other threads:[~2021-07-15 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 6:56 [PATCH v8 00/16] qemu_iotests: improve debugging options Emanuele Giuseppe Esposito
2021-07-05 6:56 ` [PATCH v8 01/16] python: qemu: add timer parameter for qmp.accept socket Emanuele Giuseppe Esposito
2021-07-05 6:56 ` [PATCH v8 02/16] python: Reduce strictness of pylint's duplicate-code check Emanuele Giuseppe Esposito
2021-07-05 6:56 ` [PATCH v8 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine Emanuele Giuseppe Esposito
2021-07-05 6:56 ` [PATCH v8 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 05/16] qemu-iotests: add option to attach gdbserver Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 06/16] qemu-iotests: delay QMP socket timers Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too Emanuele Giuseppe Esposito
2021-07-15 12:54 ` Max Reitz
2021-08-09 8:27 ` Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests Emanuele Giuseppe Esposito
2021-07-15 13:01 ` Max Reitz
2021-07-05 6:57 ` [PATCH v8 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 11/16] qemu-iotests: extend QMP socket timeout when using valgrind Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 12/16] qemu-iotests: allow valgrind to read/delete the generated log file Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 15/16] qemu-iotests: add option to show qemu binary logs on stdout Emanuele Giuseppe Esposito
2021-07-05 6:57 ` [PATCH v8 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-07-15 13:32 ` Max Reitz [this message]
2021-07-15 13:33 ` [PATCH v8 00/16] qemu_iotests: improve debugging options Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13ffa83-1f47-496f-be82-b671ed1668c2@redhat.com \
--to=mreitz@redhat.com \
--cc=crosa@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).