Re: [PATCH v2 29/42] audio: remove AUDIO_HOST_ENDIANNESS

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 22/10/25 08:56, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   audio/audio.h      | 6 ------
>   audio/audio.c      | 6 +++---
>   audio/spiceaudio.c | 4 ++--
>   hw/audio/adlib.c   | 2 +-
>   hw/audio/asc.c     | 2 +-
>   hw/audio/cs4231a.c | 2 +-
>   hw/audio/gus.c     | 2 +-
>   7 files changed, 9 insertions(+), 15 deletions(-)
> 
> diff --git a/audio/audio.h b/audio/audio.h
> index 3be0c4f24f..0af911fd9a 100644
> --- a/audio/audio.h
> +++ b/audio/audio.h
> @@ -31,12 +31,6 @@
>   
>   typedef void (*audio_callback_fn) (void *opaque, int avail);
>   
> -#if HOST_BIG_ENDIAN
> -#define AUDIO_HOST_ENDIANNESS 1
> -#else
> -#define AUDIO_HOST_ENDIANNESS 0
> -#endif
> -
>   typedef struct audsettings {
>       int freq;
>       int nchannels;
> diff --git a/audio/audio.c b/audio/audio.c
> index 0f3093ad59..284ea13289 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -274,7 +274,7 @@ static int audio_pcm_info_eq (struct audio_pcm_info *info, struct audsettings *a
>           && info->is_signed == is_signed
>           && info->is_float == is_float
>           && info->bits == bits
> -        && info->swap_endianness == (as->endianness != AUDIO_HOST_ENDIANNESS);
> +        && info->swap_endianness == (as->endianness != HOST_BIG_ENDIAN);
>   }
>   
>   void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
> @@ -320,7 +320,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
>       info->nchannels = as->nchannels;
>       info->bytes_per_frame = as->nchannels * mul;
>       info->bytes_per_second = info->freq * info->bytes_per_frame;
> -    info->swap_endianness = (as->endianness != AUDIO_HOST_ENDIANNESS);
> +    info->swap_endianness = (as->endianness != HOST_BIG_ENDIAN);
>   }
>   
>   void audio_pcm_info_clear_buf (struct audio_pcm_info *info, void *buf, int len)
> @@ -2179,7 +2179,7 @@ audsettings audiodev_to_audsettings(AudiodevPerDirectionOptions *pdo)
>           .freq = pdo->frequency,
>           .nchannels = pdo->channels,
>           .fmt = pdo->format,
> -        .endianness = AUDIO_HOST_ENDIANNESS,
> +        .endianness = HOST_BIG_ENDIAN,
>       };
>   }

Nice. Even better would be to use QAPI EndianMode.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>