From: Paolo Bonzini <pbonzini@redhat.com>
To: "Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] memory: Make 'info mtree' not display disabled regions by default
Date: Fri, 29 May 2020 16:46:50 +0200 [thread overview]
Message-ID: <b140ccb6-a1e6-6b06-27ff-1783ac37d91e@redhat.com> (raw)
In-Reply-To: <20200529143436.GA1374520@xz-x1>
On 29/05/20 16:34, Peter Xu wrote:
> On Fri, May 29, 2020 at 02:53:25PM +0200, Philippe Mathieu-Daudé wrote:
>> @@ -2920,35 +2916,46 @@ static void mtree_print_mr(const MemoryRegion *mr, unsigned int level,
>> ml->mr = mr->alias;
>> QTAILQ_INSERT_TAIL(alias_print_queue, ml, mrqueue);
>> }
>> - qemu_printf(TARGET_FMT_plx "-" TARGET_FMT_plx
>> - " (prio %d, %s%s): alias %s @%s " TARGET_FMT_plx
>> - "-" TARGET_FMT_plx "%s",
>> - cur_start, cur_end,
>> - mr->priority,
>> - mr->nonvolatile ? "nv-" : "",
>> - memory_region_type((MemoryRegion *)mr),
>> - memory_region_name(mr),
>> - memory_region_name(mr->alias),
>> - mr->alias_offset,
>> - mr->alias_offset + MR_SIZE(mr->size),
>> - mr->enabled ? "" : " [disabled]");
>> - if (owner) {
>> - mtree_print_mr_owner(mr);
>> + if (mr->enabled || display_disabled) {
>> + for (i = 0; i < level; i++) {
>> + qemu_printf(MTREE_INDENT);
>> + }
>> + qemu_printf(TARGET_FMT_plx "-" TARGET_FMT_plx
>> + " (prio %d, %s%s): alias %s @%s " TARGET_FMT_plx
>> + "-" TARGET_FMT_plx "%s",
>> + cur_start, cur_end,
>> + mr->priority,
>> + mr->nonvolatile ? "nv-" : "",
>> + memory_region_type((MemoryRegion *)mr),
>> + memory_region_name(mr),
>> + memory_region_name(mr->alias),
>> + mr->alias_offset,
>> + mr->alias_offset + MR_SIZE(mr->size),
>> + mr->enabled ? "" : " [disabled]");
>> + if (owner) {
>> + mtree_print_mr_owner(mr);
>> + }
>
> It'll not only change the default output for "info mtree", but also "-o" too
> because disabled regions won't be dumped any more. Not sure whether it's
> expected - just raise this question up, because I mostly only use "-f"..
I think it's the right behavior. Queued, thanks.
Paolo
prev parent reply other threads:[~2020-05-29 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 12:53 [PATCH] memory: Make 'info mtree' not display disabled regions by default Philippe Mathieu-Daudé
2020-05-29 14:34 ` Peter Xu
2020-05-29 14:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b140ccb6-a1e6-6b06-27ff-1783ac37d91e@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).