qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH v2 6/7] gtk: Fix mouse warping with gtk3
Date: Thu, 13 Mar 2014 15:30:23 -0400	[thread overview]
Message-ID: <b14f919aa5b19e40a8c16bb9915a19a730a28de3.1394738819.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1394738819.git.crobinso@redhat.com>
In-Reply-To: <cover.1394738819.git.crobinso@redhat.com>

We were using the wrong coordinates, this fixes things to match the
original gtk2 implementation.

You can see this error in action by using -vga qxl, however even after this
patch the mouse warps in small increments up and to the left, -7x and -3y
pixels at a time, until the pointer is warped off the widget. I think it's
a qxl bug, but the next patch covers it up.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index f42952e..8482791 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -346,7 +346,7 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
                                x, y, &x_root, &y_root);
     gdk_device_warp(gdk_device_manager_get_client_pointer(mgr),
                     gtk_widget_get_screen(s->drawing_area),
-                    x, y);
+                    x_root, y_root);
 }
 #else
 static void gd_mouse_set(DisplayChangeListener *dcl,
-- 
1.8.5.3

  parent reply	other threads:[~2014-03-13 19:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 19:30 [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes Cole Robinson
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 1/7] configure: Document --with-gtkabi Cole Robinson
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 2/7] gtk: Don't use deprecated gtk_image_menu_item_new_with_mnemonic Cole Robinson
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 3/7] gtk: Don't use deprecated vte_terminal_get_adjustment Cole Robinson
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 4/7] gtk: Remove use of deprecated stock items Cole Robinson
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 5/7] gtk: Use ctrl+alt+q for quit accelerator Cole Robinson
2014-03-13 19:30 ` Cole Robinson [this message]
2014-03-13 19:30 ` [Qemu-devel] [PATCH v2 7/7] gtk: Don't warp absolute pointer Cole Robinson
2014-03-14  9:48 ` [Qemu-devel] [PATCH v2 0/7] gtk: A few bug fixes Gerd Hoffmann
2014-03-14 12:03   ` Cole Robinson
2014-03-14 12:09     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b14f919aa5b19e40a8c16bb9915a19a730a28de3.1394738819.git.crobinso@redhat.com \
    --to=crobinso@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).