From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz7rz-0004hO-UP for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:58:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz7rz-0007W9-AR for qemu-devel@nongnu.org; Tue, 25 Oct 2016 15:58:48 -0400 References: <1477400641-7750-1-git-send-email-ashijeetacharya@gmail.com> <1477400641-7750-6-git-send-email-ashijeetacharya@gmail.com> From: Eric Blake Message-ID: Date: Tue, 25 Oct 2016 14:58:40 -0500 MIME-Version: 1.0 In-Reply-To: <1477400641-7750-6-git-send-email-ashijeetacharya@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ubjp96akCA69WuRMlxoGQ9x7WLnWRIHau" Subject: Re: [Qemu-devel] [PATCH v4 5/5] qapi: allow blockdev-add for ssh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya , kwolf@redhat.com Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ubjp96akCA69WuRMlxoGQ9x7WLnWRIHau From: Eric Blake To: Ashijeet Acharya , kwolf@redhat.com Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v4 5/5] qapi: allow blockdev-add for ssh References: <1477400641-7750-1-git-send-email-ashijeetacharya@gmail.com> <1477400641-7750-6-git-send-email-ashijeetacharya@gmail.com> In-Reply-To: <1477400641-7750-6-git-send-email-ashijeetacharya@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/25/2016 08:04 AM, Ashijeet Acharya wrote: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. >=20 > Signed-off-by: Ashijeet Acharya > Reviewed-by: Kevin Wolf > --- > qapi/block-core.json | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) Sorry for not noticing this when I finally replied to v4; > +## > +# @BlockdevOptionsSsh > +# > +# @server: host address > +# > +# @path: path to the image on the host > +# > +# @user: #optional user as which to connect, defaults t= o current > +# local user name > +# > +# @host_key_check #optional defines how and what to check the ho= st > +# key against, defaults to "yes" I still have reservations about this parameter. I think we have time to fix it as followups during soft freeze if Kevin would rather get your initial patches in now, if that's what it takes to meet soft freeze deadlines, but I do not want to bake it into the actual 2.8 release without addressing those concerns. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ubjp96akCA69WuRMlxoGQ9x7WLnWRIHau Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYD7lwAAoJEKeha0olJ0NqezMIAIYEW/sfwiEYGuP3S4drA/Id hNCS48lyXQTsWFVCa1aLwufcpPPjpqyHajrMTupTDN3zeZnlycoOU70ohPpE5KsO vbhbycw5PkSo1vJxW/E5DcMUdsbcidUOly/CBm/zsFnuYrdh4xk21w7ItNXM3KlA Nm7rgBYkLVUL0QlT2txv/oL/q3nZeBXViOjNw9aws6ZdkaFdmv63xpbGHFfbpZQ7 GA5j2XvA34bwAdOSZDWi3riY8DPdtrz3LlSByH1RHCaFCiW0bt51PY4VJa6IJVao hpyO4W0kME9sf9+7gSxu6ZttCNcPPsXFXHmfMJtRGNnpFlo0QSpb8gy0pRCnd8o= =pyKC -----END PGP SIGNATURE----- --Ubjp96akCA69WuRMlxoGQ9x7WLnWRIHau--