From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58448C282EC for ; Mon, 17 Mar 2025 07:33:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tu4xs-00034X-N4; Mon, 17 Mar 2025 03:32:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tu4xg-00031j-UX for qemu-devel@nongnu.org; Mon, 17 Mar 2025 03:32:40 -0400 Received: from mgamail.intel.com ([198.175.65.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tu4xc-0005sJ-Nz for qemu-devel@nongnu.org; Mon, 17 Mar 2025 03:32:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742196753; x=1773732753; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Wehjnmov28yZBzPdyResB+2tTv2KlSwhkyDEwLWosLQ=; b=VwBeEFJR0r3+sCkmPBChDqu/nOrJNCfn5+VdDou4J2DRB+1SDnsdU2Pg dXy+F7pfvm7+RjBdIWQoApzrSCxfSQ6zseNgzElC/622Iy3cgzfhVIIAj HpBULKfrlKWEluJoKd54sBzmHxWfKD7GmjLA7rcvgNYroLulf9W0YBVOo fZAPbkkPzeql8UMjfi5T3BwdrNgNJx8LO5BDSd6rTywM7gguaejJGSalx 01e+dnDzqoFAU8jpDYJgK/CAVajPqPSNrnICNRyvKYgQhkO7Hc0Cu01pV XxDcNm1i5ZTRdaQQMr/L4L2luPT3cb25HwKCXKEUVWfKD5fPDgRLlxP3Y Q==; X-CSE-ConnectionGUID: Rsgff/nGTaKTBNVe1SM3QQ== X-CSE-MsgGUID: KOZ383r7TJSj7w8h9f6DkQ== X-IronPort-AV: E=McAfee;i="6700,10204,11375"; a="54656843" X-IronPort-AV: E=Sophos;i="6.14,253,1736841600"; d="scan'208";a="54656843" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 00:32:29 -0700 X-CSE-ConnectionGUID: D+1TgPnWTTeZELoE6wBxDg== X-CSE-MsgGUID: NIudDcuhRomqSdmqJXTkrw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,253,1736841600"; d="scan'208";a="126056121" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 00:32:29 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 17 Mar 2025 00:32:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Mon, 17 Mar 2025 00:32:28 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 17 Mar 2025 00:32:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yWgIavBOPwGE7rTUGZZO+TvGiTjK9VPKEr3BZ4cSo72L5IbOaIv2VJ+2Fdje+Qf1porM8e6RNAIgw0QMoS8Mc9NaVOdg47o93d5oeP0zd1xe4MLaz1f1sepyii+9wYo/C+e409wK2YYYx7UJwNY+xwxaWNOIji94MbfvwFf4H7oUGp8YnD1KHv7n55D0wYLR6dKXzlI6+72Ev+r/bZ1GM1JI2ob+08W198okOz0ly6JBY7JBZ+FEkHbKlvUfkdF98kVweDrdezbjPGYsz5By1DFbizjPFsAd69711je3gqO7ccNUJ/AD45dDVa8U2hITYPu8fKZ+w4H3ag5dvWMApA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HjXYdj0LwG/HkSrY/1s5OVOPPNVVaE14rA2i1UpAsH8=; b=LKWumabuC+ZLZQ5g8zPnl3gpjyMkKzlhsSY+u+cXfJY/r0d5FdaA101TBZrdTHhyuco0sdBKBoKC/kDZcC8xZX6p0iMuDIPVBXGefo54lrUOzDugq2q3D/2PfiJGXD1HHmG8fEF9ynU8Z2GsNRdXk884pYKCCNzmxQgwgo9uPItKkBLbXKal6lG921aVjafQuE5zvUyQ+s8AJepB7RiRxbujZehk9KB5mnqD/q7OuhqNvkwRnbNyZdn8RYtS2zQhityVv5TUz8IkNQU1lUaeAPemjgwgustluGHUiJWKnUaD/on+YwsFQ07ZfVUmOFRY3/PIZJJRdZ8SEtG3XSFJtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM3PR11MB8735.namprd11.prod.outlook.com (2603:10b6:0:4b::20) by PH0PR11MB7167.namprd11.prod.outlook.com (2603:10b6:510:1e9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Mon, 17 Mar 2025 07:32:25 +0000 Received: from DM3PR11MB8735.namprd11.prod.outlook.com ([fe80::3225:d39b:ca64:ab95]) by DM3PR11MB8735.namprd11.prod.outlook.com ([fe80::3225:d39b:ca64:ab95%7]) with mapi id 15.20.8534.031; Mon, 17 Mar 2025 07:32:25 +0000 Message-ID: Date: Mon, 17 Mar 2025 15:32:16 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/7] memory: Attach MemoryAttributeManager to guest_memfd-backed RAMBlocks To: Tony Lindgren CC: David Hildenbrand , Alexey Kardashevskiy , Peter Xu , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Michael Roth , , , Williams Dan J , Peng Chao P , Gao Chao , Xu Yilun , Li Xiaoyao , "Maloor, Kishen" References: <20250310081837.13123-1-chenyi.qiang@intel.com> <20250310081837.13123-7-chenyi.qiang@intel.com> From: Chenyi Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0189.apcprd01.prod.exchangelabs.com (2603:1096:4:189::15) To DM3PR11MB8735.namprd11.prod.outlook.com (2603:10b6:0:4b::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR11MB8735:EE_|PH0PR11MB7167:EE_ X-MS-Office365-Filtering-Correlation-Id: 706d583c-479a-4975-ea58-08dd6525dcfe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WlRKNXdlc21jeUo5RzVEYTRNcW9CTElZSFVqS25GRmYvdDAzd01IaWQzaFNh?= =?utf-8?B?aXpBYVI1TVJSTFM3M09vN254K0lkaFR4SDlQYWJwZHhUNFlqdGNsMit5LzRJ?= =?utf-8?B?VEpqMWZSVTU3ODN1cFpBREt6ZDNmM3Q5Tm1WVjhybTJFRjFxdml3bXF4RDJK?= =?utf-8?B?NjRRQ3pQeVJ5OUp6OWNxN0thNWF6WENlOHI3RnZiVkErSWEwdVU1Wk5USEl0?= =?utf-8?B?Z25UK0NRS3hDYktqcGROTjJhWCtrdEZRNlFwUGF6cUpuZ0lKUjVoQTNQM0RO?= =?utf-8?B?dHVPNmJWZVZlNEdPckVqTmlFNXUvaFgvZ2cxN2lEZWtrblNZOVNqRHB0ajU3?= =?utf-8?B?TmdHL1ZQYm1ldTlGQzBwWUJqOER6a2h5M3MxVE42UVQxQUxZdStRenN3dXhi?= =?utf-8?B?bmJlNHUxbmg5TnRxWW9sTlJIcmZnTGpVbjhRYU1lUVBJUTlMVDZ1MGpzallr?= =?utf-8?B?WGFiaXo0ZEZZRkt4bkhTUzdKNHBvajlOVVp2bU5aSVRGRm1QWktnSlRFL1Vh?= =?utf-8?B?ak8rRGV6RkNlUHdyaUdZbzZZOTh5RGhvMlpwWm1CRFZkUVRhVGlId2g0MEJU?= =?utf-8?B?WGczMkw3QllWQzNoMkhVWi9peWNqcWFrUnZmRGRKeC9tQWdyZk1sREtKUnVG?= =?utf-8?B?NEJUSE45Umh2V0Y1bmVYTlhjU0VXUHlhdXhTQTQ0OFRvSS9oMG5ic0VPUkxQ?= =?utf-8?B?Y0tEWEtlaDFEV3Zham9zYVFIUGJLd1NnNlhaMVFWcnZCNHduMXZxWElGV0NI?= =?utf-8?B?Ynd5SS9peCtIQUJKczV1ZHFxdWNLYUFpWE9rS29kQVc5WFN2NVBvTmpKSkZm?= =?utf-8?B?SUxoTERZS1FyMlUyNGpocEkzRStOVzBOcHo4LzdqNDl6cGVmRWpVWGo5a1VJ?= =?utf-8?B?KytjYmJnVjhZRytxcE12WENpQU9tQ1YxSmYvd3llV1BQOW5iSUpBVExuMlcz?= =?utf-8?B?bU8wSHQrQUZEZE81ZkhDalc0Mm1OV2tyWFJ2NTNiLzNyMzdHMnpBNXJ2ZTlF?= =?utf-8?B?emtBTkFYN2oxRURuRWRKQzFMcTZmZjhDYjZBelptOFBETzB6cGhUVEVyYmN5?= =?utf-8?B?KzNSejBpeFRnMGo5ODdaNXdneHpNZWFrelNjQ3hONDRiQ3R2SkdSZUFGVzlJ?= =?utf-8?B?dlA5WVI5UUxrRFhtcGJ4YU9aeHBuQUw1VUJ1bUNYNU5kZkJjL2Vsa08yS3M4?= =?utf-8?B?eGFkTW1mNWlLSGkrT2Y5MDhDdjJReXI5VjBaUTRDdEJVTE9BcGQrei9mTlQ1?= =?utf-8?B?MUp2eTBDTjVrdVNvdjZyUGhUWE9uRXcvQzM3b09TaVFOVmcvMTdrbThmcVZT?= =?utf-8?B?RDQxVXA3S2s1M09QN3g1RTR5c3Q2Z2drMitXbHJ1TWd4YnVzbk9JeU5IeXJY?= =?utf-8?B?VW50MlIrQ2ljQlBhL0hTcXhxWjB1dWRnVEFvUDNjNDY5TXJobWk1S2ZubVEx?= =?utf-8?B?d25BS21DcUtpaHZxcEYvY3hqUlJoTlZ0a1JqcHRvakJoVVJMUytjMTZDVHdH?= =?utf-8?B?cFU0T1VLaTlrVzlGdVZEeGs2bzUyRG03TGZRVStzQVhaRkR4MWlhSkxrdFFX?= =?utf-8?B?T0ZTZDV0ck14VGtESS83ZWR4UlcwMUlIcDZqR0hXQzQ0QVJXa1grTDE0K3po?= =?utf-8?B?Q3ZRNmVuVENvR3gwSytTaHAvUytqb1pYNVF5eTFOR2U0dUpWQ1VPWDV5MEtR?= =?utf-8?B?RlRtd2lxbEVJNlk4RlhqTVFuMGtqNW9uM1VMZ2pCOEoxV2tEc3ExUFdINnoy?= =?utf-8?B?Z2ZSZEpnS3dKUGpsSGxwQ0wvY3l1bm5seE53Zjg3SGYvN0dUSlVwb3RnMjUw?= =?utf-8?B?UjFWdHFtYW5yU0lkVElEOWJnYm9PcXVhaTdNUkNJajVyVEVlSGtJbmZXN2Fi?= =?utf-8?Q?iCnsuwT9DXew2?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM3PR11MB8735.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm5LRFNJc0toM2ZyYnRwSURqaVZ4WkJGamx1M0ZRbXFVbVZYK0d4V0hiTXZt?= =?utf-8?B?bnQwTVN3UWZOR2pyS2pYZlhIblZ5aXFlV3hzWEM4WUhtcnd6WlRSOXM1N0NZ?= =?utf-8?B?VGx1blNLT1h1ZExFM0JuSnlHMHpTb2J4M2FVaGxGaWxDa1JPbUxMU1E1OW5F?= =?utf-8?B?T1ZRN3dkNnpueXRKeUxhYm9UdGZwNk4vVzhRdUJNOXF4czdrb3hXV1FwMzlp?= =?utf-8?B?YmQzOVZwNFhVTGw1LzdSRVVLRUtrclF4SExuRXoyZHMzL2wrTW9neXlHclRI?= =?utf-8?B?VnllZnRGTS9RNmhMc3o3cGhXMzcvaXhoNjZ0TmJLNWRiYUdrN1BlZUoxTDgr?= =?utf-8?B?dHlYTlhKREN4VTRINXJuY2xSMk5ybHN4VXV6OG1aazhJY01GeExWWUsyRjJr?= =?utf-8?B?QVhDVmdIMTl2bk5qYWhFbEtpQzl1RVN2OVBwOVpreUEwOXZXTWZlZnBxR3dK?= =?utf-8?B?MWZtMzVIMkVBOFBXcHBERldqMVZLeW1JZWFjRHdaK29RY1lSQ3NoalFSSi9M?= =?utf-8?B?V3hjUldyejMrRXdmZTQ3NG0zMmRIb2lmWk0xQVBMQU9oeUdDcHlLanNGd01p?= =?utf-8?B?V1FlMWExekJtMlVwTW95cG0wYUpJN1JvUGlpV1Z5aUVaNDV0QTFyTEUvUFJS?= =?utf-8?B?ZlNZT0pHKzZLUU13ekM2WDV6MEFoVmorWG14M01kTFhhbWorb2lCZEhzS3RP?= =?utf-8?B?TmpvTGdOZmFidHQxVHRVaERHMXVHOVlnOWVWN2hjK2xYZWl6ampNcHRSclV1?= =?utf-8?B?VWtEV1V1WUp4c0hEZ0Nyd3VrSHRtclo4VWZMajdoOThFNkMrNVducU9Ga0ZX?= =?utf-8?B?aUlvY25DYXZyVEI4bWh4cjZyM2lzYlk3bjFTeE5qVW5aeVdOdXhjdkUweEdz?= =?utf-8?B?ZzF3Wk01YjhnMTZ3bFVuQnV0Y2FVclk4Mjlrd0hleVlRVHRrN04zNXBtVDlo?= =?utf-8?B?UXpaMFI5OWtXMFI1YjRmT3JJak13c1hja3lwQmZKeE9iWkRZdUNQcm95RldU?= =?utf-8?B?UytHK000dGIvaXFPWUREN2U3dGNPNUNhNlBsL3AwOTExdW9Pb0s3dGVDRVpi?= =?utf-8?B?N2l3bWlkYnU1RTliVCs2Nm83VFljSXhtK2tzUGtQU3RFdS8zYmRPUDRrRFVp?= =?utf-8?B?UkhXWDkyeEViRTFpL3luc0NxNW9qZ2xIdVdjM1g2aCtjcHByckl1YTlWbzh0?= =?utf-8?B?WWZnZUkzL3dtR1hJTmhHQ3Y3NDB0YlNiQ1JxMlp5T0c0TFIvRzg5QjNnN2l1?= =?utf-8?B?STkzejMzMWNjK2pJSm5haUR0TDg0M1ZxQVZlM0VJYkFhNFF3ZUFaVXUralpa?= =?utf-8?B?UjF1ZmdFMHJvS2NIS1V2OEp2L2FyWWw0M0dIM2JpWS9YY0x4YVZ5c0hLZzBm?= =?utf-8?B?M29vQ0tIZVVwUFYrdzhjb3dPQ0pJQk52MSt2dE9iR21lSmJkblM4MmpTTVNF?= =?utf-8?B?eTUrKzRhNGw2ZGVYSEFSTHdweFMwV1ZXV29jRW9zSy9kQ295TWJ1WnRnWStp?= =?utf-8?B?TkRCOUtDL2duVkpYa3J2ckpUcklsWkU0Q2haN3JvcFQxeHkyM0o1WllEQmdL?= =?utf-8?B?ZldZMHdOK1JFeHNManU1VGEzZmV3QmpaQmtMUGJjOFdMRDh5bno5elJRSDQ4?= =?utf-8?B?eWVjekJHTEx5OFJoQTRDazFqQnhQc05WN1BWQlZjUG1RTmI4aEpmMXA4MVZw?= =?utf-8?B?cFlRbkJKalExSUFaK1pJck55UkpJd0Uydmg2WnlOQk9rNUY2d2ZUdHRMZDRh?= =?utf-8?B?WG5nTHVsUENZbjlxSjVSdTd1RmdnUi8wM0FOQ2hHby9ROHprVDg5dmE0VTlZ?= =?utf-8?B?M2d6NUV1bExCQ1YwRHI0U2ppZ0IvVnIyVGZQUkxzdStKSmNYY2d0R0U1dzli?= =?utf-8?B?ODNCNEt5dlZmckcreDZMck9sYWpxMWc1ME5Sakt4L0M5TmlqakFBck84NHBu?= =?utf-8?B?T040N2NER2p5aGx3dW1DOUdieVpRSHlNazVJSzJLQmFrcjZJajFzL1VWOWVj?= =?utf-8?B?N1Q2TStWdDk2dVk2blJmZit5RFhObEYrQlkxc2dLS29FNHlEbWNmRHQ3Q21N?= =?utf-8?B?R2hnb0lTVVR5c1gxY2lOSlUzdE8vV1NxYkNPT2VNKzFBdDBrWTNWQTFwUXpJ?= =?utf-8?B?Y2F6Y0d1VVd4Szhvampxejl1cFk0NmlEZ21pTXdmTHF1ZFN3dDd3RUFKazU5?= =?utf-8?B?L1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 706d583c-479a-4975-ea58-08dd6525dcfe X-MS-Exchange-CrossTenant-AuthSource: DM3PR11MB8735.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2025 07:32:25.5875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQ6HwwMB/V3UKtsC6LYwZUjlCwXUMIvv9BTDaJ6YZxLwV2cGF6Xdk/qDD8sYqv63kq1FghVhhbvjpog6iQV/Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7167 X-OriginatorOrg: intel.com Received-SPF: pass client-ip=198.175.65.12; envelope-from=chenyi.qiang@intel.com; helo=mgamail.intel.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.333, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/17/2025 2:18 PM, Tony Lindgren wrote: > Hi, > > On Mon, Mar 10, 2025 at 04:18:34PM +0800, Chenyi Qiang wrote: >> --- a/system/physmem.c >> +++ b/system/physmem.c >> @@ -1885,6 +1886,16 @@ static void ram_block_add(RAMBlock *new_block, Error **errp) >> qemu_mutex_unlock_ramlist(); >> goto out_free; >> } >> + >> + new_block->memory_attribute_manager = MEMORY_ATTRIBUTE_MANAGER(object_new(TYPE_MEMORY_ATTRIBUTE_MANAGER)); >> + if (memory_attribute_manager_realize(new_block->memory_attribute_manager, new_block->mr)) { >> + error_setg(errp, "Failed to realize memory attribute manager"); >> + object_unref(OBJECT(new_block->memory_attribute_manager)); >> + close(new_block->guest_memfd); >> + ram_block_discard_require(false); >> + qemu_mutex_unlock_ramlist(); >> + goto out_free; >> + } >> } >> >> ram_size = (new_block->offset + new_block->max_length) >> TARGET_PAGE_BITS; > > Might as well put the above into a separate memory manager init function > to start with. It keeps the goto out_free error path unified, and makes > things more future proof if the rest of ram_block_add() ever develops a > need to check for errors. Which part to be defined in a separate function? The init function of object_new() + realize(), or the error handling operation (object_unref() + close() + ram_block_discard_require(false))? If need to check for errors in the rest of ram_block_add() in future, how about adding a new label before out_free and move the error handling there? > > Regards, > > Tony