From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4oKL-0007Kb-05 for qemu-devel@nongnu.org; Thu, 10 Nov 2016 07:19:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4oKH-0008UH-QD for qemu-devel@nongnu.org; Thu, 10 Nov 2016 07:19:32 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4oKH-0008U3-JU for qemu-devel@nongnu.org; Thu, 10 Nov 2016 07:19:29 -0500 Received: by mail-wm0-x231.google.com with SMTP id t79so27711916wmt.0 for ; Thu, 10 Nov 2016 04:19:29 -0800 (PST) Sender: Paolo Bonzini References: <1473847013-20191-1-git-send-email-pbonzini@redhat.com> <87k2cb8st5.fsf@linaro.org> From: Paolo Bonzini Message-ID: Date: Thu, 10 Nov 2016 13:19:26 +0100 MIME-Version: 1.0 In-Reply-To: <87k2cb8st5.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/3] target-arm: cache tbflags in CPUARMState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org On 10/11/2016 12:42, Alex Bennée wrote: > > Paolo Bonzini writes: > >> Computing TranslationBlock flags is pretty expensive on ARM, especially >> 32-bit. Because tbflags are computed on every tb lookup, it is not >> unlikely to see cpu_get_tb_cpu_state close to the top of the profile >> now that QHT makes the hash table much more efficient. >> >> However, most tbflags only change when the EL is switched or after >> MSR instructions. Based on this observation, this series caches these >> tbflags in CPUARMState, resulting in a 10-15% speedup on 32-bit code. > > Hi, > > I'm starting to clear out my review queue but I notice these now longer > apply cleanly to master. Where you going to re-issue the series once > you'd addressed Peter's concerns? Yes, I didn't want to send them two days before soft freeze and Peter's vacation. :) Paolo