From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs
Date: Thu, 23 Jul 2020 15:42:24 +0200 [thread overview]
Message-ID: <b177ca63-a7bb-03e7-df22-13f77fed9678@redhat.com> (raw)
In-Reply-To: <20200723132219.2956-1-thuth@redhat.com>
On 7/23/20 3:22 PM, Thomas Huth wrote:
> The dependency on curses has been removed in commit c7a856b42e403e2b
> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
> So we can remove the related lines in the Makefile now, too.
Don't we also need to remove all uses of CONFIG_CURSES to
be complete? Eventually display a warning with --(en|dis)able-curses
is used.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/unicore32/Makefile.objs | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/unicore32/Makefile.objs b/target/unicore32/Makefile.objs
> index 35d8bf530d..6b41b1e9ef 100644
> --- a/target/unicore32/Makefile.objs
> +++ b/target/unicore32/Makefile.objs
> @@ -2,7 +2,3 @@ obj-y += translate.o op_helper.o helper.o cpu.o
> obj-y += ucf64_helper.o
>
> obj-$(CONFIG_SOFTMMU) += softmmu.o
> -
> -# Huh? Uses curses directly instead of using ui/console.h interfaces ...
> -helper.o-cflags := $(CURSES_CFLAGS)
> -helper.o-libs := $(CURSES_LIBS)
>
next prev parent reply other threads:[~2020-07-23 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:22 [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs Thomas Huth
2020-07-23 13:42 ` Philippe Mathieu-Daudé [this message]
2020-07-23 13:45 ` Thomas Huth
2020-07-23 15:11 ` Philippe Mathieu-Daudé
2020-07-23 14:50 ` Peter Maydell
2020-07-23 15:19 ` Thomas Huth
2020-07-25 0:59 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b177ca63-a7bb-03e7-df22-13f77fed9678@redhat.com \
--to=philmd@redhat.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).