Re: [PATCH 2/3] hw/audio: Remove intel_hda_and_codec_init()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 21/10/25 15:24, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Oct 21, 2025 at 5:18 PM Philippe Mathieu-Daudé 
> <philmd@linaro.org <mailto:philmd@linaro.org>> wrote:
> 
>     `-soundhw hda` was removed in commit 039a68373c4 ("introduce -audio
>     as a replacement for -soundhw").
> 
> 
> Sorry, that "hda" (= intel-hda + hda-duplex) short form is used by -audio.

Yes, it was deprecated for 2 releases but we missed to remove it
in commit 039a68373c4:

-- >8 --
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index bc77e3d8c9d..f38117057b9 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -1311,17 +1311,16 @@ static const TypeInfo hda_codec_device_type_info = {
   * create intel hda controller with codec attached to it,
   * so '-soundhw hda' works.
   */
-static int intel_hda_and_codec_init(PCIBus *bus)
+static int intel_hda_and_codec_init(PCIBus *bus, const char *audiodev)
  {
      DeviceState *controller;
      BusState *hdabus;
      DeviceState *codec;

-    warn_report("'-soundhw hda' is deprecated, "
-                "please use '-device intel-hda -device hda-duplex' 
instead");
      controller = DEVICE(pci_create_simple(bus, -1, "intel-hda"));
      hdabus = QLIST_FIRST(&controller->child_bus);
      codec = qdev_new("hda-duplex");
+    qdev_prop_set_string(codec, "audiodev", audiodev);
      qdev_realize_and_unref(codec, hdabus, &error_fatal);
      return 0;
  }
---

Users should be now using "-device intel-hda -device hda-duplex"
instead of "-audio hda".