From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43771)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1b9w8v-0001Y2-83
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 11:08:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1b9w8r-0005RX-R9
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 11:08:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43128)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1b9w8r-0005RT-LG
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 11:08:37 -0400
References: <20160602191305.GB31052@thinpad.lan.raisama.net>
	<20160603012327.GB29298@ad.usersys.redhat.com>
	<20160603182601.GS19055@thinpad.lan.raisama.net>
	<20160606065824.GA9676@ad.usersys.redhat.com>
	<20160606114724.GB19055@thinpad.lan.raisama.net>
	<20160606115423.GC19055@thinpad.lan.raisama.net>
	<20160606125034.GE19055@thinpad.lan.raisama.net>
	<c959a548-c104-6f5a-e948-c28961686056@redhat.com>
	<20160606141528.GF19055@thinpad.lan.raisama.net>
	<f7511b8c-eb1a-50b6-cd91-a29d904c2869@redhat.com>
	<20160606150218.GG19055@thinpad.lan.raisama.net>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <b18ae52e-c79c-7923-5456-70f0bfd89b33@redhat.com>
Date: Mon, 6 Jun 2016 17:08:31 +0200
MIME-Version: 1.0
In-Reply-To: <20160606150218.GG19055@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, peter.maydell@linaro.org, qemu-devel@nongnu.org



On 06/06/2016 17:02, Eduardo Habkost wrote:
> On Mon, Jun 06, 2016 at 04:32:50PM +0200, Paolo Bonzini wrote:
>> On 06/06/2016 16:15, Eduardo Habkost wrote:
>>>>> No, the second time you'll get the expansion of
>>>>>
>>>>> DOCKER_SRC_COPY := docker-src.$(CUR_TIME)
>>> And why it isn't enough to simply write the above line in the
>>> Makefile without any eval trick?
>>
>> Because 1) initially the idea was to delay the $(mkdir) too 2) Too many
>> $(shell) end up slowing down make.
> 
> Now I see: you wanted to delay the shell command, but evaluate it
> only once.
> 
> But I don't see why it makes sense here, because the variable is
> being expanded immediately after it is defined (in the
> "$(DOCKER_SRC_COPY):" line), and CUR_TIME is already defined
> using ":=".

Well, when I proposed the eval trick CUR_TIME was defined with "=". :)

I agree that right now it's all unnecessary.

Paolo