From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55740C83F34 for ; Fri, 18 Jul 2025 22:25:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uctUm-00035J-4o; Fri, 18 Jul 2025 18:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucstw-0007aI-Rm for qemu-devel@nongnu.org; Fri, 18 Jul 2025 17:46:10 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucstu-0007QB-O4 for qemu-devel@nongnu.org; Fri, 18 Jul 2025 17:45:56 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-23c8f179e1bso26026355ad.1 for ; Fri, 18 Jul 2025 14:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752875152; x=1753479952; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=qFCgTEnGfbkQyGEyygjMD6Tgh0lIzYBSqfo2EolfHrE=; b=y+ylFT2IQPpeyMAzRsvVTaNJtvp1E0dSkyNENUH2Vmkph9vgyJCuiF9fKLX0MlewyP JLYOLJyRY3/a2UyN4CEuLQaQKRm/pHwD8y8m2x/GYNqnHtfy957TO3CYcSdBClIU+2oi i0vvT25XGltJgixr+mF/milo+RM25srJK/bFKj4RsBiMEEiLcZKzqKal4qL6flVFKHFt XriHw0fmXPIIou73yg7OllONjumvQ2UKXw2M230k2RtRojIcIJQ+kiayzNlYl06YYNiG TG3RXlh6SHVBdrKhF+u7yKA9A+FHfuvXyfjYtA/KyFq+SqZL5vKpmWSaYj4aR4H2dVnK ZI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752875152; x=1753479952; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qFCgTEnGfbkQyGEyygjMD6Tgh0lIzYBSqfo2EolfHrE=; b=efN8VqLPLXgs4IU/JighKKKvmnSRL5jyfyFU9zbs6p50lYDIZIj2mG17pHDSKhvcPq /EssYiijI93f6/lhUpoD3Uq5jbK+Fv5QDVOnlfK7M6xaHySfVAgBYOXNVndTNLz5gQnJ xZ65l2Jkwnc4Q/XYyiywlib7zMY+Ut4Jh6MM1Yp/Z2tHk9alHbVBtQMa6+IFGFY9yhHm 5XldJtdaQMt0/PoMyfvuhtQNGWweoVUO0HuaP3HcXPOvsW7PZmBN3PmJcwtyonZaWs+v i7W8mhtHRz8qazLGszG0DHBMKuuq+fubxG5Nq1RkR5Cx0VaUyiN9bvChelUzJJDadR0S AtDQ== X-Forwarded-Encrypted: i=1; AJvYcCUQMjiCPyk9Gs0255KuMhOIjuwaqiGeQWNVUqRFJod35iCb+L3xkCvgtM60137V2m3f0kFtRcVFT+s0@nongnu.org X-Gm-Message-State: AOJu0Yxzk1yWaWe0fl16U0JjnyjiASVnrzqV2i5wuXI4oRjo8IMBuFCr mnIAYptMiVpfcU9/2ASS4nEthTe5lBglJ3+ceLlhYcF/l/HeQJojn5HdhpW5A0ENDCw= X-Gm-Gg: ASbGncvLrRI3jhg3NYiRWAxjF1TTE2gmK0KDU0h44TNoZ99gKQI3l6ZSxDUzmiOolvd P4yLuKIZfoRMszjFWsVlAKN0K0MNg/qg4EXuLhpRammc5wSE7dJC19oXKSyUiwDxLtS2UlC7I+v A3MB8i8H8SdTX1MhQZS86xhR7If4RwWt9ERioJEtUoz5lGrgbbuC/GWxqYcmfvcZFCwJlhFBI+d pB/XMBlg1UHFEuJl/g8EIB7v/Q7Rcrhyvi+RPThC3EO/aCNcbDEhMxIkg4t7qbHyNa94ItxCPeS Yirpq/4OluQhTKX3UJziZxePx8Ao14TeOzpOp5g8qpzGWdNWsjRoel1traAxjl3O2rO/KqRRQqx v0gMH7cbO+ZiX3794SklzQUE0FknZjdW2ECe6Q6ul5w== X-Google-Smtp-Source: AGHT+IEcfN9XF5zFoUPVIMTKoXQvKGvYLii74QjF2piLXT4zWBbXAd4vgMHmSrTJWWGEdpoZYGUVng== X-Received: by 2002:a17:903:2342:b0:235:ea29:28e9 with SMTP id d9443c01a7336-23e25764c41mr213318765ad.38.1752875152430; Fri, 18 Jul 2025 14:45:52 -0700 (PDT) Received: from [192.168.101.134] ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b6b48f2sm17959695ad.90.2025.07.18.14.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 14:45:51 -0700 (PDT) Message-ID: Date: Fri, 18 Jul 2025 14:45:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-10.1 09/10] target/arm: Honour FPCR.AH=1 default NaN value in FMAXNMQV, FMINNMQV To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20250718173032.2498900-1-peter.maydell@linaro.org> <20250718173032.2498900-10-peter.maydell@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20250718173032.2498900-10-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/18/25 10:30, Peter Maydell wrote: > The FMAXNMQV and FMINNMQV insns use the default NaN as their identity > value for inactive source vector elements. We open-coded this in > sve_helper.c, hoping to avoid a function call. However, this fails > to account for FPCR.AH=1 changing the default NaN value to set the > sign bit. Use a call to floatN_default_nan() to obtain this value. > > Fixes: 1de7ecfc12d05 ("target/arm: Implement FADDQV, F{MIN, MAX}{NM}QV for SVE2p1") > Signed-off-by: Peter Maydell > --- > target/arm/tcg/sve_helper.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~