* Build for qemu-sh4 broken since 2445971604c
@ 2020-02-15 10:53 John Paul Adrian Glaubitz
2020-02-15 13:53 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: John Paul Adrian Glaubitz @ 2020-02-15 10:53 UTC (permalink / raw)
To: QEMU Developers
Hi!
Currently trying to build qemu-sh4 in static configuration fails with:
make[1]: Entering directory '/root/qemu/slirp'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/root/qemu/slirp'
CC sh4-linux-user/tcg/tcg-op-gvec.o
/root/qemu/tcg/tcg-op-gvec.c:298:25: error: unknown type name ‘gen_helper_gvec_5_ptr’; did you mean ‘gen_helper_gvec_4_ptr’?
298 | gen_helper_gvec_5_ptr *fn)
| ^~~~~~~~~~~~~~~~~~~~~
| gen_helper_gvec_4_ptr
make[1]: *** [/root/qemu/rules.mak:69: tcg/tcg-op-gvec.o] Error 1
make: *** [Makefile:497: sh4-linux-user/all] Error 2
This seems to have been introduced with:
commit 2445971604c1cfd3ec484457159f4ac300fb04d2
Author: Richard Henderson <richard.henderson@linaro.org>
Date: Tue Feb 11 16:31:38 2020 -0800
tcg: Add tcg_gen_gvec_5_ptr
Extend the vector generator infrastructure to handle
5 vector arguments.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Build for qemu-sh4 broken since 2445971604c 2020-02-15 10:53 Build for qemu-sh4 broken since 2445971604c John Paul Adrian Glaubitz @ 2020-02-15 13:53 ` Philippe Mathieu-Daudé 2020-02-15 14:01 ` Philippe Mathieu-Daudé 2020-02-15 14:12 ` John Paul Adrian Glaubitz 0 siblings, 2 replies; 4+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-15 13:53 UTC (permalink / raw) To: John Paul Adrian Glaubitz, QEMU Developers, Laurent Vivier, Richard Henderson Hi John, On 2/15/20 11:53 AM, John Paul Adrian Glaubitz wrote: > Hi! > > Currently trying to build qemu-sh4 in static configuration fails with: > > make[1]: Entering directory '/root/qemu/slirp' > make[1]: Nothing to be done for 'all'. > make[1]: Leaving directory '/root/qemu/slirp' > CC sh4-linux-user/tcg/tcg-op-gvec.o > /root/qemu/tcg/tcg-op-gvec.c:298:25: error: unknown type name ‘gen_helper_gvec_5_ptr’; did you mean ‘gen_helper_gvec_4_ptr’? > 298 | gen_helper_gvec_5_ptr *fn) > | ^~~~~~~~~~~~~~~~~~~~~ > | gen_helper_gvec_4_ptr > make[1]: *** [/root/qemu/rules.mak:69: tcg/tcg-op-gvec.o] Error 1 > make: *** [Makefile:497: sh4-linux-user/all] Error 2 I believe your build directory is out of date and might have dangling old files. > This seems to have been introduced with: > > commit 2445971604c1cfd3ec484457159f4ac300fb04d2 > Author: Richard Henderson <richard.henderson@linaro.org> > Date: Tue Feb 11 16:31:38 2020 -0800 > > tcg: Add tcg_gen_gvec_5_ptr > > Extend the vector generator infrastructure to handle > 5 vector arguments. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Taylor Simpson <tsimpson@quicinc.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> If you look the content of this commit, the new type is properly declared: --- a/include/tcg/tcg-op-gvec.h +++ b/include/tcg/tcg-op-gvec.h @@ -83,6 +83,13 @@ void tcg_gen_gvec_4_ptr(uint32_t dofs, uint32_t aofs, uint32_t bofs, uint32_t maxsz, int32_t data, gen_helper_gvec_4_ptr *fn); uint32_t maxsz, int32_t data, gen_helper_gvec_4_ptr *fn); +typedef void gen_helper_gvec_5_ptr(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr, + TCGv_ptr, TCGv_ptr, TCGv_i32); +void tcg_gen_gvec_5_ptr(uint32_t dofs, uint32_t aofs, uint32_t bofs, + uint32_t cofs, uint32_t eofs, TCGv_ptr ptr, + uint32_t oprsz, uint32_t maxsz, int32_t data, + gen_helper_gvec_5_ptr *fn); + BTW what capstone configuration are you using? Is that --disable-capstone or another? Regards, Phil. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build for qemu-sh4 broken since 2445971604c 2020-02-15 13:53 ` Philippe Mathieu-Daudé @ 2020-02-15 14:01 ` Philippe Mathieu-Daudé 2020-02-15 14:12 ` John Paul Adrian Glaubitz 1 sibling, 0 replies; 4+ messages in thread From: Philippe Mathieu-Daudé @ 2020-02-15 14:01 UTC (permalink / raw) To: John Paul Adrian Glaubitz, Richard Henderson, Alex Bennée Cc: QEMU Developers, Laurent Vivier On Sat, Feb 15, 2020 at 2:53 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Hi John, > > On 2/15/20 11:53 AM, John Paul Adrian Glaubitz wrote: > > Hi! > > > > Currently trying to build qemu-sh4 in static configuration fails with: > > > > make[1]: Entering directory '/root/qemu/slirp' > > make[1]: Nothing to be done for 'all'. > > make[1]: Leaving directory '/root/qemu/slirp' > > CC sh4-linux-user/tcg/tcg-op-gvec.o > > /root/qemu/tcg/tcg-op-gvec.c:298:25: error: unknown type name ‘gen_helper_gvec_5_ptr’; did you mean ‘gen_helper_gvec_4_ptr’? > > 298 | gen_helper_gvec_5_ptr *fn) > > | ^~~~~~~~~~~~~~~~~~~~~ > > | gen_helper_gvec_4_ptr > > make[1]: *** [/root/qemu/rules.mak:69: tcg/tcg-op-gvec.o] Error 1 > > make: *** [Makefile:497: sh4-linux-user/all] Error 2 > > I believe your build directory is out of date and might have dangling > old files. FYI the CI job succeeds: https://travis-ci.org/qemu/qemu/jobs/650567444#L3193 > > This seems to have been introduced with: > > > > commit 2445971604c1cfd3ec484457159f4ac300fb04d2 > > Author: Richard Henderson <richard.henderson@linaro.org> > > Date: Tue Feb 11 16:31:38 2020 -0800 > > > > tcg: Add tcg_gen_gvec_5_ptr > > > > Extend the vector generator infrastructure to handle > > 5 vector arguments. > > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > > Reviewed-by: Taylor Simpson <tsimpson@quicinc.com> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > > If you look the content of this commit, the new type is properly declared: > > --- a/include/tcg/tcg-op-gvec.h > +++ b/include/tcg/tcg-op-gvec.h > @@ -83,6 +83,13 @@ void tcg_gen_gvec_4_ptr(uint32_t dofs, uint32_t aofs, > uint32_t bofs, > uint32_t maxsz, int32_t data, > gen_helper_gvec_4_ptr *fn); > > uint32_t maxsz, int32_t data, > gen_helper_gvec_4_ptr *fn); > > +typedef void gen_helper_gvec_5_ptr(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr, > + TCGv_ptr, TCGv_ptr, TCGv_i32); > +void tcg_gen_gvec_5_ptr(uint32_t dofs, uint32_t aofs, uint32_t bofs, > + uint32_t cofs, uint32_t eofs, TCGv_ptr ptr, > + uint32_t oprsz, uint32_t maxsz, int32_t data, > + gen_helper_gvec_5_ptr *fn); > + > > BTW what capstone configuration are you using? > Is that --disable-capstone or another? OK I understood, Debian provide capstone.a: https://packages.debian.org/sid/sh4/libcapstone-dev/filelist and our CI job on Travis is based on Ubuntu, so using --static works: https://travis-ci.org/qemu/qemu/jobs/650567444 Fedora capstone-devel package only provide a shared library. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Build for qemu-sh4 broken since 2445971604c 2020-02-15 13:53 ` Philippe Mathieu-Daudé 2020-02-15 14:01 ` Philippe Mathieu-Daudé @ 2020-02-15 14:12 ` John Paul Adrian Glaubitz 1 sibling, 0 replies; 4+ messages in thread From: John Paul Adrian Glaubitz @ 2020-02-15 14:12 UTC (permalink / raw) To: Philippe Mathieu-Daudé, QEMU Developers, Laurent Vivier, Richard Henderson On 2/15/20 2:53 PM, Philippe Mathieu-Daudé wrote: > On 2/15/20 11:53 AM, John Paul Adrian Glaubitz wrote: >> Hi! >> >> Currently trying to build qemu-sh4 in static configuration fails with: >> >> make[1]: Entering directory '/root/qemu/slirp' >> make[1]: Nothing to be done for 'all'. >> make[1]: Leaving directory '/root/qemu/slirp' >> CC sh4-linux-user/tcg/tcg-op-gvec.o >> /root/qemu/tcg/tcg-op-gvec.c:298:25: error: unknown type name ‘gen_helper_gvec_5_ptr’; did you mean ‘gen_helper_gvec_4_ptr’? >> 298 | gen_helper_gvec_5_ptr *fn) >> | ^~~~~~~~~~~~~~~~~~~~~ >> | gen_helper_gvec_4_ptr >> make[1]: *** [/root/qemu/rules.mak:69: tcg/tcg-op-gvec.o] Error 1 >> make: *** [Makefile:497: sh4-linux-user/all] Error 2 > > I believe your build directory is out of date and might have dangling old files. Yes, this seems to have been the problem, thanks. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-15 14:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-15 10:53 Build for qemu-sh4 broken since 2445971604c John Paul Adrian Glaubitz 2020-02-15 13:53 ` Philippe Mathieu-Daudé 2020-02-15 14:01 ` Philippe Mathieu-Daudé 2020-02-15 14:12 ` John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).