From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45F6EC2D0CD for ; Thu, 15 May 2025 16:08:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFb7e-00052z-Ak; Thu, 15 May 2025 12:07:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFb7a-0004wx-6R; Thu, 15 May 2025 12:07:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFb7X-0000cp-M0; Thu, 15 May 2025 12:07:45 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54FCg1hR016398; Thu, 15 May 2025 16:07:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=DneRYX3fVWZMWawsfG4ns9jp3fevs+3wSQWUxpmEWf0=; b=rhJedFUl+Gge F8WyvYnwkO4ROc52F/pakKEEtLTh3f4UcF3LnuN6S/hsImyr4RSEDdfdW1/O/O3o PpYpCetkyKYA62exDx+PsyganPI5JZkd/HqdgZJVESH9B7+wSEwMK4Y0aoX0/47q v5AFVn2W3+bYK34fZFbVPZUPIgIXYkGEbki6SCO+NXEitQpPFgB7Pl4qejw9NGXd OpKHIT2Ya0EW2qFYGj3hSwTdmaV8GL6vuqIKo+3Gsa+eFaXuX5JeBw5NIIeYudyk pDcWYnZka3w28h732aU7hsxV1oCM+2p3/ZuO7/7QfP5sLyckebRenb+SurBPelZP frFE8vFo3A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46nd4gtass-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 16:07:36 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54FG6t8H022560; Thu, 15 May 2025 16:07:35 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46nd4gtasr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 16:07:35 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54FDqFSD026954; Thu, 15 May 2025 16:07:34 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 46mbfpk4ka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 16:07:34 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54FG7X3w49218008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 May 2025 16:07:33 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CA6558056; Thu, 15 May 2025 16:07:33 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A3EF05803F; Thu, 15 May 2025 16:07:32 +0000 (GMT) Received: from mambor8.rchland.ibm.com (unknown [9.10.239.198]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 May 2025 16:07:32 +0000 (GMT) Message-ID: Subject: Re: [PATCH 38/50] ppc/xive2: Avoid needless interrupt re-check on CPPR set From: Miles Glenn To: Nicholas Piggin , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Fr=E9d=E9ric?= Barrat , Michael Kowal , Caleb Schlossin Date: Thu, 15 May 2025 11:07:32 -0500 In-Reply-To: <20250512031100.439842-39-npiggin@gmail.com> References: <20250512031100.439842-1-npiggin@gmail.com> <20250512031100.439842-39-npiggin@gmail.com> Organization: IBM Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-27.el8_10) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GdNUvrKHdc6PQPsUZXXsAwJxatvyhJpy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE1MDE1NSBTYWx0ZWRfX15BqpVfB2L8I 9C5lnLayE9V6y76fe+mRj1mBfBEXhBa+3Y8q6y1V2iHYr78swlNOZjVHcqH4MjpjJOvG0pRIrPP brcL3Yp4pjKMmFOTGQJJL79IytiqZLEhu7QuGRcV5whkTbqckGtS26YwTl20+aJmq891/SyIh8t 5xyiV0wTkAuMrQXZqsxIreamiHjxiLPwFT/ZYPmoD5AR4hQ18ZGmTPCQ6vI4NhcnhpG64A5o2zb MmkxBLgOvAfGnAOioktVeRxoflr6JZstCPpQCTfbW+YmaApRcjDlSXIxbIhZml7AanIOta0XBAj swKoJiSUYB4qa9OxTlqNdeDO+9/59DbPS3HhmwYU1i3EZCiXZDeW6MxOfVRchzw0a0TluvTN4En oFrq78F53+x1c7MnmLNGycSlYqBZ22ExCGzCKy+TmX0AYxTX3xAgSnOHzMm+HaLWH3prGIL+ X-Proofpoint-ORIG-GUID: Y4RXP1O5O0jXfEOeV1KIvKkM4bORt3hF X-Authority-Analysis: v=2.4 cv=OsNPyz/t c=1 sm=1 tr=0 ts=68261148 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=g_CFbk5as9EJpEZ9zXwA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-15_06,2025-05-15_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 mlxlogscore=737 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505150155 Received-SPF: pass client-ip=148.163.156.1; envelope-from=milesg@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: milesg@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Reviewed-by: Glenn Miles On Mon, 2025-05-12 at 13:10 +1000, Nicholas Piggin wrote: > When CPPR priority is decreased, pending interrupts do not need to be > re-checked if one is already presented because by definition that will > be the highest priority. > > This prevents a presented group interrupt from being lost. > > Signed-off-by: Nicholas Piggin > --- > hw/intc/xive2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c > index 0fdf6a4f20..ace5871706 100644 > --- a/hw/intc/xive2.c > +++ b/hw/intc/xive2.c > @@ -1250,7 +1250,9 @@ static void xive2_tctx_set_cppr(XiveTCTX *tctx, uint8_t sig_ring, uint8_t cppr) > } > > /* CPPR priority decreased (higher value) */ > - xive2_tctx_process_pending(tctx, sig_ring); > + if (!xive_nsr_indicates_exception(sig_ring, nsr)) { > + xive2_tctx_process_pending(tctx, sig_ring); > + } > } > > void xive2_tm_set_hv_cppr(XivePresenter *xptr, XiveTCTX *tctx,