* [PATCH qemu master] hw/misc/aspeed_pwm: fix typo
@ 2021-12-22 10:24 Troy Lee
2021-12-23 6:52 ` Philippe Mathieu-Daudé
2021-12-23 9:19 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: Troy Lee @ 2021-12-22 10:24 UTC (permalink / raw)
To: openbmc
Cc: Peter Maydell, Andrew Jeffery, open list:All patches CC here,
leetroy, open list:ASPEED BMCs, Cédric Le Goater,
Joel Stanley
Typo found during developing.
Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
---
hw/misc/aspeed_pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
index 8ebab5dcef..dbf9634da3 100644
--- a/hw/misc/aspeed_pwm.c
+++ b/hw/misc/aspeed_pwm.c
@@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
dc->realize = aspeed_pwm_realize;
dc->reset = aspeed_pwm_reset;
- dc->desc = "Aspeed PWM Controller",
+ dc->desc = "Aspeed PWM Controller";
dc->vmsd = &vmstate_aspeed_pwm;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH qemu master] hw/misc/aspeed_pwm: fix typo
2021-12-22 10:24 [PATCH qemu master] hw/misc/aspeed_pwm: fix typo Troy Lee
@ 2021-12-23 6:52 ` Philippe Mathieu-Daudé
2021-12-23 9:19 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-12-23 6:52 UTC (permalink / raw)
To: Troy Lee, openbmc
Cc: Peter Maydell, Andrew Jeffery, open list:All patches CC here,
leetroy, open list:ASPEED BMCs, Cédric Le Goater,
Joel Stanley
On 12/22/21 11:24, Troy Lee wrote:
> Typo found during developing.
>
> Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> hw/misc/aspeed_pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
> index 8ebab5dcef..dbf9634da3 100644
> --- a/hw/misc/aspeed_pwm.c
> +++ b/hw/misc/aspeed_pwm.c
> @@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
>
> dc->realize = aspeed_pwm_realize;
> dc->reset = aspeed_pwm_reset;
> - dc->desc = "Aspeed PWM Controller",
> + dc->desc = "Aspeed PWM Controller";
> dc->vmsd = &vmstate_aspeed_pwm;
> }
>
No need for another patch, since it doesn't build.
Simply squash it in your commit 70b3f1a34d3c.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH qemu master] hw/misc/aspeed_pwm: fix typo
2021-12-22 10:24 [PATCH qemu master] hw/misc/aspeed_pwm: fix typo Troy Lee
2021-12-23 6:52 ` Philippe Mathieu-Daudé
@ 2021-12-23 9:19 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2021-12-23 9:19 UTC (permalink / raw)
To: Troy Lee, openbmc
Cc: Peter Maydell, Andrew Jeffery, open list:All patches CC here,
leetroy, open list:ASPEED BMCs, Joel Stanley
Hello Troy Lee,
On 12/22/21 11:24, Troy Lee wrote:
> Typo found during developing.
>
> Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")
PWM is not upstream. I will include the fix in a new aspeed-7.0 branch.
Thanks,
C.
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> hw/misc/aspeed_pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
> index 8ebab5dcef..dbf9634da3 100644
> --- a/hw/misc/aspeed_pwm.c
> +++ b/hw/misc/aspeed_pwm.c
> @@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
>
> dc->realize = aspeed_pwm_realize;
> dc->reset = aspeed_pwm_reset;
> - dc->desc = "Aspeed PWM Controller",
> + dc->desc = "Aspeed PWM Controller";
> dc->vmsd = &vmstate_aspeed_pwm;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-23 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-22 10:24 [PATCH qemu master] hw/misc/aspeed_pwm: fix typo Troy Lee
2021-12-23 6:52 ` Philippe Mathieu-Daudé
2021-12-23 9:19 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).