Re: [Qemu-devel] [RFC PATCH 1/3] tpm: Implement virtual memory device for TPM PPI

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On 01/12/2018 08:55 AM, Marc-André Lureau wrote:
> Hi
> 
> On Wed, Jan 10, 2018 at 7:35 PM, Stefan Berger
> <stefanb@linux.vnet.ibm.com> wrote:
>> Implement a virtual memory device for the TPM physical
>> presence interface. The memory is located at 0xffff0000
>> and used by ACPI to send messages to the firmware (BIOS).
>>
>> This device should be used by all TPM interfaces on x86 and
>> can be added through by calling tpm_ppi_init_io().
>>

>> +#define DEBUG_PPI 1
> 
> to be switched to 0
> 
>> +
>> +#define DPRINTF(fmt, ...) do { \
>> +    if (DEBUG_PPI) { \
>> +        printf(fmt, ## __VA_ARGS__); \
>> +    } \
>> +} while (0);

Also, this falls foul of my pending patch to forbid trailing semicolons
in do/while(0) macros:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00246.html

But even though it is not a trace point, at least you made sure -Wformat
will avoid bit-rotting debug statements.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]