From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: qemu-devel@nongnu.org, Laszlo Ersek <lersek@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2
Date: Fri, 5 Apr 2019 13:29:44 +0200 [thread overview]
Message-ID: <b1c37e96-4679-b342-bf26-7043cc754220@redhat.com> (raw)
In-Reply-To: <20190405131616.071a6390.olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On 4/5/19 1:16 PM, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 12:59:18 +0200
> schrieb Olaf Hering <olaf@aepfle.de>:
>
>> This used to work still in January with c9d18c1c150c84e7a976df989ad04ddf01083f46.
>
> It is not possible to just override EFIROM=$(type -P EfiRom) because this variable is also used by ipxe.git.
Yes, lets got back with the overridable form previous to f590a812c210:
-- >8 --
diff --git a/roms/Makefile b/roms/Makefile
index 78d5dd18c30..fc501a6c30c 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -49,3 +49,3 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
#
-EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
+EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom
---
I'll submit that patch.
Thanks,
Phil.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] edk2 fails to compile in v4.0.0-rc2
Date: Fri, 5 Apr 2019 13:29:44 +0200 [thread overview]
Message-ID: <b1c37e96-4679-b342-bf26-7043cc754220@redhat.com> (raw)
Message-ID: <20190405112944.VpTgGOdtwju3SfoH2wdCkeDqynAD7SxbgGvt998-6Ow@z> (raw)
In-Reply-To: <20190405131616.071a6390.olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On 4/5/19 1:16 PM, Olaf Hering wrote:
> Am Fri, 5 Apr 2019 12:59:18 +0200
> schrieb Olaf Hering <olaf@aepfle.de>:
>
>> This used to work still in January with c9d18c1c150c84e7a976df989ad04ddf01083f46.
>
> It is not possible to just override EFIROM=$(type -P EfiRom) because this variable is also used by ipxe.git.
Yes, lets got back with the overridable form previous to f590a812c210:
-- >8 --
diff --git a/roms/Makefile b/roms/Makefile
index 78d5dd18c30..fc501a6c30c 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -49,3 +49,3 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
#
-EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
+EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom
---
I'll submit that patch.
Thanks,
Phil.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-05 11:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 10:39 [Qemu-devel] edk2 fails to compile in v4.0.0-rc2 Olaf Hering
2019-04-05 10:39 ` Olaf Hering
2019-04-05 10:49 ` Philippe Mathieu-Daudé
2019-04-05 10:49 ` Philippe Mathieu-Daudé
2019-04-05 10:59 ` Olaf Hering
2019-04-05 10:59 ` Olaf Hering
2019-04-05 11:14 ` Philippe Mathieu-Daudé
2019-04-05 11:14 ` Philippe Mathieu-Daudé
2019-04-05 11:24 ` Philippe Mathieu-Daudé
2019-04-05 11:24 ` Philippe Mathieu-Daudé
2019-04-05 11:27 ` Olaf Hering
2019-04-05 11:27 ` Olaf Hering
2019-04-05 11:16 ` Olaf Hering
2019-04-05 11:16 ` Olaf Hering
2019-04-05 11:29 ` Philippe Mathieu-Daudé [this message]
2019-04-05 11:29 ` Philippe Mathieu-Daudé
2019-04-05 11:31 ` Olaf Hering
2019-04-05 11:31 ` Olaf Hering
2019-04-08 9:04 ` Laszlo Ersek
2019-04-08 9:04 ` Laszlo Ersek
2019-04-08 9:09 ` Olaf Hering
2019-04-08 9:09 ` Olaf Hering
2019-04-08 9:42 ` Laszlo Ersek
2019-04-08 9:42 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c37e96-4679-b342-bf26-7043cc754220@redhat.com \
--to=philmd@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).