From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Joelle van Dyne <j@getutm.app>, qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH v2 4/4] slirp: feature detection for smbd
Date: Tue, 9 Mar 2021 15:09:50 +0100 [thread overview]
Message-ID: <b1c93f8e-5c4c-9ad8-e9b3-a846fe9f5661@redhat.com> (raw)
In-Reply-To: <20210309002741.85057-5-j@getutm.app>
Hi Joelle,
On 3/9/21 1:27 AM, Joelle van Dyne wrote:
> Replace Windows specific macro with a more generic feature detection
> macro. Allows slirp smb feature to be disabled manually as well.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> configure | 26 +++++++++++++++++++++++---
> meson.build | 2 +-
> net/slirp.c | 16 ++++++++--------
> 3 files changed, 32 insertions(+), 12 deletions(-)
Hmm v1 had: Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
did you change something to not include Samuel A-b tag?
next prev parent reply other threads:[~2021-03-09 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 0:27 [PATCH v2 0/4] Disable unsupported features on iOS hosts Joelle van Dyne
2021-03-09 0:27 ` [PATCH v2 1/4] block: feature detection for host block support Joelle van Dyne
2021-03-09 0:27 ` [PATCH v2 2/4] block: check for sys/disk.h Joelle van Dyne
2021-03-09 11:25 ` Peter Maydell
2021-03-09 12:09 ` Philippe Mathieu-Daudé
2021-03-09 0:27 ` [PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Joelle van Dyne
2021-03-09 11:31 ` Peter Maydell
2021-03-09 0:27 ` [PATCH v2 4/4] slirp: feature detection for smbd Joelle van Dyne
2021-03-09 10:10 ` Peter Maydell
2021-03-09 12:12 ` Philippe Mathieu-Daudé
2021-03-09 14:09 ` Philippe Mathieu-Daudé [this message]
2021-03-09 18:11 ` Joelle van Dyne
2021-03-10 1:13 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c93f8e-5c4c-9ad8-e9b3-a846fe9f5661@redhat.com \
--to=philmd@redhat.com \
--cc=j@getutm.app \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).