Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

[Het Gala <het.gala@nutanix.com>]

Sorry Markus, firstly I thought its just regarding qapi documentation so 
migration maintainers might not be needed ? but then I realize the 
commit message fails to specify that

IIRC, you are one of the maintainers for qapi. So, just cc'd to you, but 
you are right, should have done to migration maintainers also.

Have we got the wrong Fabiano here ? Isn't Fabiano Rosas the migration 
maintainer ?

cc'ing to Fabiano Rosas too.

On 21/02/24 12:27 pm, Markus Armbruster wrote:
> You neglected to cc: migration maintainers; I'm doing that for you now.
>
> Peter or Fabiano, please have a look.
>
> Het Gala <het.gala@nutanix.com> writes:
>
>> Signed-off-by: Het Gala <het.gala@nutanix.com>
>> ---
>>   qapi/migration.json | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/qapi/migration.json b/qapi/migration.json
>> index 5a565d9b8d..5756e650b0 100644
>> --- a/qapi/migration.json
>> +++ b/qapi/migration.json
>> @@ -1728,6 +1728,7 @@
>>   #
>>   # -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } }
>>   # <- { "return": {} }
>> +#
>>   # -> { "execute": "migrate",
>>   #      "arguments": {
>>   #          "channels": [ { "channel-type": "main",
>> @@ -1796,19 +1797,19 @@
>>   #
>>   #     3. The uri format is the same as for -incoming
>>   #
>> -#     5. For now, number of migration streams is restricted to one,
>> +#     4. For now, number of migration streams is restricted to one,
>>   #        i.e number of items in 'channels' list is just 1.
>>   #
>> -#     4. The 'uri' and 'channels' arguments are mutually exclusive;
>> +#     5. The 'uri' and 'channels' arguments are mutually exclusive;
>>   #        exactly one of the two should be present.
>>   #
>>   # Example:
>>   #
>>   # -> { "execute": "migrate-incoming",
>> -#      "arguments": { "uri": "tcp::4446" } }
>> +#      "arguments": { "uri": "tcp:0:4446" } }
>>   # <- { "return": {} }
>>   #
>> -# -> { "execute": "migrate",
>> +# -> { "execute": "migrate-incoming",
>>   #      "arguments": {
>>   #          "channels": [ { "channel-type": "main",
>>   #                          "addr": { "transport": "socket",
>> @@ -1817,7 +1818,7 @@
>>   #                                    "port": "1050" } } ] } }
>>   # <- { "return": {} }
>>   #
>> -# -> { "execute": "migrate",
>> +# -> { "execute": "migrate-incoming",
>>   #      "arguments": {
>>   #          "channels": [ { "channel-type": "main",
>>   #                          "addr": { "transport": "exec",
>> @@ -1825,7 +1826,7 @@
>>   #                                              "/some/sock" ] } } ] } }
>>   # <- { "return": {} }
>>   #
>> -# -> { "execute": "migrate",
>> +# -> { "execute": "migrate-incoming",
>>   #      "arguments": {
>>   #          "channels": [ { "channel-type": "main",
>>   #                          "addr": { "transport": "rdma",

Regards,

Het Gala