From: Steven Sistare <steven.sistare@oracle.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cedric Le Goater <clg@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>
Subject: Re: [PATCH V3 09/13] migration: notifier error checking
Date: Mon, 12 Feb 2024 10:37:47 -0500 [thread overview]
Message-ID: <b1db8a19-42b0-4016-9ee5-8a0afad1eef1@oracle.com> (raw)
In-Reply-To: <3e610f67-415f-4cc8-9ef5-5f9587414271@redhat.com>
On 2/12/2024 4:24 AM, David Hildenbrand wrote:
> On 08.02.24 19:54, Steve Sistare wrote:
>> Check the status returned by migration notifiers and report errors.
>> If notifiers fail, call the notifiers again so they can clean up.
>
> IIUC, if any of the notifiers will actually start to fail, say, during MIG_EVENT_PRECOPY_SETUP, you will call MIG_EVENT_PRECOPY_FAILED on all notifiers.
>
> That will include notifiers that have never seen a MIG_EVENT_PRECOPY_SETUP call.
Correct.
> Is that what we expect notifiers to be able to deal with? Can we document that?
The notifiers have always needed to handle failure without knowing the previous migration
states, and are robust about unwinding their own internal state. I will document it.
Thanks for all the RBs.
- Steve
next prev parent reply other threads:[~2024-02-12 15:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 18:53 [PATCH V3 00/13] allow cpr-reboot for vfio Steve Sistare
2024-02-08 18:53 ` [PATCH V3 01/13] notify: pass error to notifier with return Steve Sistare
2024-02-12 9:08 ` David Hildenbrand
2024-02-08 18:53 ` [PATCH V3 02/13] migration: remove error from notifier data Steve Sistare
2024-02-12 9:08 ` David Hildenbrand
2024-02-08 18:53 ` [PATCH V3 03/13] migration: convert to NotifierWithReturn Steve Sistare
2024-02-12 9:10 ` David Hildenbrand
2024-02-08 18:53 ` [PATCH V3 04/13] migration: MigrationEvent for notifiers Steve Sistare
2024-02-12 9:11 ` David Hildenbrand
2024-02-20 6:38 ` Peter Xu
2024-02-08 18:53 ` [PATCH V3 05/13] migration: remove postcopy_after_devices Steve Sistare
2024-02-20 6:42 ` Peter Xu
2024-02-08 18:53 ` [PATCH V3 06/13] migration: MigrationNotifyFunc Steve Sistare
2024-02-12 9:14 ` David Hildenbrand
2024-02-20 6:48 ` Peter Xu
2024-02-08 18:54 ` [PATCH V3 07/13] migration: per-mode notifiers Steve Sistare
2024-02-12 9:16 ` David Hildenbrand
2024-02-20 6:51 ` Peter Xu
2024-02-08 18:54 ` [PATCH V3 08/13] migration: refactor migrate_fd_connect failures Steve Sistare
2024-02-12 9:17 ` David Hildenbrand
2024-02-08 18:54 ` [PATCH V3 09/13] migration: notifier error checking Steve Sistare
2024-02-12 9:24 ` David Hildenbrand
2024-02-12 15:37 ` Steven Sistare [this message]
2024-02-20 7:12 ` Peter Xu
2024-02-20 22:12 ` Steven Sistare
2024-02-08 18:54 ` [PATCH V3 10/13] migration: stop vm for cpr Steve Sistare
2024-02-20 7:33 ` Peter Xu
2024-02-20 22:19 ` Steven Sistare
2024-02-21 21:20 ` Steven Sistare
2024-02-22 9:12 ` Peter Xu
2024-02-22 9:30 ` Peter Xu
2024-02-22 13:29 ` Steven Sistare
2024-02-21 21:23 ` Steven Sistare
2024-02-22 9:03 ` Peter Xu
2024-02-22 13:24 ` Steven Sistare
2024-02-08 18:54 ` [PATCH V3 11/13] vfio: register container " Steve Sistare
2024-02-08 18:54 ` [PATCH V3 12/13] vfio: allow cpr-reboot migration if suspended Steve Sistare
2024-02-21 18:32 ` Steven Sistare
2024-02-08 18:54 ` [PATCH V3 13/13] migration: update cpr-reboot description Steve Sistare
2024-02-20 7:49 ` [PATCH V3 00/13] allow cpr-reboot for vfio Peter Xu
2024-02-20 22:32 ` Steven Sistare
2024-02-21 2:13 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1db8a19-42b0-4016-9ee5-8a0afad1eef1@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).