* Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document
2017-11-10 9:03 [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document Gerd Hoffmann
@ 2017-11-10 15:24 ` Stefan Hajnoczi
2017-11-10 16:14 ` Roman Kagan
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-11-10 15:24 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
On Fri, Nov 10, 2017 at 10:03:54AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document
2017-11-10 9:03 [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document Gerd Hoffmann
2017-11-10 15:24 ` Stefan Hajnoczi
@ 2017-11-10 16:14 ` Roman Kagan
2017-11-15 15:17 ` Christian Borntraeger
2017-11-15 15:26 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Roman Kagan @ 2017-11-10 16:14 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On Fri, Nov 10, 2017 at 10:03:54AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 8b847e279b..e2b159aa3d 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -108,7 +108,7 @@ for arch in $ARCHLIST; do
> if [ $arch = x86 ]; then
> cat <<-EOF >"$output/include/standard-headers/asm-x86/hyperv.h"
> /* this is a temporary placeholder until kvm_para.h stops including it */
> - EOF
> +EOF
> cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_x32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-x86/"
Ugh, indeed, the minus sign after << causes the shell to strip only
preceding tabs, not spaces. Apparently I expanded the tabs after I
tested the script to work...
Fixes: 40bf8e9aede0f9105a9e1e4aaf17b20aaa55f9a0
Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>
Thanks,
Roman.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document
2017-11-10 9:03 [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document Gerd Hoffmann
2017-11-10 15:24 ` Stefan Hajnoczi
2017-11-10 16:14 ` Roman Kagan
@ 2017-11-15 15:17 ` Christian Borntraeger
2017-11-15 15:26 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2017-11-15 15:17 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 11/10/2017 10:03 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 8b847e279b..e2b159aa3d 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -108,7 +108,7 @@ for arch in $ARCHLIST; do
> if [ $arch = x86 ]; then
> cat <<-EOF >"$output/include/standard-headers/asm-x86/hyperv.h"
> /* this is a temporary placeholder until kvm_para.h stops including it */
> - EOF
> +EOF
> cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_x32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-x86/"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document
2017-11-10 9:03 [Qemu-devel] [PATCH] fix scripts/update-linux-headers.sh here document Gerd Hoffmann
` (2 preceding siblings ...)
2017-11-15 15:17 ` Christian Borntraeger
@ 2017-11-15 15:26 ` Paolo Bonzini
3 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2017-11-15 15:26 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 10/11/2017 10:03, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> scripts/update-linux-headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 8b847e279b..e2b159aa3d 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -108,7 +108,7 @@ for arch in $ARCHLIST; do
> if [ $arch = x86 ]; then
> cat <<-EOF >"$output/include/standard-headers/asm-x86/hyperv.h"
> /* this is a temporary placeholder until kvm_para.h stops including it */
> - EOF
> +EOF
> cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_x32.h" "$output/linux-headers/asm-x86/"
> cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-x86/"
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread