[PATCH 00/12] Minor fixes for Arm documentation

[PATCH 00/12] Minor fixes for Arm documentation

[Pierrick Bouvier]

Reviewed following things:
- system/arm/cpu-features (options)
- system/arm/virt (options)
- boards documented and listed with -machine help (arm and aarch64)
- grep object_class_property_set_description hw/arm: ensure all options are
  documented
- reviewed boards description
- reviewed all Arm features (FEAT_) from: https://developer.arm.com/documentation/109697/2024_09/Feature-descriptions/

The Arm section of the documentation is in very good shape, and this series only
has minors fixes.

Pierrick Bouvier (12):
  docs/system/arm/emulation: mention armv9
  docs/system/arm/emulation: fix typo in feature name
  docs/system/arm/emulation: add FEAT_SSBS2
  target/arm/tcg/: fix typo in FEAT name
  docs/system/arm/: add FEAT_MTE_ASYNC
  docs/system/arm/: add FEAT_DoubleLock
  docs/system/arm/fby35: update link to product page
  docs/system/arm/orangepi: update links
  docs/system/arm/fby35: document execute-in-place property
  docs/system/arm/xlnx-versal-virt: document ospi-flash property
  docs/system/arm/virt: document missing properties
  docs/system/arm/aspeed: add missing model supermicrox11spi-bmc

 docs/bypass-iommu.txt                |  2 ++
 docs/system/arm/aspeed.rst           |  7 ++++---
 docs/system/arm/emulation.rst        | 11 +++++++----
 docs/system/arm/fby35.rst            |  5 ++++-
 docs/system/arm/orangepi.rst         |  4 ++--
 docs/system/arm/virt.rst             | 15 +++++++++++++++
 docs/system/arm/xlnx-versal-virt.rst |  3 +++
 target/arm/tcg/cpu32.c               |  2 +-
 8 files changed, 38 insertions(+), 11 deletions(-)

-- 
2.39.5

[PATCH 01/12] docs/system/arm/emulation: mention armv9

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/emulation.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index a2a388f0919..2956c22a1b7 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -3,8 +3,8 @@
 A-profile CPU architecture support
 ==================================
 
-QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7 and
-Armv8 versions of the A-profile architecture. It also has support for
+QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7,
+Armv8 and Armv9 versions of the A-profile architecture. It also has support for
 the following architecture extensions:
 
 - FEAT_AA32BF16 (AArch32 BFloat16 instructions)
@@ -153,7 +153,7 @@ the following architecture extensions:
 - FEAT_XNX (Translation table stage 2 Unprivileged Execute-never)
 
 For information on the specifics of these extensions, please refer
-to the `Armv8-A Arm Architecture Reference Manual
+to the `Arm Architecture Reference Manual for A-profile architecture
 <https://developer.arm.com/documentation/ddi0487/latest>`_.
 
 When a specific named CPU is being emulated, only those features which
-- 
2.39.5

[PATCH 02/12] docs/system/arm/emulation: fix typo in feature name

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/emulation.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 2956c22a1b7..af613b9c8b8 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -88,7 +88,7 @@ the following architecture extensions:
 - FEAT_LSE2 (Large System Extensions v2)
 - FEAT_LVA (Large Virtual Address space)
 - FEAT_MixedEnd (Mixed-endian support)
-- FEAT_MixdEndEL0 (Mixed-endian support at EL0)
+- FEAT_MixedEndEL0 (Mixed-endian support at EL0)
 - FEAT_MOPS (Standardization of memory operations)
 - FEAT_MTE (Memory Tagging Extension)
 - FEAT_MTE2 (Memory Tagging Extension)
-- 
2.39.5

[PATCH 03/12] docs/system/arm/emulation: add FEAT_SSBS2

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/emulation.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index af613b9c8b8..50d0250b1eb 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -137,6 +137,7 @@ the following architecture extensions:
 - FEAT_SVE2 (Scalable Vector Extension version 2)
 - FEAT_SPECRES (Speculation restriction instructions)
 - FEAT_SSBS (Speculative Store Bypass Safe)
+- FEAT_SSBS2 (MRS and MSR instructions for SSBS version 2)
 - FEAT_TGran16K (Support for 16KB memory translation granule size at stage 1)
 - FEAT_TGran4K (Support for 4KB memory translation granule size at stage 1)
 - FEAT_TGran64K (Support for 64KB memory translation granule size at stage 1)
-- 
2.39.5

[PATCH 04/12] target/arm/tcg/: fix typo in FEAT name

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 target/arm/tcg/cpu32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/tcg/cpu32.c b/target/arm/tcg/cpu32.c
index 20c2737f17b..4e589b747e4 100644
--- a/target/arm/tcg/cpu32.c
+++ b/target/arm/tcg/cpu32.c
@@ -71,7 +71,7 @@ void aa32_max_features(ARMCPU *cpu)
     cpu->isar.id_mmfr5 = t;
 
     t = cpu->isar.id_pfr0;
-    t = FIELD_DP32(t, ID_PFR0, CSV2, 2);          /* FEAT_CVS2 */
+    t = FIELD_DP32(t, ID_PFR0, CSV2, 2);          /* FEAT_CSV2 */
     t = FIELD_DP32(t, ID_PFR0, DIT, 1);           /* FEAT_DIT */
     t = FIELD_DP32(t, ID_PFR0, RAS, 1);           /* FEAT_RAS */
     cpu->isar.id_pfr0 = t;
-- 
2.39.5

[PATCH 05/12] docs/system/arm/: add FEAT_MTE_ASYNC

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/emulation.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 50d0250b1eb..47f5123a31d 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -94,6 +94,7 @@ the following architecture extensions:
 - FEAT_MTE2 (Memory Tagging Extension)
 - FEAT_MTE3 (MTE Asymmetric Fault Handling)
 - FEAT_MTE_ASYM_FAULT (Memory tagging asymmetric faults)
+- FEAT_MTE_ASYNC (Asynchronous reporting of Tag Check Fault)
 - FEAT_NMI (Non-maskable Interrupt)
 - FEAT_NV (Nested Virtualization)
 - FEAT_NV2 (Enhanced nested virtualization support)
-- 
2.39.5

[PATCH 06/12] docs/system/arm/: add FEAT_DoubleLock

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/emulation.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 47f5123a31d..38534dcdd32 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -37,6 +37,7 @@ the following architecture extensions:
 - FEAT_CSV3 (Cache speculation variant 3)
 - FEAT_DGH (Data gathering hint)
 - FEAT_DIT (Data Independent Timing instructions)
+- FEAT_DoubleLock (Double Lock)
 - FEAT_DPB (DC CVAP instruction)
 - FEAT_DPB2 (DC CVADP instruction)
 - FEAT_Debugv8p1 (Debug with VHE)
-- 
2.39.5

[PATCH 07/12] docs/system/arm/fby35: update link to product page

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/fby35.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/system/arm/fby35.rst b/docs/system/arm/fby35.rst
index 742b887d44c..bf6da6baa2a 100644
--- a/docs/system/arm/fby35.rst
+++ b/docs/system/arm/fby35.rst
@@ -12,7 +12,7 @@ include various compute accelerators (video, inferencing, etc). At the moment,
 only the first server slot's BIC is included.
 
 Yosemite v3.5 is itself a sled which fits into a 40U chassis, and 3 sleds
-can be fit into a chassis. See `here <https://www.opencompute.org/products/423/wiwynn-yosemite-v3-server>`__
+can be fit into a chassis. See `here <https://www.opencompute.org/products-chiplets/237/wiwynn-yosemite-v3-server>`__
 for an example.
 
 In this generation, the BMC is an AST2600 and each BIC is an AST1030. The BMC
-- 
2.39.5

[PATCH 08/12] docs/system/arm/orangepi: update links

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/orangepi.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
index 9afa54213b0..db87e81fec4 100644
--- a/docs/system/arm/orangepi.rst
+++ b/docs/system/arm/orangepi.rst
@@ -119,7 +119,7 @@ Orange Pi PC images
 Note that the mainline kernel does not have a root filesystem. You may provide it
 with an official Orange Pi PC image from the official website:
 
-  http://www.orangepi.org/downloadresources/
+  http://www.orangepi.org/html/serviceAndSupport/index.html
 
 Another possibility is to run an Armbian image for Orange Pi PC which
 can be downloaded from:
@@ -213,7 +213,7 @@ including the Orange Pi PC. NetBSD 9.0 is known to work best for the Orange Pi P
 board and provides a fully working system with serial console, networking and storage.
 For the Orange Pi PC machine, get the 'evbarm-earmv7hf' based image from:
 
-  https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
+  https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
 
 The image requires manually installing U-Boot in the image. Build U-Boot with
 the orangepi_pc_defconfig configuration as described in the previous section.
-- 
2.39.5

[PATCH 09/12] docs/system/arm/fby35: document execute-in-place property

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/fby35.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/system/arm/fby35.rst b/docs/system/arm/fby35.rst
index bf6da6baa2a..ed9faef363c 100644
--- a/docs/system/arm/fby35.rst
+++ b/docs/system/arm/fby35.rst
@@ -45,3 +45,6 @@ process starts.
     $ screen /dev/tty0 # In a separate TMUX pane, terminal window, etc.
     $ screen /dev/tty1
     $ (qemu) c		   # Start the boot process once screen is setup.
+
+This machine model supports emulation of the boot from the CEO flash device by
+setting option ``execute-in-place``.
-- 
2.39.5

[PATCH 10/12] docs/system/arm/xlnx-versal-virt: document ospi-flash property

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/xlnx-versal-virt.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.rst
index 0bafc76469d..c5f35f28e4f 100644
--- a/docs/system/arm/xlnx-versal-virt.rst
+++ b/docs/system/arm/xlnx-versal-virt.rst
@@ -178,6 +178,9 @@ Run the following at the U-Boot prompt:
   fdt set /chosen/dom0 reg <0x00000000 0x40000000 0x0 0x03100000>
   booti 30000000 - 20000000
 
+It's possible to change the OSPI flash model emulated by using the machine model
+option ``ospi-flash``.
+
 BBRAM File Backend
 """"""""""""""""""
 BBRAM can have an optional file backend, which must be a seekable
-- 
2.39.5

[PATCH 11/12] docs/system/arm/virt: document missing properties

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/bypass-iommu.txt    |  2 ++
 docs/system/arm/virt.rst | 15 +++++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/docs/bypass-iommu.txt b/docs/bypass-iommu.txt
index e6677bddd32..62818e44ed9 100644
--- a/docs/bypass-iommu.txt
+++ b/docs/bypass-iommu.txt
@@ -1,3 +1,5 @@
+.. _bypass_iommu:
+
 BYPASS IOMMU PROPERTY
 =====================
 
diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst
index 11ceb898264..d3d21499ff5 100644
--- a/docs/system/arm/virt.rst
+++ b/docs/system/arm/virt.rst
@@ -169,10 +169,17 @@ iommu
   ``smmuv3``
     Create an SMMUv3
 
+default-bus-bypass-iommu
+  Set ``on``/``off`` to enable/disable `bypass_iommu <bypass_iommu>`_ for
+  default root bus.
+
 ras
   Set ``on``/``off`` to enable/disable reporting host memory errors to a guest
   using ACPI and guest external abort exceptions. The default is off.
 
+acpi
+  Set ``on``/``off``/``auto`` to enable/disable ACPI.
+
 dtb-randomness
   Set ``on``/``off`` to pass random seeds via the guest DTB
   rng-seed and kaslr-seed nodes (in both "/chosen" and
@@ -186,6 +193,14 @@ dtb-randomness
 dtb-kaslr-seed
   A deprecated synonym for dtb-randomness.
 
+x-oem-id
+  Set string (up to 6 bytes) to override the default value of field OEMID in ACPI
+  table header.
+
+x-oem-table-id
+  Set string (up to 8 bytes) to override the default value of field OEM Table ID
+  in ACPI table header.
+
 Linux guest kernel configuration
 """"""""""""""""""""""""""""""""
 
-- 
2.39.5

[PATCH 12/12] docs/system/arm/aspeed: add missing model supermicrox11spi-bmc

[Pierrick Bouvier]

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 docs/system/arm/aspeed.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst
index 2e9ba12f7ae..d17fe7a4fc8 100644
--- a/docs/system/arm/aspeed.rst
+++ b/docs/system/arm/aspeed.rst
@@ -1,5 +1,5 @@
-Aspeed family boards (``ast2500-evb``, ``ast2600-evb``, ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``, ``fby35-bmc``, ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``, ``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``, ``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``, ``supermicrox11-bmc``, ``tiogapass-bmc``, ``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
-========================================================================================================================================================================================================================================================================================================================================================================================================
+Aspeed family boards (``ast2500-evb``, ``ast2600-evb``, ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``, ``fby35-bmc``, ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``, ``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``, ``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``, ``supermicrox11-bmc``, ``supermicrox11spi-bmc``, ``tiogapass-bmc``, ``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
+==================================================================================================================================================================================================================================================================================================================================================================================================================================
 
 The QEMU Aspeed machines model BMCs of various OpenPOWER systems and
 Aspeed evaluation boards. They are based on different releases of the
@@ -15,7 +15,8 @@ AST2400 SoC based machines :
 
 - ``palmetto-bmc``         OpenPOWER Palmetto POWER8 BMC
 - ``quanta-q71l-bmc``      OpenBMC Quanta BMC
-- ``supermicrox11-bmc``    Supermicro X11 BMC
+- ``supermicrox11-bmc``    Supermicro X11 BMC (ARM926EJ-S)
+- ``supermicrox11spi-bmc``    Supermicro X11 SPI BMC (ARM1176)
 
 AST2500 SoC based machines :
 
-- 
2.39.5

Re: [PATCH 04/12] target/arm/tcg/: fix typo in FEAT name

[Philippe Mathieu-Daudé]

On 22/11/24 23:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/arm/tcg/cpu32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 07/12] docs/system/arm/fby35: update link to product page

[Philippe Mathieu-Daudé]

On 22/11/24 23:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/fby35.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 01/12] docs/system/arm/emulation: mention armv9

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/emulation.rst | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
> 
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index a2a388f0919..2956c22a1b7 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -3,8 +3,8 @@
>   A-profile CPU architecture support
>   ==================================
>   
> -QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7 and
> -Armv8 versions of the A-profile architecture. It also has support for
> +QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7,
> +Armv8 and Armv9 versions of the A-profile architecture. It also has support for
>   the following architecture extensions:
>   
>   - FEAT_AA32BF16 (AArch32 BFloat16 instructions)
> @@ -153,7 +153,7 @@ the following architecture extensions:
>   - FEAT_XNX (Translation table stage 2 Unprivileged Execute-never)
>   
>   For information on the specifics of these extensions, please refer
> -to the `Armv8-A Arm Architecture Reference Manual
> +to the `Arm Architecture Reference Manual for A-profile architecture
>   <https://developer.arm.com/documentation/ddi0487/latest>`_.
>   
>   When a specific named CPU is being emulated, only those features which

Re: [PATCH 02/12] docs/system/arm/emulation: fix typo in feature name

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/emulation.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> 
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index 2956c22a1b7..af613b9c8b8 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -88,7 +88,7 @@ the following architecture extensions:
>   - FEAT_LSE2 (Large System Extensions v2)
>   - FEAT_LVA (Large Virtual Address space)
>   - FEAT_MixedEnd (Mixed-endian support)
> -- FEAT_MixdEndEL0 (Mixed-endian support at EL0)
> +- FEAT_MixedEndEL0 (Mixed-endian support at EL0)
>   - FEAT_MOPS (Standardization of memory operations)
>   - FEAT_MTE (Memory Tagging Extension)
>   - FEAT_MTE2 (Memory Tagging Extension)

Re: [PATCH 03/12] docs/system/arm/emulation: add FEAT_SSBS2

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/emulation.rst | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> 
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index af613b9c8b8..50d0250b1eb 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -137,6 +137,7 @@ the following architecture extensions:
>   - FEAT_SVE2 (Scalable Vector Extension version 2)
>   - FEAT_SPECRES (Speculation restriction instructions)
>   - FEAT_SSBS (Speculative Store Bypass Safe)
> +- FEAT_SSBS2 (MRS and MSR instructions for SSBS version 2)
>   - FEAT_TGran16K (Support for 16KB memory translation granule size at stage 1)
>   - FEAT_TGran4K (Support for 4KB memory translation granule size at stage 1)
>   - FEAT_TGran64K (Support for 64KB memory translation granule size at stage 1)

Re: [PATCH 04/12] target/arm/tcg/: fix typo in FEAT name

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/arm/tcg/cpu32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Oops.  :-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> 
> diff --git a/target/arm/tcg/cpu32.c b/target/arm/tcg/cpu32.c
> index 20c2737f17b..4e589b747e4 100644
> --- a/target/arm/tcg/cpu32.c
> +++ b/target/arm/tcg/cpu32.c
> @@ -71,7 +71,7 @@ void aa32_max_features(ARMCPU *cpu)
>       cpu->isar.id_mmfr5 = t;
>   
>       t = cpu->isar.id_pfr0;
> -    t = FIELD_DP32(t, ID_PFR0, CSV2, 2);          /* FEAT_CVS2 */
> +    t = FIELD_DP32(t, ID_PFR0, CSV2, 2);          /* FEAT_CSV2 */
>       t = FIELD_DP32(t, ID_PFR0, DIT, 1);           /* FEAT_DIT */
>       t = FIELD_DP32(t, ID_PFR0, RAS, 1);           /* FEAT_RAS */
>       cpu->isar.id_pfr0 = t;

Re: [PATCH 05/12] docs/system/arm/: add FEAT_MTE_ASYNC

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/emulation.rst | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> 
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index 50d0250b1eb..47f5123a31d 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -94,6 +94,7 @@ the following architecture extensions:
>   - FEAT_MTE2 (Memory Tagging Extension)
>   - FEAT_MTE3 (MTE Asymmetric Fault Handling)
>   - FEAT_MTE_ASYM_FAULT (Memory tagging asymmetric faults)
> +- FEAT_MTE_ASYNC (Asynchronous reporting of Tag Check Fault)
>   - FEAT_NMI (Non-maskable Interrupt)
>   - FEAT_NV (Nested Virtualization)
>   - FEAT_NV2 (Enhanced nested virtualization support)

Re: [PATCH 07/12] docs/system/arm/fby35: update link to product page

[Richard Henderson]

On 11/22/24 16:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/fby35.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/docs/system/arm/fby35.rst b/docs/system/arm/fby35.rst
> index 742b887d44c..bf6da6baa2a 100644
> --- a/docs/system/arm/fby35.rst
> +++ b/docs/system/arm/fby35.rst
> @@ -12,7 +12,7 @@ include various compute accelerators (video, inferencing, etc). At the moment,
>   only the first server slot's BIC is included.
>   
>   Yosemite v3.5 is itself a sled which fits into a 40U chassis, and 3 sleds
> -can be fit into a chassis. See `here <https://www.opencompute.org/products/423/wiwynn-yosemite-v3-server>`__
> +can be fit into a chassis. See `here <https://www.opencompute.org/products-chiplets/237/wiwynn-yosemite-v3-server>`__
>   for an example.
>   
>   In this generation, the BMC is an AST2600 and each BIC is an AST1030. The BMC

Re: [PATCH 12/12] docs/system/arm/aspeed: add missing model supermicrox11spi-bmc

[Andrew Jeffery]

On Fri, 2024-11-22 at 14:50 -0800, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Re: [PATCH 11/12] docs/system/arm/virt: document missing properties

[Peter Maydell]

On Fri, 22 Nov 2024 at 22:52, Pierrick Bouvier
<pierrick.bouvier@linaro.org> wrote:
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>  docs/bypass-iommu.txt    |  2 ++
>  docs/system/arm/virt.rst | 15 +++++++++++++++
>  2 files changed, 17 insertions(+)
>
> diff --git a/docs/bypass-iommu.txt b/docs/bypass-iommu.txt
> index e6677bddd32..62818e44ed9 100644
> --- a/docs/bypass-iommu.txt
> +++ b/docs/bypass-iommu.txt
> @@ -1,3 +1,5 @@
> +.. _bypass_iommu:
> +

This is a .txt file -- adding rST markup to it won't do anything :-)

(It's one of the remaining legacy .txt files that we haven't
yet converted to .rst and moved to the right place in the
documentation. The .txt files in the /docs/ directory are
mostly the awkward ones to convert because they are a mishmash
of internal info about the implementation and stuff that is user
facing, that needs to be pulled apart by somebody with some
familiarity with the feature and moved into the right places,
or in some cases simply deleted as unnecessary.)

>  BYPASS IOMMU PROPERTY
>  =====================
>
> diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst
> index 11ceb898264..d3d21499ff5 100644
> --- a/docs/system/arm/virt.rst
> +++ b/docs/system/arm/virt.rst
> @@ -169,10 +169,17 @@ iommu
>    ``smmuv3``
>      Create an SMMUv3
>
> +default-bus-bypass-iommu
> +  Set ``on``/``off`` to enable/disable `bypass_iommu <bypass_iommu>`_ for
> +  default root bus.
> +
>  ras
>    Set ``on``/``off`` to enable/disable reporting host memory errors to a guest
>    using ACPI and guest external abort exceptions. The default is off.
>
> +acpi
> +  Set ``on``/``off``/``auto`` to enable/disable ACPI.
> +
>  dtb-randomness
>    Set ``on``/``off`` to pass random seeds via the guest DTB
>    rng-seed and kaslr-seed nodes (in both "/chosen" and
> @@ -186,6 +193,14 @@ dtb-randomness
>  dtb-kaslr-seed
>    A deprecated synonym for dtb-randomness.
>
> +x-oem-id
> +  Set string (up to 6 bytes) to override the default value of field OEMID in ACPI
> +  table header.
> +
> +x-oem-table-id
> +  Set string (up to 8 bytes) to override the default value of field OEM Table ID
> +  in ACPI table header.

Do we have a policy about whether we should explicitly note that
x- options are not ABI-stable when we document them?

thanks
-- PMM

Re: [PATCH 00/12] Minor fixes for Arm documentation

[Peter Maydell]

On Fri, 22 Nov 2024 at 22:52, Pierrick Bouvier
<pierrick.bouvier@linaro.org> wrote:
>
> Reviewed following things:
> - system/arm/cpu-features (options)
> - system/arm/virt (options)
> - boards documented and listed with -machine help (arm and aarch64)
> - grep object_class_property_set_description hw/arm: ensure all options are
>   documented
> - reviewed boards description
> - reviewed all Arm features (FEAT_) from: https://developer.arm.com/documentation/109697/2024_09/Feature-descriptions/
>
> The Arm section of the documentation is in very good shape, and this series only
> has minors fixes.
>
> Pierrick Bouvier (12):
>   docs/system/arm/emulation: mention armv9
>   docs/system/arm/emulation: fix typo in feature name
>   docs/system/arm/emulation: add FEAT_SSBS2
>   target/arm/tcg/: fix typo in FEAT name
>   docs/system/arm/: add FEAT_MTE_ASYNC
>   docs/system/arm/: add FEAT_DoubleLock
>   docs/system/arm/fby35: update link to product page
>   docs/system/arm/orangepi: update links
>   docs/system/arm/fby35: document execute-in-place property
>   docs/system/arm/xlnx-versal-virt: document ospi-flash property
>   docs/system/arm/virt: document missing properties
>   docs/system/arm/aspeed: add missing model supermicrox11spi-bmc

I have taken the reviewed ones of these (1-7 and 12)
so I can put them in for rc2.

thanks
-- PMM

Re: [PATCH 00/12] Minor fixes for Arm documentation

[Pierrick Bouvier]

On 11/26/24 08:24, Peter Maydell wrote:
> On Fri, 22 Nov 2024 at 22:52, Pierrick Bouvier
> <pierrick.bouvier@linaro.org> wrote:
>>
>> Reviewed following things:
>> - system/arm/cpu-features (options)
>> - system/arm/virt (options)
>> - boards documented and listed with -machine help (arm and aarch64)
>> - grep object_class_property_set_description hw/arm: ensure all options are
>>    documented
>> - reviewed boards description
>> - reviewed all Arm features (FEAT_) from: https://developer.arm.com/documentation/109697/2024_09/Feature-descriptions/
>>
>> The Arm section of the documentation is in very good shape, and this series only
>> has minors fixes.
>>
>> Pierrick Bouvier (12):
>>    docs/system/arm/emulation: mention armv9
>>    docs/system/arm/emulation: fix typo in feature name
>>    docs/system/arm/emulation: add FEAT_SSBS2
>>    target/arm/tcg/: fix typo in FEAT name
>>    docs/system/arm/: add FEAT_MTE_ASYNC
>>    docs/system/arm/: add FEAT_DoubleLock
>>    docs/system/arm/fby35: update link to product page
>>    docs/system/arm/orangepi: update links
>>    docs/system/arm/fby35: document execute-in-place property
>>    docs/system/arm/xlnx-versal-virt: document ospi-flash property
>>    docs/system/arm/virt: document missing properties
>>    docs/system/arm/aspeed: add missing model supermicrox11spi-bmc
> 
> I have taken the reviewed ones of these (1-7 and 12)
> so I can put them in for rc2.
> 
> thanks
> -- PMM

Thanks Peter.

Re: [PATCH 11/12] docs/system/arm/virt: document missing properties

[Pierrick Bouvier]

On 11/25/24 09:02, Peter Maydell wrote:
> On Fri, 22 Nov 2024 at 22:52, Pierrick Bouvier
> <pierrick.bouvier@linaro.org> wrote:
>>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>   docs/bypass-iommu.txt    |  2 ++
>>   docs/system/arm/virt.rst | 15 +++++++++++++++
>>   2 files changed, 17 insertions(+)
>>
>> diff --git a/docs/bypass-iommu.txt b/docs/bypass-iommu.txt
>> index e6677bddd32..62818e44ed9 100644
>> --- a/docs/bypass-iommu.txt
>> +++ b/docs/bypass-iommu.txt
>> @@ -1,3 +1,5 @@
>> +.. _bypass_iommu:
>> +
> 
> This is a .txt file -- adding rST markup to it won't do anything :-)
> 
> (It's one of the remaining legacy .txt files that we haven't
> yet converted to .rst and moved to the right place in the
> documentation. The .txt files in the /docs/ directory are
> mostly the awkward ones to convert because they are a mishmash
> of internal info about the implementation and stuff that is user
> facing, that needs to be pulled apart by somebody with some
> familiarity with the feature and moved into the right places,
> or in some cases simply deleted as unnecessary.)
> 

Oops.
I was very unlucky because it's the only place where I did the mistake 
to use an anonymous link >`_, instead of ref link, so I missed it.
Adding too many rst links is bad for your (mental) health :)

I'll update the bypass_iommu link to refer to the file (upstream) instead.

>>   BYPASS IOMMU PROPERTY
>>   =====================
>>
>> diff --git a/docs/system/arm/virt.rst b/docs/system/arm/virt.rst
>> index 11ceb898264..d3d21499ff5 100644
>> --- a/docs/system/arm/virt.rst
>> +++ b/docs/system/arm/virt.rst
>> @@ -169,10 +169,17 @@ iommu
>>     ``smmuv3``
>>       Create an SMMUv3
>>
>> +default-bus-bypass-iommu
>> +  Set ``on``/``off`` to enable/disable `bypass_iommu <bypass_iommu>`_ for
>> +  default root bus.
>> +
>>   ras
>>     Set ``on``/``off`` to enable/disable reporting host memory errors to a guest
>>     using ACPI and guest external abort exceptions. The default is off.
>>
>> +acpi
>> +  Set ``on``/``off``/``auto`` to enable/disable ACPI.
>> +
>>   dtb-randomness
>>     Set ``on``/``off`` to pass random seeds via the guest DTB
>>     rng-seed and kaslr-seed nodes (in both "/chosen" and
>> @@ -186,6 +193,14 @@ dtb-randomness
>>   dtb-kaslr-seed
>>     A deprecated synonym for dtb-randomness.
>>
>> +x-oem-id
>> +  Set string (up to 6 bytes) to override the default value of field OEMID in ACPI
>> +  table header.
>> +
>> +x-oem-table-id
>> +  Set string (up to 8 bytes) to override the default value of field OEM Table ID
>> +  in ACPI table header.
> 
> Do we have a policy about whether we should explicitly note that
> x- options are not ABI-stable when we document them?
>

I noticed that x-rme was documented, so took it as an implicit yes.

 From the commit that introduce them [1], it seems to be more a 
workaround than proper experimental options, which is a bit debatable to 
be honest.

If you prefer to not include x-oem-* options, let me know.

[1] 
https://gitlab.com/qemu-project/qemu/-/commit/90a66f48471975fd46f1caab1574679f0a0ef74b

> thanks
> -- PMM

Re: [PATCH 08/12] docs/system/arm/orangepi: update links

[Pierrick Bouvier]

On 11/22/24 14:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/orangepi.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
> index 9afa54213b0..db87e81fec4 100644
> --- a/docs/system/arm/orangepi.rst
> +++ b/docs/system/arm/orangepi.rst
> @@ -119,7 +119,7 @@ Orange Pi PC images
>   Note that the mainline kernel does not have a root filesystem. You may provide it
>   with an official Orange Pi PC image from the official website:
>   
> -  http://www.orangepi.org/downloadresources/
> +  http://www.orangepi.org/html/serviceAndSupport/index.html
>   
>   Another possibility is to run an Armbian image for Orange Pi PC which
>   can be downloaded from:
> @@ -213,7 +213,7 @@ including the Orange Pi PC. NetBSD 9.0 is known to work best for the Orange Pi P
>   board and provides a fully working system with serial console, networking and storage.
>   For the Orange Pi PC machine, get the 'evbarm-earmv7hf' based image from:
>   
> -  https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
> +  https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
>   
>   The image requires manually installing U-Boot in the image. Build U-Boot with
>   the orangepi_pc_defconfig configuration as described in the previous section.

Regarding our conversation on IRC with Peter, is seems that google 
reference www.orangepi.org only through http, and not https.
As the host is currently down, I'm not sure if https really works or 
not. So maybe it's better to stick with http for now.

Re: [PATCH 08/12] docs/system/arm/orangepi: update links

[Niek Linnenbank]

[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]

Hello Pierrick,

Thanks for including orangepi documentation in your updates.

On Tue, Nov 26, 2024 at 8:00 PM Pierrick Bouvier <
pierrick.bouvier@linaro.org> wrote:

> On 11/22/24 14:50, Pierrick Bouvier wrote:
> > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> > ---
> >   docs/system/arm/orangepi.rst | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
> > index 9afa54213b0..db87e81fec4 100644
> > --- a/docs/system/arm/orangepi.rst
> > +++ b/docs/system/arm/orangepi.rst
> > @@ -119,7 +119,7 @@ Orange Pi PC images
> >   Note that the mainline kernel does not have a root filesystem. You may
> provide it
> >   with an official Orange Pi PC image from the official website:
> >
> > -  http://www.orangepi.org/downloadresources/
> > +  http://www.orangepi.org/html/serviceAndSupport/index.html
> >
> >   Another possibility is to run an Armbian image for Orange Pi PC which
> >   can be downloaded from:
> > @@ -213,7 +213,7 @@ including the Orange Pi PC. NetBSD 9.0 is known to
> work best for the Orange Pi P
> >   board and provides a fully working system with serial console,
> networking and storage.
> >   For the Orange Pi PC machine, get the 'evbarm-earmv7hf' based image
> from:
> >
> > -
> https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
> > +
> https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
> >
> >   The image requires manually installing U-Boot in the image. Build
> U-Boot with
> >   the orangepi_pc_defconfig configuration as described in the previous
> section.
>
> Regarding our conversation on IRC with Peter, is seems that google
> reference www.orangepi.org only through http, and not https.
> As the host is currently down, I'm not sure if https really works or
> not. So maybe it's better to stick with http for now.
>

Yes, I also just noted that the orangepi.org website is not responding.
However earlier this week, I was able to load the new URL above to the
official website.
Perhaps it is only temporary down, but we can only be sure once it comes
back up.
The NetBSD image URL is OK, ive also verified that the hash is the same.

So for me:

Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>

Regards,
Niek

-- 
Niek Linnenbank

[-- Attachment #2: Type: text/html, Size: 3927 bytes --]

Re: [PATCH 08/12] docs/system/arm/orangepi: update links

[Pierrick Bouvier]

On 11/22/24 14:50, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/system/arm/orangepi.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
> index 9afa54213b0..db87e81fec4 100644
> --- a/docs/system/arm/orangepi.rst
> +++ b/docs/system/arm/orangepi.rst
> @@ -119,7 +119,7 @@ Orange Pi PC images
>   Note that the mainline kernel does not have a root filesystem. You may provide it
>   with an official Orange Pi PC image from the official website:
>   
> -  http://www.orangepi.org/downloadresources/
> +  http://www.orangepi.org/html/serviceAndSupport/index.html
>   
>   Another possibility is to run an Armbian image for Orange Pi PC which
>   can be downloaded from:
> @@ -213,7 +213,7 @@ including the Orange Pi PC. NetBSD 9.0 is known to work best for the Orange Pi P
>   board and provides a fully working system with serial console, networking and storage.
>   For the Orange Pi PC machine, get the 'evbarm-earmv7hf' based image from:
>   
> -  https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
> +  https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz
>   
>   The image requires manually installing U-Boot in the image. Build U-Boot with
>   the orangepi_pc_defconfig configuration as described in the previous section.

www.orangepi.org website is available again, and after checking, they 
don't support https. So this change is correct, and we should stick to http.