Re: [PATCH v7 8/8] tests/qtest:ast2700-gpio-test: Add GPIO test case for AST2700

[Thomas Huth <thuth@redhat.com>]

On 01/10/2024 04.43, Jamin Lin wrote:
> Add GPIO test cases to test output and input pins from A0 to D7 for AST2700.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/qtest/ast2700-gpio-test.c | 95 +++++++++++++++++++++++++++++++++
>   tests/qtest/meson.build         |  3 ++
>   2 files changed, 98 insertions(+)
>   create mode 100644 tests/qtest/ast2700-gpio-test.c
> 
> diff --git a/tests/qtest/ast2700-gpio-test.c b/tests/qtest/ast2700-gpio-test.c
...
> +int main(int argc, char **argv)
> +{
> +    g_test_init(&argc, &argv, NULL);
> +
> +    qtest_add_func("/ast2700/gpio/input_pins", test_2700_input_pins);
> +    qtest_add_func("/ast2700/gpio/output_pins", test_2700_output_pins);
> +
> +    return g_test_run();
> +}
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 310865e49c..e1b62d34d8 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -209,6 +209,8 @@ qtests_aspeed = \
>     ['aspeed_hace-test',
>      'aspeed_smc-test',
>      'aspeed_gpio-test']
> +qtests_aspeed64 = \
> +  ['ast2700-gpio-test']
>   
>   qtests_stm32l4x5 = \
>     ['stm32l4x5_exti-test',
> @@ -247,6 +249,7 @@ qtests_aarch64 = \
>     (config_all_devices.has_key('CONFIG_RASPI') ? ['bcm2835-dma-test', 'bcm2835-i2c-test'] : []) +  \
>     (config_all_accel.has_key('CONFIG_TCG') and                                            \
>      config_all_devices.has_key('CONFIG_TPM_TIS_I2C') ? ['tpm-tis-i2c-test'] : []) + \
> +  (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed64 : []) + \
>     ['arm-cpu-features',
>      'numa-test',
>      'boot-serial-test',

Thanks, that looks way simpler now!

Reviewed-by: Thomas Huth <thuth@redhat.com>