From: Stefan Berger <stefanb@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alexander von Gluck IV" <kallisti5@unixzen.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"David CARLIER" <devnexen@gmail.com>,
kraxel@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku
Date: Sat, 14 Nov 2020 18:44:07 -0500 [thread overview]
Message-ID: <b1fab224-f6e0-7178-2e33-41f24b0c667a@linux.ibm.com> (raw)
In-Reply-To: <20201114165137.15379-3-thuth@redhat.com>
On 11/14/20 11:51 AM, Thomas Huth wrote:
> Compilation of pc-bios/optionrom fails on Haiku with:
>
> BUILD pvh.img
> ld: pvh_main.o: in function `pvh_load_kernel':
> pc-bios/optionrom/pvh_main.c:73: undefined reference to `GLOBAL_OFFSET_TABLE_'
> Makefile:57: recipe for target 'pvh.img' failed
> make[1]: *** [pvh.img] Error 1
>
> Let's simply disable it, like it is already done on macOS and Solaris.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index a273a93377..c0acda164d 100755
> --- a/configure
> +++ b/configure
> @@ -5842,7 +5842,7 @@ fi
> roms=
> if { test "$cpu" = "i386" || test "$cpu" = "x86_64"; } && \
> test "$targetos" != "Darwin" && test "$targetos" != "SunOS" && \
> - test "$softmmu" = yes ; then
> + test "$targetos" != "Haiku" && test "$softmmu" = yes ; then
> # Different host OS linkers have different ideas about the name of the ELF
> # emulation. Linux and OpenBSD/amd64 use 'elf_i386'; FreeBSD uses the _fbsd
> # variant; OpenBSD/i386 uses the _obsd variant; and Windows uses i386pe.
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
next prev parent reply other threads:[~2020-11-14 23:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:51 [PATCH for-5.2? 0/4] Fix build failures on Haiku Thomas Huth
2020-11-14 16:51 ` [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build Thomas Huth
2020-11-14 23:44 ` Stefan Berger
2020-11-14 16:51 ` [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku Thomas Huth
2020-11-14 23:44 ` Stefan Berger [this message]
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h Thomas Huth
2020-11-14 16:56 ` 罗勇刚(Yonggang Luo)
2020-11-15 14:00 ` Thomas Huth
2020-11-15 14:34 ` Paolo Bonzini
2020-11-15 15:18 ` Thomas Huth
2020-11-14 23:43 ` Stefan Berger
2020-11-15 15:23 ` [PATCH v2 " Thomas Huth
2020-11-16 11:51 ` Philippe Mathieu-Daudé
2020-11-14 16:51 ` [PATCH 4/4] tests/vm: Add Haiku test based on their vagrant images Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fab224-f6e0-7178-2e33-41f24b0c667a@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=devnexen@gmail.com \
--cc=f4bug@amsat.org \
--cc=kallisti5@unixzen.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).