From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virt: Fix broken indentation
Date: Wed, 12 Dec 2018 10:34:51 +0100 [thread overview]
Message-ID: <b1fbe55c-6deb-5401-b4ed-9c4d6484ac55@redhat.com> (raw)
In-Reply-To: <20181212003147.29604-1-ehabkost@redhat.com>
On 2018-12-12 01:31, Eduardo Habkost wrote:
> I introduced indentation using tabs instead of spaces in another
> commit. Peter reported the problem, and I failed to fix that
> before sending my pull request.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: 951597607696 ("virt: Eliminate separate instance_init functions")
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> hw/arm/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 17f1b49d11..5b678237b7 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1854,7 +1854,7 @@ static const TypeInfo virt_machine_info = {
> .instance_size = sizeof(VirtMachineState),
> .class_size = sizeof(VirtMachineClass),
> .class_init = virt_machine_class_init,
> - .instance_init = virt_instance_init,
> + .instance_init = virt_instance_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_HOTPLUG_HANDLER },
> { }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-12-12 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 0:31 [Qemu-devel] [PATCH] virt: Fix broken indentation Eduardo Habkost
2018-12-12 9:34 ` Thomas Huth [this message]
2018-12-12 11:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fbe55c-6deb-5401-b4ed-9c4d6484ac55@redhat.com \
--to=thuth@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).