From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
John Ferlan <jferlan@redhat.com>,
Jiri Denemark <jdenemar@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters
Date: Thu, 2 Mar 2017 10:08:01 -0600 [thread overview]
Message-ID: <b2152672-8e78-3e82-0623-fc88118e901e@redhat.com> (raw)
In-Reply-To: <20170302123746.9694-3-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On 03/02/2017 06:37 AM, Daniel P. Berrange wrote:
> Currently the query-migrate-parameters command will omit reporting
> of the tls-creds & tls-hostname parameters if their value is NULL.
> This makes it impossible for an app to detect if these parameters
> are supported by QEMU, without trying to actually set them and
> catching the error. Since the code is treating "" and NULL as
> equivalent, we can simply always report these values and give them
> a value of "". This allows apps like libvirt to detect the fact
> that these parameters are supported by QEMU.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> migration/migration.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
The .c changes look fine, but I agree that we want to document the
special-case of "" in the .json file. Looking forward to v3.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-03-02 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 12:37 [Qemu-devel] [PATCH v2 0/2] migration: fixes to handling tls-hostname/tls-creds Daniel P. Berrange
2017-03-02 12:37 ` [Qemu-devel] [PATCH v2 1/2] migration: allow clearing migration string parameters Daniel P. Berrange
2017-03-02 16:09 ` Eric Blake
2017-03-02 12:37 ` [Qemu-devel] [PATCH v2 2/2] migration: always report tls-creds & tls-hostname migrate parameters Daniel P. Berrange
2017-03-02 13:19 ` John Ferlan
2017-03-02 13:23 ` Daniel P. Berrange
2017-03-02 16:08 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2152672-8e78-3e82-0623-fc88118e901e@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jdenemar@redhat.com \
--cc=jferlan@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).