* [PATCH] tests/qtest/virtio-ccw: Fix device presence checking
@ 2024-01-06 13:01 Samuel Tardieu
2024-01-06 15:26 ` Philippe Mathieu-Daudé
2024-01-08 11:06 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Tardieu @ 2024-01-06 13:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Thomas Huth, Laurent Vivier, Samuel Tardieu
An apparent copy-paste error tests for the presence of the
virtio-rng-ccw device in order to perform tests on the virtio-scsi-ccw
device.
Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
tests/qtest/virtio-ccw-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c
index f4f5858b84..7a5357c212 100644
--- a/tests/qtest/virtio-ccw-test.c
+++ b/tests/qtest/virtio-ccw-test.c
@@ -85,7 +85,7 @@ int main(int argc, char **argv)
if (qtest_has_device("virtio-rng-ccw")) {
qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
}
- if (qtest_has_device("virtio-rng-ccw")) {
+ if (qtest_has_device("virtio-scsi-ccw")) {
qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest/virtio-ccw: Fix device presence checking
2024-01-06 13:01 [PATCH] tests/qtest/virtio-ccw: Fix device presence checking Samuel Tardieu
@ 2024-01-06 15:26 ` Philippe Mathieu-Daudé
2024-01-08 11:06 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-06 15:26 UTC (permalink / raw)
To: Samuel Tardieu, qemu-devel; +Cc: Paolo Bonzini, Thomas Huth, Laurent Vivier
On 6/1/24 14:01, Samuel Tardieu wrote:
> An apparent copy-paste error tests for the presence of the
> virtio-rng-ccw device in order to perform tests on the virtio-scsi-ccw
> device.
>
Fixes: 65331bf5d1 ("tests/qtest: Check for virtio-ccw devices before
using them")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
> tests/qtest/virtio-ccw-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c
> index f4f5858b84..7a5357c212 100644
> --- a/tests/qtest/virtio-ccw-test.c
> +++ b/tests/qtest/virtio-ccw-test.c
> @@ -85,7 +85,7 @@ int main(int argc, char **argv)
> if (qtest_has_device("virtio-rng-ccw")) {
> qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
> }
> - if (qtest_has_device("virtio-rng-ccw")) {
> + if (qtest_has_device("virtio-scsi-ccw")) {
> qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
> qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest/virtio-ccw: Fix device presence checking
2024-01-06 13:01 [PATCH] tests/qtest/virtio-ccw: Fix device presence checking Samuel Tardieu
2024-01-06 15:26 ` Philippe Mathieu-Daudé
@ 2024-01-08 11:06 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-01-08 11:06 UTC (permalink / raw)
To: Samuel Tardieu, qemu-devel; +Cc: Paolo Bonzini, Laurent Vivier
On 06/01/2024 14.01, Samuel Tardieu wrote:
> An apparent copy-paste error tests for the presence of the
> virtio-rng-ccw device in order to perform tests on the virtio-scsi-ccw
> device.
>
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
> tests/qtest/virtio-ccw-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c
> index f4f5858b84..7a5357c212 100644
> --- a/tests/qtest/virtio-ccw-test.c
> +++ b/tests/qtest/virtio-ccw-test.c
> @@ -85,7 +85,7 @@ int main(int argc, char **argv)
> if (qtest_has_device("virtio-rng-ccw")) {
> qtest_add_func("/virtio/rng/nop", virtio_rng_nop);
> }
> - if (qtest_has_device("virtio-rng-ccw")) {
> + if (qtest_has_device("virtio-scsi-ccw")) {
> qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop);
> qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug);
> }
Ooops, thanks for catching it!
I'll queue the patch for my next pull request.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-08 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-06 13:01 [PATCH] tests/qtest/virtio-ccw: Fix device presence checking Samuel Tardieu
2024-01-06 15:26 ` Philippe Mathieu-Daudé
2024-01-08 11:06 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).