From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A4C8C3DA6E for ; Mon, 8 Jan 2024 11:06:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMnSu-000147-TU; Mon, 08 Jan 2024 06:06:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMnSt-00012S-Fx for qemu-devel@nongnu.org; Mon, 08 Jan 2024 06:06:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMnSV-0002ga-Ep for qemu-devel@nongnu.org; Mon, 08 Jan 2024 06:06:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704711978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tdyVklxi+KZbGIUEbkXg5wd8A+h/gjnKT9s6rw/9tG4=; b=HLvem79Os/8ilEQDYePzXS9BIZgAYstOFhl1B28mUygTpBHO1nxbfAFi2lUwZZSe13pb8n IlAOMpZiOgknf0yWaH6L37R8RpXKVGCVRB2cRZvVKDfpZkrHNfYwRJcJQFki51GXZU0cMB 0FOvgh7u9y3VYC5i219DwNOfUhCoqGI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-HI12GIsWNnu_7RrPNVsnjQ-1; Mon, 08 Jan 2024 06:06:17 -0500 X-MC-Unique: HI12GIsWNnu_7RrPNVsnjQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-680c8d21542so49026596d6.0 for ; Mon, 08 Jan 2024 03:06:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704711977; x=1705316777; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tdyVklxi+KZbGIUEbkXg5wd8A+h/gjnKT9s6rw/9tG4=; b=oNWO2KN6NkXjzRwHNNYzWohbS1m6AFyBXVJQBFdzaA0j+jUqLdSiL/xht8N4T9f8qQ Y8+54s5CxUmsUlW74qX9uIqz3yuT1OZjcR46YY8GOYdAbvUK0AtE1Gl+0Lyvu9qHvMcg jXb7yyzuBL279ZRAeZEGgyFZHvMSUbvWXldNlyafWCaVN2+EN+OLeNDkery3aOveRFzg X8nNAC7yR+LvQUYwpWIql3t1UEerk2S22szwnq0dtp4j5IffgKcl2Cy4mvsxe+qXYMRl 6eK2yEB8TL28dfsRUwl62sWWJaD4+dEhO6xeD/2LiCKhV5f6MX3+htdDHAjgJfBEjwu0 afng== X-Gm-Message-State: AOJu0YyN97mb4SgLLlyANQFi5GdRP9krYYF29wGcieyENbVkAZliVKT/ siXKcEgnsCgq1YxxnvsLmka2EZGGhRPzqVp7Wvg1cZtjwgXrXfrqdF81tTS0zZn1Wul7kn0723J kQPFx868p0AUwXAbTR2krk7Q= X-Received: by 2002:a05:6214:250c:b0:680:cc00:3f49 with SMTP id gf12-20020a056214250c00b00680cc003f49mr9213614qvb.2.1704711977057; Mon, 08 Jan 2024 03:06:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/AgBqBTfcte3OpiEC+ox55l3GjWiOzu9+IGTFebEl3qUlJmkbLBeNy01AtFTNQZmwzFjVsw== X-Received: by 2002:a05:6214:250c:b0:680:cc00:3f49 with SMTP id gf12-20020a056214250c00b00680cc003f49mr9213606qvb.2.1704711976828; Mon, 08 Jan 2024 03:06:16 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-179-78.web.vodafone.de. [109.43.179.78]) by smtp.gmail.com with ESMTPSA id lw2-20020a05621457c200b006810b5cf63dsm308122qvb.67.2024.01.08.03.06.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 03:06:16 -0800 (PST) Message-ID: Date: Mon, 8 Jan 2024 12:06:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tests/qtest/virtio-ccw: Fix device presence checking Content-Language: en-US To: Samuel Tardieu , qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier References: <20240106130121.1244993-1-sam@rfc1149.net> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240106130121.1244993-1-sam@rfc1149.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.098, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 06/01/2024 14.01, Samuel Tardieu wrote: > An apparent copy-paste error tests for the presence of the > virtio-rng-ccw device in order to perform tests on the virtio-scsi-ccw > device. > > Signed-off-by: Samuel Tardieu > --- > tests/qtest/virtio-ccw-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/virtio-ccw-test.c b/tests/qtest/virtio-ccw-test.c > index f4f5858b84..7a5357c212 100644 > --- a/tests/qtest/virtio-ccw-test.c > +++ b/tests/qtest/virtio-ccw-test.c > @@ -85,7 +85,7 @@ int main(int argc, char **argv) > if (qtest_has_device("virtio-rng-ccw")) { > qtest_add_func("/virtio/rng/nop", virtio_rng_nop); > } > - if (qtest_has_device("virtio-rng-ccw")) { > + if (qtest_has_device("virtio-scsi-ccw")) { > qtest_add_func("/virtio/scsi/nop", virtio_scsi_nop); > qtest_add_func("/virtio/scsi/hotplug", virtio_scsi_hotplug); > } Ooops, thanks for catching it! I'll queue the patch for my next pull request. Thomas