From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DFAC6379D for ; Mon, 23 Nov 2020 13:45:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D80A2075A for ; Mon, 23 Nov 2020 13:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WR8Xrkdj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D80A2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khC9Y-0007sq-3O for qemu-devel@archiver.kernel.org; Mon, 23 Nov 2020 08:45:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khC8S-0007Il-Sm for qemu-devel@nongnu.org; Mon, 23 Nov 2020 08:44:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khC8Q-0005Aa-Ma for qemu-devel@nongnu.org; Mon, 23 Nov 2020 08:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606139040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r9ulyd/aGvLWjeTtJcZKRZQiU6ckzZTDQqhJ5Y4/A60=; b=WR8XrkdjuJyOWSLBI7z3zJktPeed0HgcqYrKewF7ETNF1GNpKdVDoDAlvOc05r5dBWCKqZ k/nP0NrsBHgOUJn8SPVoPrso3qb8xXVn5m4sipPawF2XTYS8Gvnu1nkwAGchQRIfyo2q/f jRLfafExYJa2sE3/N320Hze5A4+7cbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-zaTCoH9sPNmFn4-4deQj9g-1; Mon, 23 Nov 2020 08:43:57 -0500 X-MC-Unique: zaTCoH9sPNmFn4-4deQj9g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A79C1868406; Mon, 23 Nov 2020 13:43:56 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-143.gru2.redhat.com [10.97.116.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4B0910021AA; Mon, 23 Nov 2020 13:43:53 +0000 (UTC) Subject: Re: [PATCH v1 3/6] tests/avocado: clean-up socket directory after run To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20201117173635.29101-1-alex.bennee@linaro.org> <20201117173635.29101-4-alex.bennee@linaro.org> <3bc76afb-e459-1324-d1ef-aba53faf6220@redhat.com> <87tutgo29p.fsf@linaro.org> From: Wainer dos Santos Moschetta Message-ID: Date: Mon, 23 Nov 2020 10:43:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87tutgo29p.fsf@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/23/20 6:23 AM, Alex Bennée wrote: > Wainer dos Santos Moschetta writes: > >> On 11/17/20 2:36 PM, Alex Bennée wrote: >>> Previously we were leaving temporary directories behind. While the >>> QEMUMachine does make efforts to clean up after itself the directory >>> belongs to the calling function. We use TemporaryDirectory to wrap >>> this although we explicitly clear the reference in tearDown() as it >>> doesn't get cleaned up otherwise. >> This patch fixes the problem introduced on patch 02 of this series. > It didn't introduce the problem in patch 2, it just moved it. The > mkdtemp() was never cleaned up before. True. My bad. - Wainer > >>> Signed-off-by: Alex Bennée >>> --- >>> tests/acceptance/avocado_qemu/__init__.py | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py >>> index 3033b2cabe..bf54e419da 100644 >>> --- a/tests/acceptance/avocado_qemu/__init__.py >>> +++ b/tests/acceptance/avocado_qemu/__init__.py >>> @@ -171,8 +171,8 @@ class Test(avocado.Test): >>> self.cancel("No QEMU binary defined or found in the build tree") >>> >>> def _new_vm(self, *args): >>> - sd = tempfile.mkdtemp(prefix="avocado_qemu_sock_") >>> - vm = QEMUMachine(self.qemu_bin, sock_dir=sd) >>> + self._sd = tempfile.TemporaryDirectory(prefix="avo_qemu_sock_") >> Double-checking that you really meant "avo" or if your fingers forgot to >> type the remaining letters. :) > Hmm yeah I should probably just be consistent with the name in both > patches. Anyway, Reviewed-by: Wainer dos Santos Moschetta > >> - Wainer >> >>> + vm = QEMUMachine(self.qemu_bin, sock_dir=self._sd.name) >>> if args: >>> vm.add_args(*args) >>> return vm >>> @@ -193,6 +193,7 @@ class Test(avocado.Test): >>> def tearDown(self): >>> for vm in self._vms.values(): >>> vm.shutdown() >>> + self._sd = None >>> >>> def fetch_asset(self, name, >>> asset_hash=None, algorithm=None, >