From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] target/xtensa: fix meson.build rule for xtensa cores
Date: Sat, 3 Apr 2021 08:12:03 -0700 [thread overview]
Message-ID: <b23e0784-5dea-fe6d-faa3-bf36cdd8071d@linaro.org> (raw)
In-Reply-To: <20210403040338.18929-1-jcmvbkbc@gmail.com>
On 4/2/21 9:03 PM, Max Filippov wrote:
> import_core.sh tries to change Makefile.objs when importing new xtensa
> core, but that file no longer exists. Rewrite meson.build rule to pick
> up all source files that match core-*.c pattern and drop commands that
> change Makefile.objs.
>
> Cc:qemu-stable@nongnu.org # v5.2.0
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> ---
> target/xtensa/import_core.sh | 3 ---
> target/xtensa/meson.build | 13 ++++---------
> 2 files changed, 4 insertions(+), 12 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-04-03 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 4:03 [PATCH] target/xtensa: fix meson.build rule for xtensa cores Max Filippov
2021-04-03 15:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23e0784-5dea-fe6d-faa3-bf36cdd8071d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).