From: Eric Auger <eauger@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Andrew Jones <drjones@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Alistair Francis <alistair.francis@wdc.com>,
wanghaibin.wang@huawei.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v9 8/8] tests/data/acpi/virt: Update the empty expected file for PPTT
Date: Thu, 21 Oct 2021 09:04:55 +0200 [thread overview]
Message-ID: <b23e91b7-e484-6f96-83c0-57fd27c7fc7e@redhat.com> (raw)
In-Reply-To: <20211020142125.7516-9-wangyanan55@huawei.com>
Hi Yanan,
On 10/20/21 4:21 PM, Yanan Wang wrote:
> Run ./tests/data/acpi/rebuild-expected-aml.sh from build directory
> to update PPTT binary. Also empty bios-tables-test-allowed-diff.h.
>
> Disassembled output of the updated new file:
>
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20180810 (64-bit version)
> * Copyright (c) 2000 - 2018 Intel Corporation
> *
> * Disassembly of tests/data/acpi/virt/PPTT, Fri Oct 8 10:12:32 2021
> *
> * ACPI Data Table [PPTT]
> *
> * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> */
>
> [000h 0000 4] Signature : "PPTT" [Processor Properties Topology Table]
> [004h 0004 4] Table Length : 0000004C
> [008h 0008 1] Revision : 02
> [009h 0009 1] Checksum : A8
> [00Ah 0010 6] Oem ID : "BOCHS "
> [010h 0016 8] Oem Table ID : "BXPC "
> [018h 0024 4] Oem Revision : 00000001
> [01Ch 0028 4] Asl Compiler ID : "BXPC"
> [020h 0032 4] Asl Compiler Revision : 00000001
>
> [024h 0036 1] Subtable Type : 00 [Processor Hierarchy Node]
> [025h 0037 1] Length : 14
> [026h 0038 2] Reserved : 0000
> [028h 0040 4] Flags (decoded below) : 00000001
> Physical package : 1
> ACPI Processor ID valid : 0
> [02Ch 0044 4] Parent : 00000000
> [030h 0048 4] ACPI Processor ID : 00000000
> [034h 0052 4] Private Resource Number : 00000000
>
> [038h 0056 1] Subtable Type : 00 [Processor Hierarchy Node]
> [039h 0057 1] Length : 14
> [03Ah 0058 2] Reserved : 0000
> [03Ch 0060 4] Flags (decoded below) : 0000000A
> Physical package : 0
> ACPI Processor ID valid : 1
> [040h 0064 4] Parent : 00000024
> [044h 0068 4] ACPI Processor ID : 00000000
> [048h 0072 4] Private Resource Number : 00000000
>
> Raw Table Data: Length 76 (0x4C)
>
> 0000: 50 50 54 54 4C 00 00 00 02 A8 42 4F 43 48 53 20 // PPTTL.....BOCHS
> 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
> 0020: 01 00 00 00 00 14 00 00 01 00 00 00 00 00 00 00 // ................
> 0030: 00 00 00 00 00 00 00 00 00 14 00 00 0A 00 00 00 // ................
> 0040: 24 00 00 00 00 00 00 00 00 00 00 00 // $...........
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> tests/data/acpi/virt/PPTT | Bin 0 -> 76 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> 2 files changed, 1 deletion(-)
>
> diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT
> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..7a1258ecf123555b24462c98ccbb76b4ac1d0c2b 100644
> GIT binary patch
> literal 76
> zcmV-S0JHy4P*hY*00002s6tOeNK+s}SWrVCARr(C0000&SWrU&000006aWAL00000
> i0000000000000006aWAU0000a00000000000001^0tW#A
>
> literal 0
> KcmV+b0RR6000031
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index cb143a55a6..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,2 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/virt/PPTT",
>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
next prev parent reply other threads:[~2021-10-21 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 14:21 [PATCH v9 0/8] hw/arm/virt: Introduce cpu topology support Yanan Wang
2021-10-20 14:21 ` [PATCH v9 1/8] hw/arm/virt: Only describe cpu topology since virt-6.2 Yanan Wang
2021-10-20 14:21 ` [PATCH v9 2/8] device_tree: Add qemu_fdt_add_path Yanan Wang
2021-10-20 14:21 ` [PATCH v9 3/8] hw/arm/virt: Add cpu-map to device tree Yanan Wang
2021-10-20 14:21 ` [PATCH v9 4/8] hw/acpi/aml-build: Add Processor hierarchy node structure Yanan Wang
2021-10-20 14:21 ` [PATCH v9 5/8] hw/acpi/aml-build: Add PPTT table Yanan Wang
2021-10-21 7:03 ` Eric Auger
2021-10-20 14:21 ` [PATCH v9 6/8] tests/data/acpi/virt: Add an empty expected file for PPTT Yanan Wang
2021-10-20 14:21 ` [PATCH v9 7/8] hw/arm/virt-acpi-build: Generate PPTT table Yanan Wang
2021-10-20 14:21 ` [PATCH v9 8/8] tests/data/acpi/virt: Update the empty expected file for PPTT Yanan Wang
2021-10-21 7:04 ` Eric Auger [this message]
2021-10-21 15:04 ` [PATCH v9 0/8] hw/arm/virt: Introduce cpu topology support Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b23e91b7-e484-6f96-83c0-57fd27c7fc7e@redhat.com \
--to=eauger@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).