From: Fiona Ebner <f.ebner@proxmox.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com,
xiechanglong.d@gmail.com, wencongyang2@huawei.com,
hreitz@redhat.com, kwolf@redhat.com, jsnow@redhat.com,
den@virtuozzo.com, alexander.ivanov@virtuozzo.com
Subject: Re: [PATCH v3 3/5] block/copy-before-write: create block_copy bitmap in filter node
Date: Fri, 8 Mar 2024 16:49:14 +0100 [thread overview]
Message-ID: <b246ef09-f945-4857-a083-9de168b8e7bd@proxmox.com> (raw)
In-Reply-To: <20240228141501.455989-4-vsementsov@yandex-team.ru>
Am 28.02.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy:
> Currently block_copy creates copy_bitmap in source node. But that is in
> bad relation with .independent_close=true of copy-before-write filter:
> source node may be detached and removed before .bdrv_close() handler
> called, which should call block_copy_state_free(), which in turn should
> remove copy_bitmap.
>
> That's all not ideal: it would be better if internal bitmap of
> block-copy object is not attached to any node. But that is not possible
> now.
>
> The simplest solution is just create copy_bitmap in filter node, where
> anyway two other bitmaps are created.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2024-03-08 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 14:14 [PATCH v3 0/5] backup: discard-source parameter Vladimir Sementsov-Ogievskiy
2024-02-28 14:14 ` [PATCH v3 1/5] block/copy-before-write: fix permission Vladimir Sementsov-Ogievskiy
2024-02-28 14:14 ` [PATCH v3 2/5] block/copy-before-write: support unligned snapshot-discard Vladimir Sementsov-Ogievskiy
2024-03-08 15:49 ` Fiona Ebner
2024-02-28 14:14 ` [PATCH v3 3/5] block/copy-before-write: create block_copy bitmap in filter node Vladimir Sementsov-Ogievskiy
2024-03-08 15:49 ` Fiona Ebner [this message]
2024-02-28 14:15 ` [PATCH v3 4/5] qapi: blockdev-backup: add discard-source parameter Vladimir Sementsov-Ogievskiy
2024-03-08 15:49 ` Fiona Ebner
2024-02-28 14:15 ` [PATCH v3 5/5] iotests: add backup-discard-source Vladimir Sementsov-Ogievskiy
2024-03-08 15:49 ` Fiona Ebner
2024-03-08 15:49 ` [PATCH v3 0/5] backup: discard-source parameter Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b246ef09-f945-4857-a083-9de168b8e7bd@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).