Re: [PATCH 3/5] hw/arm/omap1: Convert information printfs to tracepoints

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 27/2/25 18:01, Peter Maydell wrote:
> The omap1 code uses raw printf() statements to print information
> about some events; convert these to tracepoints.
> 
> In particular, this will stop the functional test for the sx1
> from printing the not-very-helpful note
>   "omap_clkm_write: clocking scheme set to synchronous scalable"
> to the test's default.log.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/arm/omap1.c      | 27 ++++++++++++++-------------
>   hw/arm/trace-events |  7 +++++++
>   2 files changed, 21 insertions(+), 13 deletions(-)


> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
> index 7790db780e0..70b137a6cfd 100644
> --- a/hw/arm/trace-events
> +++ b/hw/arm/trace-events
> @@ -1,5 +1,12 @@
>   # See docs/devel/tracing.rst for syntax documentation.
>   
> +# omap1.c
> +omap1_clocking_scheme(const char *scheme) "omap1 CLKM: clocking scheme set to %s"
> +omap1_backlight(int output) "omap1 PWL: backlight now at %d/256"

omap1_pwl_...

> +omap1_buzz(int freq) "omap1 PWT: %dHz buzz on"
> +omap1_silence(void) "omap1 PWT: buzzer silenced"

omap1_pwt_...

> +omap1_led(const char *onoff) "omap1 LPG: LED is %s"

omap1_lpg_led

Regardless:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>