From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Timothy Pearson <tpearson@raptorengineering.com>,
Riku Voipio <riku.voipio@iki.fi>, Allan Wirth <awirth@akamai.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select
Date: Sun, 4 Sep 2016 15:49:22 +0200 [thread overview]
Message-ID: <b24c7a7d-2505-25fe-a290-ccdaa9e220b4@vivier.eu> (raw)
In-Reply-To: <CAFEAcA_wGCCowa3hLD02xRuE3O1YhmP=8Jk1Rgskd8hheh158Q@mail.gmail.com>
Le 11/07/2016 à 18:59, Peter Maydell a écrit :
> On 8 July 2016 at 00:17, Laurent Vivier <laurent@vivier.eu> wrote:
>> TARGET_NR_select can have three different implementations:
>>
>> 1- to always return -ENOSYS
>>
>> microblaze, ppc, ppc64
>>
>> -> TARGET_WANT_NI_OLD_SELECT
>>
>> 2- to take parameters from a structure pointed by arg1
>> (kernel sys_old_select)
>>
>> i386, arm, m68k
>>
>> -> TARGET_WANT_OLD_SYS_SELECT
>>
>> 3- to take parameters from arg[1-5]
>> (kernel sys_select)
>>
>> x86_64, alpha, s390x,
>> cris, sparc, sparc64
>>
>> Some (new) architectures don't define NR_select,
>>
>> 4- but only NR__newselect with sys_select:
>>
>> mips, mips64, sh
>>
>> 5- don't define NR__newselect, and use pselect6 syscall:
>>
>> aarch64, openrisc, tilegx, unicore32
>>
>> Reported-by: Timothy Pearson <tpearson@raptorengineering.com>
>> Reported-by: Allan Wirth <awirth@akamai.com>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
It seems this one has missed 2.7 window, perhaps it can queued for 2.8?
Laurent
next prev parent reply other threads:[~2016-09-04 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 23:17 [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select Laurent Vivier
2016-07-08 0:55 ` Wirth, Allan
2016-07-11 16:59 ` Peter Maydell
2016-09-04 13:49 ` Laurent Vivier [this message]
2016-09-22 4:25 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b24c7a7d-2505-25fe-a290-ccdaa9e220b4@vivier.eu \
--to=laurent@vivier.eu \
--cc=awirth@akamai.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).