From: Thomas Huth <thuth@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Fabiano Rosas" <farosas@suse.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M
Date: Fri, 1 Mar 2024 20:12:48 +0100 [thread overview]
Message-ID: <b2585806-d05c-4eef-9a2b-15bf2c68e2c0@redhat.com> (raw)
In-Reply-To: <20240129081835.137726-1-thuth@redhat.com>
On 29/01/2024 09.18, Thomas Huth wrote:
> We've got a switch to disable v7m code since a long time - but it
> currently cannot be disabled since linking then fails due to missing
> functions. But thanks to the clean-ups that have been done during the
> past years, it's not that difficult anymore to finally make it possible
> to disable CONFIG_ARM_V7M: We just have to move some v7m-related code
> out of cpu32.c to a separate file (that we only compile if the switch
> CONFIG_ARM_V7M is enabled) and make sure to use the stub functions in
> m_helper.c if it is disabled. Then we can finally remove the hard-coded
> "select ARM_V7M" from the Kconfig file.
>
> v2:
> - Updated a comment
> - Avoid #ifdef in cpu-v7m.c, handle it via meson.build instead
>
> Thomas Huth (3):
> target/arm: Move v7m-related code from cpu32.c into a separate file
> target/arm/tcg/m_helper.c: Include the full helpers only with
> CONFIG_ARM_V7M
> target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M
>
> target/arm/tcg/cpu-v7m.c | 290 +++++++++++++++++++++++++++++++++++++
> target/arm/tcg/cpu32.c | 261 ---------------------------------
> target/arm/tcg/m_helper.c | 3 +-
> target/arm/Kconfig | 4 -
> target/arm/meson.build | 3 +
> target/arm/tcg/meson.build | 3 +
> 6 files changed, 298 insertions(+), 266 deletions(-)
> create mode 100644 target/arm/tcg/cpu-v7m.c
*ping*
Any hints how to continue here? Or is the series fine as it is?
Thomas
prev parent reply other threads:[~2024-03-01 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 8:18 [PATCH v2 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M Thomas Huth
2024-01-29 8:18 ` [PATCH v2 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file Thomas Huth
2024-01-29 8:54 ` Paolo Bonzini
2024-01-29 10:35 ` Peter Maydell
2024-02-01 14:17 ` Peter Maydell
2024-02-01 18:52 ` Thomas Huth
2024-02-22 10:22 ` Thomas Huth
2024-03-04 15:29 ` Peter Maydell
2024-01-29 8:18 ` [PATCH v2 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M Thomas Huth
2024-02-01 14:19 ` Peter Maydell
2024-02-01 19:12 ` Thomas Huth
2024-03-04 15:22 ` Peter Maydell
2024-03-08 12:54 ` Thomas Huth
2024-03-08 14:00 ` Peter Maydell
2024-03-08 14:14 ` Thomas Huth
2024-01-29 8:18 ` [PATCH v2 3/3] target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M Thomas Huth
2024-03-01 19:12 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2585806-d05c-4eef-9a2b-15bf2c68e2c0@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).